[GRASS-dev] [GRASS GIS] #2010: r.in.wms2 fails to install on 6.x

[GRASS GIS]

#2010: r.in.wms2 fails to install on 6.x
-----------------------+----------------------------------------------------
 Reporter:  hamish     |       Owner:  grass-dev@…              
     Type:  defect     |      Status:  new                      
 Priority:  major      |   Milestone:  6.4.4                    
Component:  Addons     |     Version:  svn-releasebranch64      
 Keywords:  r.in.wms2  |    Platform:  Linux                    
      Cpu:  All        |  
-----------------------+----------------------------------------------------

Comment(by hamish):

 Replying to [comment:3 turek]:
 > Hi Hamish,
 >
 > thanks for the fixes. I have ported back to G7 most of them

 I hope you found them useful, if they are bad you don't have to listen to
 me, it's your module after all. :)

 > So far the name of the o flag remains.
 > In description of s flag there is written:
 > Skip requests for fully transparent data
 >
 > I am not sure if it is correct description. If this flag is not
 > present, the data are fetched also with transparent layer (if
 > available). Otherwise you can use bgcolor param with this flag
 > and specify color for these transparent areas.

 I misunderstood it then, in one of the TWMS/r.out.kml script I have
 somewhere it checks if the returned tile is all-white and skips
 warping/mosaicking that so that part of the background becomes NULL not
 255. Is the idea to make a complete rectangle instead of missing tiles in
 the corners? I was wondering how the bgcolor option fit in. If that
 supports standard GRASS colors you might consider adding:
 {{{
   #% gisprompt: old,color_none,color
 }}}
 so from the module GUI the user gets the color-picking tool.

 > The o was chosen as abbreviation for opaque.

 I prefer to avoid -o,-q,-v as option letters if there are others
 available, since it is easy for users to confuse them with --o,--q,--v.
 fwiw I also like to avoid -l, -1, and -I, but for certain-font reasons.

 > Spaces between options are still kept, it seems more clear to me
 > than one block of ~20 options. But it also can be changed.

 shrug, author's choice; the convention elsewhere is compressed but it
 doesn't change the running of the script at all so just cosmetic, and I
 agree it gets a bit hard to read when there are many options. Don't fear
 the whitespace. :)


 a couple observations/wishes:
  * wx: switching from 1.1.1 to 1.3.0 clears selection and resizes window
 height?
  * wx: how about being able to filter the list like the location wizard
 has for projection type Search? (often the servers have 50+ layers to
 search)
  * support for png8 image format? (like qgis has)
  * I get an error when BGCOLOR is unset, does the spec require it or just
 a picky WMS server?
 {{{ <ServiceException>
 BGCOLOR  incorrectly specified (0xRRGGBB format expected)
 </ServiceException></ServiceExceptionReport>
 }}}
  * module gui: Interpolation type isn't part of the server request. ->
 Optional gui tab?


 Also, I'm seeing a unicode error vs. layer Title string in the 6.4.3svn's
 r.in.wms1's wxGUI wrapper. It's not to do with r.in.wms2.py, so I'll post
 that to the -dev ML.


 regards,
 Hamish

 ps- the WMS/WFS I'm using to test with:
  http://wiki.openstreetmap.org/wiki/New_Zealand/Imagery

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/2010#comment:4>
GRASS GIS <http://grass.osgeo.org>