[GRASS-dev] [GRASS GIS] #587: svn versions should better reflect svn rev

[GRASS GIS]

#587: svn versions should better reflect svn rev
--------------------------+-------------------------------------------------
  Reporter:  hamish       |       Owner:  grass-dev@…              
      Type:  enhancement  |      Status:  reopened                 
  Priority:  blocker      |   Milestone:  6.4.2                    
 Component:  Default      |     Version:  svn-trunk                
Resolution:               |    Keywords:  g.version, configure     
  Platform:  All          |         Cpu:  All                      
--------------------------+-------------------------------------------------
Changes (by hamish):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Hi,

 I'm just looking at the 6.4.3 build on Debian/sid, and 'g.version -g' is
 not printing an empty "revision=" as expected, rather it is printing
 "revision=Unversioned directory". This is because of a change in
 'svnversion' behavior between Subversion versions 1.6 and 1.7.

 It's a problem because the space in the string breaks using "eval
 `g.version -g`".


 suggested patch:
 {{{
 --- configure.in        (revision 57623)
 +++ configure.in        (working copy)
 @@ -130,7 +130,7 @@
  AC_PATH_PROG(SVN_VERSION, svnversion, no)
  if test "$SVN_VERSION" != "no" ; then
     GRASS_VERSION_SVN=`$SVN_VERSION -c | cut -f2 -d:`
 -   if test "$GRASS_VERSION_SVN" = "exported" ; then
 +   if test "$GRASS_VERSION_SVN" = "exported" -o "$GRASS_VERSION_SVN" =
 "Unversioned directory" ; then
        GRASS_VERSION_SVN=
     fi
  fi
 }}}

 any comments or objections before I commit?


 Hamish

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/587#comment:67>
GRASS GIS <http://grass.osgeo.org>