[GRASS-dev] [GRASS GIS] #3402: g.gui.gmodeler: trying to add command pushes CPU to 100% and provokes freeze

[GRASS GIS]

#3402: g.gui.gmodeler: trying to add command pushes CPU to 100% and provokes
freeze
--------------------------+-----------------------------
  Reporter:  mlennert     |      Owner:  grass-dev@…
      Type:  defect       |     Status:  new
  Priority:  major        |  Milestone:  7.2.2
 Component:  wxGUI        |    Version:  svn-trunk
Resolution:               |   Keywords:  gmodeler freeze
       CPU:  Unspecified  |   Platform:  Unspecified
--------------------------+-----------------------------

Comment (by mlennert):

 Replying to [comment:14 annakrat]:
 > This is safe, please apply it. But the mystery is that this widget is in
 other places, like in every module dialog.

 All the other examples of usages I've found define a label parameter in
 the call to the widget. The call in SearchModuleWidget seems to be the
 only one that doesn't.

 And if I add a label parameter to the call, such as:


 {{{
 Index: gui/wxpython/gui_core/widgets.py
 ===================================================================
 --- gui/wxpython/gui_core/widgets.py    (révision 71437)
 +++ gui/wxpython/gui_core/widgets.py    (copie de travail)
 @@ -1088,7 +1088,7 @@

          if self._showTip:
              self._searchTip = StaticWrapText(parent=self, id=wx.ID_ANY,
 -                                             size=(-1, 35))
 +                                    label="Choose a module", size=(-1,
 35))

          if self._showChoice:
              self._searchChoice = wx.Choice(parent=self, id=wx.ID_ANY)
 }}}

 the modeler runs perfectly again.

 So, before I apply your patch, I'd rather you tell me whether is it better
 to apply your patch, my patch, here, in order to be able to keep using
 StaticWrapText, or would it be better to find a solution in StaticWrapText
 which allows calling it with an empty string ?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3402#comment:15>
GRASS GIS <https://grass.osgeo.org>