[GRASS-dev] [GRASS GIS] #3926: allow limit viewshed computation by angle

[GRASS GIS]

#3926: allow limit viewshed computation by angle
--------------------------+----------------------------------
  Reporter:  annakrat     |      Owner:  grass-dev@…
      Type:  enhancement  |     Status:  new
  Priority:  normal       |  Milestone:  8.0.0
 Component:  Raster       |    Version:  unspecified
Resolution:               |   Keywords:  r.viewshed, viewshed
       CPU:  All          |   Platform:  All
--------------------------+----------------------------------

Comment (by mmetz):

 Replying to [comment:1 annakrat]:
 > For the record, this is my attempt with hardcoded values, which fails
 with angle 1 to 270 (the viewshed is written but incorrect).
 Interestingly, it works with angle 0 to 270.

 Your PR [https://github.com/OSGeo/grass/pull/180 #180] works for me. I
 tested in the NC dataset with

 {{{
 g.region -p rast=elev_state_500m
 r.viewshed in=elev_state_500m out=viewshed
 coord=637942.9512846764,188095.68718268772 obs=100 direction_range=0,270
 r.viewshed in=elev_state_500m out=viewshed
 coord=637942.9512846764,188095.68718268772 obs=100 direction_range=1,270
 r.viewshed in=elev_state_500m out=viewshed
 coord=637942.9512846764,188095.68718268772 obs=100 direction_range=270,0
 r.viewshed in=elev_state_500m out=viewshed
 coord=637942.9512846764,188095.68718268772 obs=100 direction_range=270,1
 }}}

 and the results seem to be correct.

 Can you provide an example where your PR does not work?

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/3926#comment:2>
GRASS GIS <https://grass.osgeo.org>