<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Hamish, Glynn,<br>
<br>
AFAICT r.le.pixel works fine now, as does r.le.patch.<br>
Remaining problem just in r.le.setup. All of r.le.setup seems to work
except Setup sampling units.<br>
<br>
When setting up sampling units, you are right the problem is likely in
calc_unit_loc in filling the uy array, which holds the y values for
displaying the units on the screen. I have looked through that code and
don't see anything obvious that is wrong, so I will have to insert some
print statements and see what is going on. Other displays of sampling
areas on screen work fine (e.g., in setup for moving window). Seems
strange, since this worked fine under GRASS 5.X and I can't see what
might have changed to affect this. Will work more on this in next few
days, I hope.<br>
<br>
Thanks for cvs tips!<br>
<br>
Yes, Glynn is right this uses display, so this could be d.le.setup.<br>
<br>
Bill B. <br>
<br>
<br>
Hamish wrote:<br>
<blockquote cite="mid20060929134917.616525ef.hamish_nospam@yahoo.com"
type="cite">
<pre wrap="">William L. Baker wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hamish and Glynn, thank you for seeing that with null_buf. In
r.le.patch, I did indeed allocate null_buf as DCELL, not char and that
worked in there, even though it is not the right solution. Hamish, can
you change that allocation statement for null_buf to DCELL and see if
that fixes the crash?
</pre>
</blockquote>
<pre wrap=""><!---->
Yes, it fixes it AFAICT. Applied in CVS. Another one down, thanks Glynn.
</pre>
<blockquote type="cite">
<pre wrap="">I'm not set up yet to do anything and can barely
figure out CVS at this point.
</pre>
</blockquote>
<pre wrap=""><!---->
my 1 minute tutorial:
download latest 6.3-cvs snapshot
un-tar.gz
# connect to CVS server as read-only guest
$ export <a class="moz-txt-link-abbreviated" href="mailto:CVSROOT=:pserver:grass-guest@intevation.de:/home/grass/grassrepository">CVSROOT=:pserver:grass-guest@intevation.de:/home/grass/grassrepository</a>
$ cvs login
pass: grass
#update to latest code
cvs up -dP
#make your changes
cd grass6/raster/r.le/r.le.pixel/
vi cellclip.c
make
# test
vi && make && etc..
#generate patch
cd ../../../..
cvs diff -u grass6/raster/r.le/r.le.pixel/cellclip.c > somepatch.diff
it's handy to make a ~/.cvsrc file. Mine contains:
-z3
diff -u
update -dP
</pre>
<blockquote type="cite">
<pre wrap="">Hamish, as to r.le.setup, at the CHOOSE THE SETUP OPTION step, I
choose Setup sampling units, then Use keyboard to enter sampling unit
dimensions, then 1 for for How many different SCALES, then 1 for
Random nonoverlapping, then "y" for Do you want to sample using
rectangles, then "1.0" for Sampling unit SHAPE, then 144 for
Recommended maximum SIZE followed by "y" it's OK, then 20
sampling units. At that point, the program should draw the sampling
units in red on the monitor, but nothing is displayed. Not sure where
the communication problem is...
</pre>
</blockquote>
<pre wrap=""><!---->
Ah, ok I was trying with the mouse. If you look closely you'll see the
boxes are drawn right at the top of the window. i.e. the y values being
sent to draw_box() are no good. This is because y=0.0 when this calculation
is done:
raster/r.le/r.le.setup/sample, line ~ 878 in calc_unit_loc() back:
draw_box((int)((double)(ux[i])/x), (int)((double)(uy[i])/y),
(int)((double)(ux[i]+u_w)/x), (int)((double)(uy[i]+u_l)/y),
1);
after drawing the boxes (or attempting to anyway),
Distributed unit 20 of 20 requested
Is this set of sampling units OK? (y/n) [y] y
Segmentation fault
but one thing at a time.
Hamish
</pre>
</blockquote>
</body>
</html>