<div dir="ltr"><div>Hi,<br><br>I've realized that an nice icon will save me a lot of time in searching for the right layer/item in layer manager layer tree, so I've just added new icons derived from the SVG version of current icons [1] which are contain only symbol for type of the layer and not unnecessary symbol for layer nor unwanted symbol for add.<br>
<br></div>I've used size 16x16, although other icons are 24x24 (from what I've checked). The reason is that 24x24 were resampled in very ugly way (this is what also the former icons suffered from). I don't know how to deal with this inconsistency without complete redesign of icon handling in wxGUI.<br>
<br>I'm not sure what to do with SVGs. Should I try to put them to OSGeo repository? Is creating ticket the right way?<br><div><br></div><div>Future work is to create this kind of icon for command layer and for grid layer which don't have SVG version in OSGeo repository. Additional future work is to determine if these icons are useful also somewhere else.<br>
</div><div><br></div><div>This commit should not be backported soon because I'm not sure about side effects because of the way of using the defined icons.<br></div><div><br></div><div>Vaclav<br></div><div><br>[1] <a href="http://svn.osgeo.org/osgeo/graphics/trunk/">http://svn.osgeo.org/osgeo/graphics/trunk/</a><br>
[2] <a href="http://trac.osgeo.org/osgeo/browser/graphics/trunk/">trac.osgeo.org/osgeo/browser/graphics/trunk/</a><br><br><br><br>On Sat, Jul 19, 2014 at 12:58 PM, <<a href="mailto:svn_grass@osgeo.org">svn_grass@osgeo.org</a>> wrote:<br>
><br>> Author: wenzeslaus<br>> Date: 2014-07-19 09:58:44 -0700 (Sat, 19 Jul 2014)<br>> New Revision: 61280<br>><br>> Added:<br>> grass/trunk/gui/icons/grass/aspect-arrow.png<br>> grass/trunk/gui/icons/grass/cell-cats.png<br>
> grass/trunk/gui/icons/grass/his.png<br>> grass/trunk/gui/icons/grass/label.png<br>> grass/trunk/gui/icons/grass/raster.png<br>> grass/trunk/gui/icons/grass/raster3d.png<br>> grass/trunk/gui/icons/grass/rgb.png<br>
> grass/trunk/gui/icons/grass/shaded-relief.png<br>> grass/trunk/gui/icons/grass/vector-chart.png<br>> grass/trunk/gui/icons/grass/vector-thematic.png<br>> grass/trunk/gui/icons/grass/vector.png<br>
> grass/trunk/gui/icons/grass/wms.png<br>> Modified:<br>> grass/trunk/gui/wxpython/lmgr/layertree.py<br>> Log:<br>> wxGUI: icons for layers in lmgr tree without 'layer' and 'add' symbols<br>
><br>> Size of icons is 16x16 to avoid imperfect resampling at some (or all) platforms.<br>> The motivation is to make the icons more useful, they now can actually help to recognize type of layer.<br>> The commit assumes that the icon objects defined in layertree are used only for layers, not for other things although item label suggests that.<br>
> Command and grid layer still use the layer-xxx-add icon because there is no SVG for them in OSGeo icons (<a href="http://trac.osgeo.org/osgeo/browser/graphics/trunk/">trac.osgeo.org/osgeo/browser/graphics/trunk/</a>).<br>
> Geodesic and rhumbline layers are already using an icon with this style (the same icon, actually).<br>><br>> Added: grass/trunk/gui/icons/grass/aspect-arrow.png<br>> ===================================================================<br>
> (Binary files differ)<br>><br>><br>> Property changes on: grass/trunk/gui/icons/grass/aspect-arrow.png<br>> ___________________________________________________________________<br>> Added: svn:mime-type<br>
> + image/png<br>><br>> Added: grass/trunk/gui/icons/grass/cell-cats.png<br>> ===================================================================<br>> (Binary files differ)<br>><br>><br>> Property changes on: grass/trunk/gui/icons/grass/cell-cats.png<br>
> ___________________________________________________________________<br>> Added: svn:mime-type<br>> + image/png<br>><br>> Added: grass/trunk/gui/icons/grass/his.png<br>> ===================================================================<br>
> (Binary files differ)<br>><br>><br>> Property changes on: grass/trunk/gui/icons/grass/his.png<br>> ___________________________________________________________________<br>> Added: svn:mime-type<br>> + image/png<br>
><br>> Added: grass/trunk/gui/icons/grass/label.png<br>> ===================================================================<br>> (Binary files differ)<br>><br>><br>> Property changes on: grass/trunk/gui/icons/grass/label.png<br>
> ___________________________________________________________________<br>> Added: svn:mime-type<br>> + image/png<br>><br>> Added: grass/trunk/gui/icons/grass/raster.png<br>> ===================================================================<br>
> (Binary files differ)<br>><br>><br>> Property changes on: grass/trunk/gui/icons/grass/raster.png<br>> ___________________________________________________________________<br>> Added: svn:mime-type<br>> + image/png<br>
><br>> Added: grass/trunk/gui/icons/grass/raster3d.png<br>> ===================================================================<br>> (Binary files differ)<br>><br>><br>> Property changes on: grass/trunk/gui/icons/grass/raster3d.png<br>
> ___________________________________________________________________<br>> Added: svn:mime-type<br>> + image/png<br>><br>> Added: grass/trunk/gui/icons/grass/rgb.png<br>> ===================================================================<br>
> (Binary files differ)<br>><br>><br>> Property changes on: grass/trunk/gui/icons/grass/rgb.png<br>> ___________________________________________________________________<br>> Added: svn:mime-type<br>> + image/png<br>
><br>> Added: grass/trunk/gui/icons/grass/shaded-relief.png<br>> ===================================================================<br>> (Binary files differ)<br>><br>><br>> Property changes on: grass/trunk/gui/icons/grass/shaded-relief.png<br>
> ___________________________________________________________________<br>> Added: svn:mime-type<br>> + image/png<br>><br>> Added: grass/trunk/gui/icons/grass/vector-chart.png<br>> ===================================================================<br>
> (Binary files differ)<br>><br>><br>> Property changes on: grass/trunk/gui/icons/grass/vector-chart.png<br>> ___________________________________________________________________<br>> Added: svn:mime-type<br>
> + image/png<br>><br>> Added: grass/trunk/gui/icons/grass/vector-thematic.png<br>> ===================================================================<br>> (Binary files differ)<br>><br>><br>> Property changes on: grass/trunk/gui/icons/grass/vector-thematic.png<br>
> ___________________________________________________________________<br>> Added: svn:mime-type<br>> + image/png<br>><br>> Added: grass/trunk/gui/icons/grass/vector.png<br>> ===================================================================<br>
> (Binary files differ)<br>><br>><br>> Property changes on: grass/trunk/gui/icons/grass/vector.png<br>> ___________________________________________________________________<br>> Added: svn:mime-type<br>> + image/png<br>
><br>> Added: grass/trunk/gui/icons/grass/wms.png<br>> ===================================================================<br>> (Binary files differ)<br>><br>><br>> Property changes on: grass/trunk/gui/icons/grass/wms.png<br>
> ___________________________________________________________________<br>> Added: svn:mime-type<br>> + image/png<br>><br>> Modified: grass/trunk/gui/wxpython/lmgr/layertree.py<br>> ===================================================================<br>
> --- grass/trunk/gui/wxpython/lmgr/layertree.py 2014-07-19 14:56:40 UTC (rev 61279)<br>> +++ grass/trunk/gui/wxpython/lmgr/layertree.py 2014-07-19 16:58:44 UTC (rev 61280)<br>> @@ -70,23 +70,23 @@<br>> label = _('Add command layer')),<br>
> 'quit' : MetaIcon(img = 'quit',<br>> label = _('Quit')),<br>> - 'layerRaster' : MetaIcon(img = 'layer-raster-add',<br>> + 'layerRaster' : MetaIcon(img = 'raster',<br>
> label = _('Add raster map layer')),<br>> - 'layerRgb' : MetaIcon(img = 'layer-rgb-add',<br>> + 'layerRgb' : MetaIcon(img = 'rgb',<br>
> label = _('Add RGB map layer')),<br>> - 'layerHis' : MetaIcon(img = 'layer-his-add',<br>> + 'layerHis' : MetaIcon(img = 'his',<br>
> label = _('Add HIS map layer')),<br>> - 'layerShaded' : MetaIcon(img = 'layer-shaded-relief-add',<br>> + 'layerShaded' : MetaIcon(img = 'shaded-relief',<br>
> label = _('Add shaded relief map layer')),<br>> - 'layerRastarrow' : MetaIcon(img = 'layer-aspect-arrow-add',<br>> + 'layerRastarrow' : MetaIcon(img = 'aspect-arrow',<br>
> label = _('Add raster flow arrows')),<br>> - 'layerRastnum' : MetaIcon(img = 'layer-cell-cats-add',<br>> + 'layerRastnum' : MetaIcon(img = 'cell-cats',<br>
> label = _('Add raster cell numbers')),<br>> - 'layerVector' : MetaIcon(img = 'layer-vector-add',<br>> + 'layerVector' : MetaIcon(img = 'vector',<br>
> label = _('Add vector map layer')),<br>> - 'layerThememap': MetaIcon(img = 'layer-vector-thematic-add',<br>> + 'layerThememap': MetaIcon(img = 'vector-thematic',<br>
> label = _('Add thematic area (choropleth) map layer')),<br>> - 'layerThemechart' : MetaIcon(img = 'layer-vector-chart-add',<br>> + 'layerThemechart' : MetaIcon(img = 'vector-chart',<br>
> label = _('Add thematic chart layer')),<br>> 'layerGrid' : MetaIcon(img = 'layer-grid-add',<br>> label = _('Add grid layer')),<br>
> @@ -94,12 +94,12 @@<br>> label = _('Add geodesic line layer')),<br>> 'layerRhumb' : MetaIcon(img = 'shortest-distance',<br>> label = _('Add rhumbline layer')),<br>
> - 'layerLabels' : MetaIcon(img = 'layer-label-add',<br>> + 'layerLabels' : MetaIcon(img = 'label',<br>> label = _('Add labels')),<br>
> - 'layer3d-raster' : MetaIcon(img = 'layer-raster3d-add',<br>> + 'layer3d-raster' : MetaIcon(img = 'raster3d',<br>> label = _('Add 3D raster map layer'),<br>
> desc = _('Note that 3D raster data are rendered only in 3D view mode')),<br>> - 'layerWms' : MetaIcon(img = 'layer-wms-add',<br>> + 'layerWms' : MetaIcon(img = 'wms',<br>
> label = _('Add WMS layer.')),<br>> 'layerOptions' : MetaIcon(img = 'options',<br>> label = _('Set options')),<br>
><br>> _______________________________________________<br>> grass-commit mailing list<br>> <a href="mailto:grass-commit@lists.osgeo.org">grass-commit@lists.osgeo.org</a><br>> <a href="http://lists.osgeo.org/mailman/listinfo/grass-commit">http://lists.osgeo.org/mailman/listinfo/grass-commit</a><br>
<br></div></div>