<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 8, 2014 at 6:06 PM, Glynn Clements <span dir="ltr"><<a href="mailto:glynn@gclements.plus.com" target="_blank">glynn@gclements.plus.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class=""><br>
Glynn Clements wrote:<br>
<br>
> But there's a rather more fundamental issue here: if G_find_file() is<br>
> called for an element which isn't guaranteed to exist for every map,<br>
> it will "find" the first map which actually contains that element,<br>
> which isn't necessarily the same map as for the other elements.<br>
><br>
> This doesn't affect the primary components of a map, because<br>
> Rast_open_old() first determines the mapset, then passes an explicit<br>
> mapset to the various G_open_* functions.<br>
><br>
> So, I think that G_find_file() etc should only be used in "find mode"<br>
> (with an empty mapset) for the "primary" element of a map (i.e.<br>
> "cellhd" for raster maps, the map directory for vector maps). Other<br>
> components should be located by first finding the mapset, then using<br>
> the mapset to locate any additional components.<br>
<br>
</span>Fixed (hopefully) in r61840.<br>
<br></blockquote><br>It seems that r61840 breaks a lot of tests. The yesterdays version (which is by chance r61839) is working. There are errors like<br><br>ERROR: Raster map <elevation> not found<br><br>for example for g.region and <a href="http://r.info">r.info</a>.<div><br></div><div><a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-09-08-07-00/report_for_nc_spm_08_grass7_nc/testfiles.html">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-09-08-07-00/report_for_nc_spm_08_grass7_nc/testfiles.html</a><br><a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-09-09-07-00/report_for_nc_spm_08_grass7_nc/testfiles.html">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-09-09-07-00/report_for_nc_spm_08_grass7_nc/testfiles.html</a><br><a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-09-09-07-00/report_for_nc_spm_08_grass7_nc/raster/r.slope.aspect/test_r_slope_aspect/index.html">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-09-09-07-00/report_for_nc_spm_08_grass7_nc/raster/r.slope.aspect/test_r_slope_aspect/index.html</a><br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
This change also reduces the number of warnings; a warning is only<br>
generated when searching for the primary element.<br>
<br>
Given that it's a fairly fundamental change, it should be tested.<br>
<br>
OTOH, given that it fixes a fairly fundamental bug, it should go into<br>
at least one beta prior to any final release.<br>
<div class=""><div class="h5"><br>
--<br>
Glynn Clements <<a href="mailto:glynn@gclements.plus.com">glynn@gclements.plus.com</a>><br>
_______________________________________________<br>
grass-dev mailing list<br>
<a href="mailto:grass-dev@lists.osgeo.org">grass-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/grass-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/grass-dev</a><br>
</div></div></blockquote></div><br></div></div>