<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 28, 2014 at 9:05 AM, Moritz Lennert <span dir="ltr"><<a href="mailto:mlennert@club.worldonline.be" target="_blank">mlennert@club.worldonline.be</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div>On 28/11/14 14:51, GRASS GIS wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
#2409: last call for options keys consolidation<br>
------------------------------<u></u>----+-------------------------<u></u>----------------<br>
Reporter: martinl | Owner: grass-dev@…<br>
Type: task | Status: new<br>
Priority: blocker | Milestone: 7.0.0<br>
Component: Default | Version: unspecified<br>
Keywords: standardized options | Platform: Unspecified<br>
Cpu: Unspecified |<br>
------------------------------<u></u>----+-------------------------<u></u>----------------<br>
<br>
Comment(by huhabla):<br>
<br>
I am not against renaming the options, but IMHO its completely<br>
unnecessary. However, if the majority thinks it is necessary then i am<br>
fine with that.<br>
<br>
But the recent changes in the option naming broke the temporal framework<br>
and as a result many temporal modules and tests.<br>
<br>
Why??!!<br>
<br>
If such invasive changes are performed, then i would expect that all the<br>
consequences of these changes are recognized and fixed before the commit!<br>
<br>
We have a wonderful testsuite, so please use it to detect possible issues.<br>
Please do not simply break GRASS and expect that other developers will fix<br>
it.<br>
</blockquote>
<br></div></div>
Yes, I've already stumbled upon one test which fails because of changed type name (r.slope.aspect test calls g.remove with type="rast").<br>
<br>
I agree with Soeren that we have to be careful about these changes, especially if we want to release in a not too far future...<span><font color="#888888"><br>
<br></font></span></blockquote>To run all tests before a commit run:<br><br>python -m grass.gunittest.main --location nc_spm_grass7 --location-type nc<br><br></div><div class="gmail_quote">inside GRASS session. nc_spm_grass7 should be the name of NC sample location in your current GISDBASE (grassdata). The command will also work in any subdirectory.<br></div><div class="gmail_quote"><br></div><div class="gmail_quote">To run just one test file, cd to testsuite directory with the test file and run<br><br>python test_something.py<br><br></div><div class="gmail_quote">inside GRASS session. This will use the current location and mapset.<br><br></div><div class="gmail_quote">See more at:<br><br><a href="http://grass.osgeo.org/grass71/manuals/libpython/gunittest_testing.html" target="_blank">http://grass.osgeo.org/grass71/manuals/libpython/gunittest_testing.html</a><br><a href="http://grass.osgeo.org/grass71/manuals/libpython/gunittest_running_tests.html" target="_blank">http://grass.osgeo.org/grass71/manuals/libpython/gunittest_running_tests.html</a><br></div><div class="gmail_quote"><br></div><div class="gmail_quote">To see the results of tests which currently run once a day on a server, see:<br><br><a href="http://fatra.cnr.ncsu.edu/grassgistests/" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/</a><br><br></div><div class="gmail_quote">The most interesting is the report for nc location:<br><br><a href="http://fatra.cnr.ncsu.edu/grassgistests/summary_report/nc/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/summary_report/nc/index.html</a><br><br></div><div class="gmail_quote">Which currently ends with:<br></div><div class="gmail_quote">...<br>2014-11-26 03:01:42 62954 nc_spm_08_grass7 85% 98%<br>2014-11-27 03:01:47 63174 nc_spm_08_grass7 38% 80%<br>2014-11-28 03:01:44 63217 nc_spm_08_grass7 39% 81%<br><br></div><div class="gmail_quote">The recent report for individual test files is:<br><br><a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-11-28-08-00/report_for_nc_spm_08_grass7_nc/testfiles.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-11-28-08-00/report_for_nc_spm_08_grass7_nc/testfiles.html</a><br><br></div><div class="gmail_quote">When running the test yourself, you will get the same output as you can see online for one day. So, your index.html should look like:<br><br><a href="http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-11-28-08-00/report_for_nc_spm_08_grass7_nc/index.html" target="_blank">http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-11-28-08-00/report_for_nc_spm_08_grass7_nc/index.html</a><br><br></div><div class="gmail_quote">You will find this index.html file in a testreport directory after running the tests using `python -m grass.gunittest.main ...`.<br></div><div class="gmail_quote"><br></div><div class="gmail_quote">Vaclav<br></div><div class="gmail_quote"><br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span><font color="#888888">
Moritz</font></span><div><div><br>
______________________________<u></u>_________________<br>
grass-dev mailing list<br>
<a href="mailto:grass-dev@lists.osgeo.org" target="_blank">grass-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/grass-dev" target="_blank">http://lists.osgeo.org/<u></u>mailman/listinfo/grass-dev</a></div></div></blockquote></div><br></div></div>