<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 18, 2015 at 10:08 AM, Moritz Lennert <span dir="ltr"><<a href="mailto:mlennert@club.worldonline.be" target="_blank">mlennert@club.worldonline.be</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">On 18/06/15 15:48, Vaclav Petras wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
<br>
On Wed, Jun 17, 2015 at 10:14 AM, <<a href="mailto:svn_grass@osgeo.org" target="_blank">svn_grass@osgeo.org</a><br></span><span class="">
<mailto:<a href="mailto:svn_grass@osgeo.org" target="_blank">svn_grass@osgeo.org</a>>> wrote:<br>
><br>
> Modified: grass/trunk/locale/po/grasslibs_fr.po<br>
> ===================================================================<br>
> --- grass/trunk/locale/po/grasslibs_fr.po 2015-06-17 13:53:52<br>
UTC (rev 65496)<br>
> +++ grass/trunk/locale/po/grasslibs_fr.po 2015-06-17 14:14:56<br>
UTC (rev 65497)<br>
> @@ -1909,7 +1909,7 @@<br>
> #: ../lib/init/grass.py:130 ../lib/gis/parser.c:599<br>
> #, fuzzy<br>
> msgid "ERROR"<br>
> -msgstr "ERREUR :"<br>
> +msgstr "ERREUR: "<br>
<br>
Hi Mortitz, I'm not experienced with translations but it seems to me<br>
that the translations doesn't need to be fuzzy<br>
</span></blockquote>
<br>
Don't know about the fuzzy, I didn't touch that.<span class=""><br></span></blockquote><div><br></div><div>As I said my experience is limited but I though that when you translate the string manually, you remove fuzzy.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
and it should not contain<br>
colon and space but only "ERREUR".<br>
</blockquote>
<br></span>
Well lib/gis/error.c, l 360ff define:<br>
<br>
prefix_std[0] = "";<br>
prefix_std[1] = _("WARNING: ");<br>
prefix_std[2] = _("ERROR: ");<br></blockquote><div><br></div><div>According to your commit there is "ERROR: " but also "ERROR" somewhere. "ERROR: " should be translated as "<span class="">ERREUR</span>: " while "ERROR"<span class=""> as "ERREUR". That's what I was trying to say.</span> </div><div><br><a href="https://trac.osgeo.org/grass/changeset/65497">https://trac.osgeo.org/grass/changeset/65497</a><br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
so I guess the translation should also have the colon and space. We could do something like this:<br>
<br>
char *postfix<br>
postfix = ": "<br>
prefix_std[0] = "";<br>
prefix_std[1] = _("WARNING%s", postfix);<br>
prefix_std[2] = _("ERROR%s", postfix);<br></blockquote><div><br></div><div>That's unnecessary complicated and it doesn't solve all issues as you note below. Having two different strings, with and without colon&space, should account for most of the cases (the state we have now).<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
But then again, maybe there are different rules of how to position colons and spaces according to locales.<span class=""><font color="#888888"><br></font></span></blockquote><div><br></div><div>I don't know the current situation but ideally, the error message should be composed using [in Python syntax]:<br><br></div><div>_("ERROR: %s") % msg<br><br></div><div>rather then<br><br></div><div>_("ERROR: ") + msg<br><br></div><div>But this would require two step construction of the message since `msg` again will have again variable parts and it might be too complex or too cumbersome (especially in C unless there is some gettext feature which would help us).<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class=""><font color="#888888">
<br>
Moritz<br>
</font></span></blockquote></div><br></div></div>