<div dir="ltr">Hi,<div class="gmail_extra">In my humble opinion we should accept only new modules in core, that are covered by gunittets and this should not only be related to addons. Every new module must have tests.</div><div class="gmail_extra"><br></div><div class="gmail_extra">The consequence in moving addons into core is that the "core" developers have to maintain those modules. If modifications are performed in the core C- or Python libraries, then all modules have to be tested against these changes.</div><div class="gmail_extra"><br><div class="gmail_quote">2016-10-01 21:25 GMT+02:00 Blumentrath, Stefan <span dir="ltr"><<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@nina.no</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="NO-BOK">
<div class="m_-9118461203417305113gmail-m_-8826863644883179787WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)">Sounds fair enough as requirements for new core modules. “Maintainable code” would in praxis mean “the module has undergone
a code review by a core developer”?</span></p></div></div></blockquote><div><br></div><div>Code review by developers is a good idea. Suggestion, only modules positively reviewed by two developers, should be added to core. This will enhance the code quality of new modules and will give the addon developers the opportunity to show their skills in developing good code.</div><div><br></div><div>IMHO, to keep GRASS maintainable, we have to issue this kind restrictions. There is already plenty of hard to maintain code in GRASS, we don't need more of this. </div><div><br></div><div>However, there is still the very nice and comfortable way to use g.extension to install addons.</div><div><br></div><div>Best</div><div>Sören</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="NO-BOK"><div class="m_-9118461203417305113gmail-m_-8826863644883179787WordSection1"><p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)"> <u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)">Those requirements would add to Markus requirement of “maturity”, which I would interpret like “the module has been tested
in praxis and options and flags are consolidated” (so no major changes are expected / planned)...?
<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)">I am afraid, it seems only very few of the suggested modules are covered with unit tests. Most of them have a good documentation.
No idea about the maintainability of the code...</span></p></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="NO-BOK"><div class="m_-9118461203417305113gmail-m_-8826863644883179787WordSection1"><p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)">How should we proceed with this topic? Should the named modules (and from my point of view Moritz OBIA modules would be
very welcome too) be considered as a kind of “wish list” from the community? Probably more voices would be needed, as we currently have no “download statistics” or similar measures which may tell us something about the popularity or wide spread application
of a module that would give reason to integrate it into core...<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)">Where should such wishes be collected? A wiki page? Knowing of such interest might be an incentive for an addon-developer
to write a test or to improve documentation...<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)">Identified candidates could be added to core once they fulfill the requirements above. Would that happen only in minor
releases or would that also be possible in point releases?</span></p></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="NO-BOK"><div class="m_-9118461203417305113gmail-m_-8826863644883179787WordSection1"><p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)">Or is that already too much formality and if someone wishes to see an addon in core that is simply discussed on ML?<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)">Cheers<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)">Stefan<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif">From:</span></b><span lang="EN-US" style="font-size:11pt;font-family:calibri,sans-serif"> grass-dev [mailto:<a href="mailto:grass-dev-bounces@lists.osgeo.org" target="_blank">grass-dev-bounces@list<wbr>s.osgeo.org</a>]
<b>On Behalf Of </b>Sören Gebbert<br>
<b>Sent:</b> 30. september 2016 22:29<br>
<b>To:</b> Markus Neteler <<a href="mailto:neteler@osgeo.org" target="_blank">neteler@osgeo.org</a>><br>
<b>Cc:</b> GRASS developers list <<a href="mailto:grass-dev@lists.osgeo.org" target="_blank">grass-dev@lists.osgeo.org</a>><span class="m_-9118461203417305113gmail-"><br>
<b>Subject:</b> Re: [GRASS-dev] Upcoming 7.2.0: review which addons to move to core<u></u><u></u></span></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<div>
<div>
<p class="MsoNormal"><span lang="EN-US">Hi,<u></u><u></u></span></p>
</div><div><div class="m_-9118461203417305113gmail-h5">
<p class="MsoNormal"><span lang="EN-US">I would strongly suggest to move only those addons into core, that have good documentation, maintainable code and python tests that run in the gunittest framework.<u></u><u></u></span></p>
<div>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">Just my 2c<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">Sören<u></u><u></u></span></p>
</div>
</div></div></div><div><div class="m_-9118461203417305113gmail-h5">
<div>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<div>
<p class="MsoNormal"><span lang="EN-US">2016-07-03 20:09 GMT+02:00 Markus Neteler <</span><a href="mailto:neteler@osgeo.org" target="_blank"><span lang="EN-US">neteler@osgeo.org</span></a><span lang="EN-US">>:<u></u><u></u></span></p>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin:5pt 0cm 5pt 4.8pt">
<p><span lang="EN-US">Hi,<u></u><u></u></span></p>
<p><span lang="EN-US">we may consider to move a few (!) mature addons to core.<u></u><u></u></span></p>
<p><span lang="EN-US">Thoughts?<u></u><u></u></span></p>
<p><span lang="EN-US" style="color:rgb(136,136,136)">Markus<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><br>
______________________________<wbr>_________________<br>
grass-dev mailing list<br>
</span><a href="mailto:grass-dev@lists.osgeo.org" target="_blank"><span lang="EN-US">grass-dev@lists.osgeo.org</span></a><span lang="EN-US"><br>
</span><a href="http://lists.osgeo.org/mailman/listinfo/grass-dev" target="_blank"><span lang="EN-US">http://lists.osgeo.org/mailman<wbr>/listinfo/grass-dev</span></a><span lang="EN-US"><u></u><u></u></span></p>
</blockquote>
</div>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
</div>
</div></div></div>
</div>
<br>______________________________<wbr>_________________<br>
grass-dev mailing list<br>
<a href="mailto:grass-dev@lists.osgeo.org" target="_blank">grass-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/grass-dev" rel="noreferrer" target="_blank">http://lists.osgeo.org/mailman<wbr>/listinfo/grass-dev</a><br></blockquote></div><br></div></div>