<div dir="ltr">Hi all!<div>I have just added a new version of the grass python script to my GitHub repository [0].</div><div>I tried to clean up the code. </div><div>As always, any feedback is welcome!</div><div><br></div><div>Thanks in advance!</div><div><br></div><div>Roberta</div><div><br></div><div>[0] <a href="https://github.com/RobiFag/GRASS_clouds_and_shadows" target="_blank" style="color:rgb(17,85,204);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">https://github.com/<wbr>RobiFag/GRASS_clouds_and_<wbr>shadows</a><br><div class="gmail_extra"><br><div class="gmail_quote">2018-05-21 15:19 GMT+02:00 Roberta Fagandini <span dir="ltr"><<a href="mailto:robifagandini@gmail.com" target="_blank">robifagandini@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Ciao Stefan!<br><div class="gmail_extra"><br><div class="gmail_quote"><span>2018-05-20 21:44 GMT+02:00 Stefan Blumentrath <span dir="ltr"><<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@nina.no</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<div dir="auto" style="direction:ltr;margin:0px;padding:0px;font-family:sans-serif;font-size:11pt;color:black">
Ciao Roberta, <br>
<br>
</div>
<div dir="auto" style="direction:ltr;margin:0px;padding:0px;font-family:sans-serif;font-size:11pt;color:black">
Thanks for the comprehensive report! <br>
<br>
</div>
<div dir="auto" style="direction:ltr;margin:0px;padding:0px;font-family:sans-serif;font-size:11pt;color:black">
One general hint: Even if the drawback is complex expression(s) I would suggest merging r.mapcalc calls. That can improve performance quite a bit (less data read and written) and reduces the need to manage temporary data.
<br>
<br>
</div>
<div dir="auto" style="direction:ltr;margin:0px;padding:0px;font-family:sans-serif;font-size:11pt;color:black">
See also: <a href="https://grass.osgeo.org/grass74/manuals/r.mapcalc.html#multiple-computations" target="_blank">
https://grass.osgeo.org/</a><a href="https://grass.osgeo.org/grass74/manuals/r.mapcalc.html#multiple-computations" target="_blank">grass7<wbr>4</a><a href="https://grass.osgeo.org/grass74/manuals/r.mapcalc.html#multiple-computations" target="_blank">/manuals/r.mapcalc.html#multi<wbr>ple-computations</a>
<br>
<br>
</div>
<div dir="auto" style="direction:ltr;margin:0px;padding:0px;font-family:sans-serif;font-size:11pt;color:black">
If you don't need the first_... To fifth_... files later, I would even say everything in 3rd_procedure.py until r.to.vect could be solved in a single mapcalc operation...<br></div></div></blockquote><div><br></div></span><div>Thank you so much for your hints! I'm trying to clean up the code without creating a too complex expression..I hope to share the new version by this evening or tomorrow at the latest.</div><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div dir="auto" style="direction:ltr;margin:0px;padding:0px;font-family:sans-serif;font-size:11pt;color:black">
<br>
</div>
<div dir="auto" style="direction:ltr;margin:0px;padding:0px;font-family:sans-serif;font-size:11pt;color:black">
Kind regards and again thank for your GSoC work, <br>
</div>
<div dir="auto" style="direction:ltr;margin:0px;padding:0px;font-family:sans-serif;font-size:11pt;color:black">
Stefan
<div dir="auto" style="direction:ltr;margin:0px;padding:0px;font-family:sans-serif;font-size:11pt;color:black">
<br></div></div></div></blockquote><div><br></div></span><div>Thanks again!!</div><span class="gmail-m_5011395501731790359HOEnZb"><font color="#888888"><div>Roberta</div></font></span><div><div class="gmail-m_5011395501731790359h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div dir="auto" style="direction:ltr;margin:0px;padding:0px;font-family:sans-serif;font-size:11pt;color:black"><div dir="auto" style="direction:ltr;margin:0px;padding:0px;font-family:sans-serif;font-size:11pt;color:black">
</div>
<br>
</div>
<hr style="display:inline-block;width:98%">
<div id="gmail-m_5011395501731790359m_1970257380134176614m_1168129798035116451divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> grass-dev <<a href="mailto:grass-dev-bounces@lists.osgeo.org" target="_blank">grass-dev-bounces@lists.osgeo<wbr>.org</a>> on behalf of Roberta Fagandini <<a href="mailto:robifagandini@gmail.com" target="_blank">robifagandini@gmail.com</a>><br>
<b>Sent:</b> Sunday, May 20, 2018 4:33:57 PM<br>
<b>To:</b> <a href="mailto:soc@lists.osgeo.org" target="_blank">soc@lists.osgeo.org</a>; GRASS developers list<br>
<b>Subject:</b> [GRASS-dev] GSoC 2018 report week 01 - GRASS GIS module for Sentinel-2 cloud and shadow detection</font>
<div> </div>
</div><div><div class="gmail-m_5011395501731790359m_1970257380134176614h5">
<div>
<div dir="ltr">
<div><span style="color:rgb(34,34,34);font-size:12.8px;font-style:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline"><font face="arial, helvetica, sans-serif">Hi
all!</font></span></div>
<div><span style="color:rgb(34,34,34);font-size:12.8px;font-style:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline"><font face="arial, helvetica, sans-serif">I'm
Roberta Fagandini and I'm working on my GSoC project, a </font></span><font face="arial, helvetica, sans-serif"><span style="font-size:12.8px">GRASS GIS module for Sentinel-2 cloud and shadow detection.</span></font></div>
<span style="color:rgb(34,34,34);font-size:12.8px;font-style:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline"><font face="arial, helvetica, sans-serif">
<div style="font-weight:400"><span style="color:rgb(34,34,34);font-size:12.8px;font-style:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline">This
is my report for the first week of coding.</span></div>
<div style="font-weight:400"><span style="color:rgb(34,34,34);font-size:12.8px;font-style:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline"><span style="color:rgb(0,0,0);font-size:small;font-style:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline">Since
my progress has been a bit faster than expected I have already discussed with my mentors about further additions to the project. Therefore I have already updated my wiki page [0] changing the timeline. In this way, I will be able to release a more complete
module.</span><br>
</span></div>
<div style="font-weight:400"><span style="color:rgb(34,34,34);font-size:12.8px;font-style:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline"><br>
</span></div>
<b>1) What did I complete this week?</b></font></span>
<div>
<ul>
<li>Checked the prototype version of the algorithm for cloud and shadow detection<br>
</li><li>Tested it </li><li><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-weight:400;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline">I
better studied the documentation of the GRASS Python Scripting Library and s</span>tarted coding the GRASS python script following the workflow schema prepared during the bonding period [1]</li><li>Coded the 'data preparation' phase</li><li>Coded the clouds detection procedure</li><li>Added this first part of python script to my GitHub repository [2]</li><li>Discussed with my mentors about further additions</li><li>Discussed with the community about testing phase. I received some feedback and some developers stepped forward to help me in testing the algorithm <br>
</li><li>Shared progress with the community<br>
</li></ul>
<div>Unfortunately, I wasn't able to code on Thursday because of a PhD meeting with my supervisor.</div>
</div>
<div><font face="arial, helvetica, sans-serif"><br style="color:rgb(34,34,34);font-size:12.8px;font-style:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">
<span style="color:rgb(34,34,34);font-size:12.8px;font-style:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline"><b>2)
What am I going to achieve for next week?</b></span></font></div>
<div>
<ul>
<li>Finish the translation of the algorithm in a basic python script adding the shadows detection procedure and the steps for checking and cleaning the final outputs (see [1] for details)<br>
</li><li>Improve the python script so as to have a "light" working python script (manage temporary file, clean up the code, etc.)<br>
</li><li>Test it and fix bugs<br>
</li><li>Start implementing the GUI</li></ul>
</div>
<div><font face="arial, helvetica, sans-serif"><b><span style="color:rgb(34,34,34);font-size:12.8px;font-style:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline">3)
Is there any blocking issue?</span></b></font>
<div><span style="text-align:start;text-indent:0px;background-color:rgb(255,255,255);float:none;display:inline"><font face="arial, helvetica, sans-serif" color="#000000">
<div>No at the moment. </div>
<div><br>
</div>
<div>Best wishes,</div>
<div>Roberta</div>
<div><br>
</div>
<div>
<div>[0] <a href="https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection" target="_blank">
https://trac.osgeo.org/grass/w<wbr>iki/GSoC/2018/CloudsAndShadows<wbr>Detection</a></div>
<div>[1] <a href="https://drive.google.com/file/d/1KYEKvNBurBFHw1xUTLjM0PW80Z-7br81/view?usp=sharing" target="_blank">https://drive.google.com/f<wbr>ile/d/1KYEKvNBurBFHw1xUTLjM0PW<wbr>80Z-7br81/view?usp=sharing</a></div>
<div>[2] <a href="https://github.com/RobiFag/GRASS_clouds_and_shadows" target="_blank">
https://github.com/RobiFag/GRA<wbr>SS_clouds_and_shadows</a></div>
</div>
</font></span></div>
</div>
</div>
</div>
</div></div></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div></div>