<div dir="ltr"><div dir="auto"></div><div>I'm putting the conversation back on mailing, I hope that alright.</div><br><div><div class="gmail_quote"><div dir="ltr">On Wed, Aug 8, 2018, 1:40 AM Anika Bettge <<a href="mailto:bettge@mundialis.de" target="_blank">bettge@mundialis.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>Hi Vaclav,</p>
<p>I used the pep8 tool. I get two different informations:<br>
</p>
<ol>
<li>E265 block comment should start with '# '<br>
when I use '# %' instead of '#%' then are my parameter not
valid, e.g. "FEHLER: r.in.pdal: Sorry, <input> is not a
valid parameter"</li></ol></div></blockquote><div><br></div><div>These are exception, you have to keep them as they are. See the page I linked for info on how to silence them (I usually just leave them on).</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><ol>
<li>E501 line too long (537 > 150 characters)<br>
This is in the description of the method parameter and I do not
know how to write these in more than one line.</li></ol></div></blockquote><div><br></div><div>In the description that's again a special case.</div><div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><ol>
</ol>
<p>Do you know how I can solve these style problems?<br></p></div></blockquote><div><br></div><div>If you would use some other tools than just pep8, I'm often using pylint, you will get a lot messages and you need to decide which are relevant. The main point here is to minimize them so that the code is as standardized as possible (and thus hopefully more readable).</div><div><br></div><div>I hope this clarifies that,<br></div><div>Vaclav<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><p>
</p>
<p>Best regards,</p>
<p>Anika<br>
</p>
<p><br>
</p>
<br>
<div class="m_98728086574732521m_-1070590422571950848moz-cite-prefix">Am 08.08.2018 um 03:57 schrieb Vaclav
Petras:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Hi Anika,</div>
<div><br>
</div>
<div>I'm glad to finally see this module; now I'm testing it.
Please review the code and the submission guidelines.
Basically it boils down to "use pep8 tool." See the following
for details.<br>
</div>
<div><br>
</div>
<div><a href="https://trac.osgeo.org/grass/wiki/Submitting/Python#Style" rel="noreferrer" target="_blank">https://trac.osgeo.org/grass/<wbr>wiki/Submitting/Python#Style</a><br>
</div>
<div><br>
</div>
<div>To improve it even more, you can use
lower_case_with_underscores (aka snake_case) instead of
CamelCase/camelCase for variables and functions.</div>
<div><br>
</div>
<div>Thank you,</div>
<div>Vaclav<br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Aug 6, 2018 at 6:50 AM, Markus
Metz <span dir="ltr"><<a href="mailto:markus.metz.giswork@gmail.com" rel="noreferrer" target="_blank">markus.metz.giswork@gmail.com</a><wbr>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><span><br>
<br>
2018-08-06 12:12 GMT+02:00 Anika Bettge <<a href="mailto:bettge@mundialis.de" rel="noreferrer" target="_blank">bettge@mundialis.de</a>>:<br>
><br>
> Hi all,<br>
><br>
> I just uploaded my first GRASS GIS addon r.in.pdal:<br>
><br>
> <a href="https://trac.osgeo.org/grass/browser/grass-addons/grass7/raster/r.in.pdal" rel="noreferrer" target="_blank">https://trac.osgeo.org/grass/<wbr>browser/grass-addons/grass7/<wbr>raster/r.in.pdal</a>.<br>
<div><br>
</div>
</span>
<div>Thanks a lot to your contribution Anika!</div>
<div><br>
</div>
<div>A few cosmetic suggestions:</div>
<div><br>
</div>
<div>the print command in L268 should be replaced with
grass.message because this is not shell-style output</div>
<div>L353:</div>
<div> grass.message(_("Generating output raster
map <%s>...") % outfile)<br>
</div>
<div>seems to be at the wrong place because nothing
happens after that message</div>
<div>same for L191</div>
<div><br>
</div>
<div>you can you set the metadata on the resultant output
raster with r.support, otherwise metadata will be set by
<a href="http://r.in.xyz" rel="noreferrer" target="_blank">r.in.xyz</a> (the module that
actually created the raster)<br>
</div>
<div><br>
</div>
<div>there are some comments on gdalwarp, but gdalwarp is
not used by r.in.pdal</div>
<div><br>
</div>
<div>Best,</div>
<div><br>
</div>
<div>Markus M</div>
<span>
<div><br>
</div>
<div>></div>
><br>
> Best regards,<br>
> Anika<br>
><br>
> --<br>
> <br>
> Anika Bettge<br>
> - Anwendungsentwicklerin -<br>
><br>
> mundialis GmbH & Co. KG<br>
> Kölnstraße 99<br>
> 53111 Bonn<br>
><br>
> Tel: +49 (0)228 / 38 75 80 -80<br>
> Fax: +49 (0)228 / 96 28 99 -57<br>
><br>
> Email: <a href="mailto:bettge@mundialis.de" rel="noreferrer" target="_blank">bettge@mundialis.de</a><br>
> Web: <a href="https://www.mundialis.de" rel="noreferrer" target="_blank">https://www.mundialis.de</a><br>
><br>
> Amtsgericht Bonn, HRA 8528<br>
> Komplementärin: mundialis Verwaltungsgesellschaft
mbH<br>
> vertreten durch: Dr. Markus Neteler, Hinrich
Paulsen, Till Adams<br>
> <br>
> Informationen über Ihre gespeicherten Daten
finden Sie auf unserer Homepage unter folgendem Link:<br>
> <a href="https://www.mundialis.de/datenschutzerklaerung" rel="noreferrer" target="_blank">https://www.mundialis.de/<wbr>datenschutzerklaerung</a><br>
><br>
> ______________________________<wbr>_________________<br>
> grass-dev mailing list<br>
> <a href="mailto:grass-dev@lists.osgeo.org" rel="noreferrer" target="_blank">grass-dev@lists.osgeo.org</a><br>
> <a href="https://lists.osgeo.org/mailman/listinfo/grass-dev" rel="noreferrer" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/grass-dev</a><br>
<br>
</span></div>
<br>
______________________________<wbr>_________________<br>
grass-dev mailing list<br>
<a href="mailto:grass-dev@lists.osgeo.org" rel="noreferrer" target="_blank">grass-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/grass-dev" rel="noreferrer noreferrer" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/grass-dev</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre class="m_98728086574732521m_-1070590422571950848moz-signature" cols="72">--
Anika Bettge
- Anwendungsentwicklerin -
mundialis GmbH & Co. KG
Kölnstraße 99
53111 Bonn
Tel: +49 (0)228 / 38 75 80 -80
Fax: +49 (0)228 / 96 28 99 -57
Email: <a class="m_98728086574732521m_-1070590422571950848moz-txt-link-abbreviated" href="mailto:bettge@mundialis.de" rel="noreferrer" target="_blank">bettge@mundialis.de</a>
Web: <a class="m_98728086574732521m_-1070590422571950848moz-txt-link-freetext" href="https://www.mundialis.de" rel="noreferrer" target="_blank">https://www.mundialis.de</a>
Amtsgericht Bonn, HRA 8528
Komplementärin: mundialis Verwaltungsgesellschaft mbH
vertreten durch: Dr. Markus Neteler, Hinrich Paulsen, Till Adams
Informationen über Ihre gespeicherten Daten finden Sie auf unserer Homepage unter folgendem Link:
<a class="m_98728086574732521m_-1070590422571950848moz-txt-link-freetext" href="https://www.mundialis.de/datenschutzerklaerung" rel="noreferrer" target="_blank">https://www.mundialis.de/<wbr>datenschutzerklaerung</a></pre>
</div>
</blockquote></div>
</div></div>