<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="NO-BOK" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">Hi Markus,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">Unfortunately, the test will have to be more or less rewritten, which is why I for now chose to deactivate it with an info message pointing to the related ticket.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">Alternatively, it could be shortened to the one assertModule test that it actually performs on r.basin.fill (see also comments in the ticket).<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">Also skipped tests should remain visible in test reports e.g. on fatra BTW.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">Cheers<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">Stefan<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> grass-dev <grass-dev-bounces@lists.osgeo.org>
<b>On Behalf Of </b>Markus Neteler<br>
<b>Sent:</b> onsdag 24. april 2019 22:45<br>
<b>To:</b> GRASS developers list <grass-dev@lists.osgeo.org><br>
<b>Subject:</b> Re: [GRASS-dev] [GRASS-SVN] r74423 - grass/trunk/raster/r.basins.fill/testsuite<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB"><o:p> </o:p></span></p>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span lang="EN-GB">Hi Stefan,<o:p></o:p></span></p>
<div>
<div>
<p class="MsoNormal"><span lang="EN-GB"><</span><a href="mailto:svn_grass@osgeo.org"><span lang="EN-GB">svn_grass@osgeo.org</span></a><span lang="EN-GB">> schrieb am Mi., 24. Apr. 2019, 22:41:<o:p></o:p></span></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt">
<p class="MsoNormal"><span lang="EN-GB">Author: sbl<br>
Date: 2019-04-24 13:41:37 -0700 (Wed, 24 Apr 2019)<br>
New Revision: 74423<br>
<br>
Modified:<br>
grass/trunk/raster/r.basins.fill/testsuite/testrbf.py<br>
Log:<br>
deactivate erroneous test; see #3822<br>
<br>
Modified: grass/trunk/raster/r.basins.fill/testsuite/testrbf.py<br>
===================================================================<br>
--- grass/trunk/raster/r.basins.fill/testsuite/testrbf.py 2019-04-24 20:33:36 UTC (rev 74422)<br>
+++ grass/trunk/raster/r.basins.fill/testsuite/testrbf.py 2019-04-24 20:41:37 UTC (rev 74423)<br>
@@ -8,8 +8,10 @@<br>
License (>=v2). Read the file COPYING that comes with GRASS<br>
for details.<br>
"""<br>
+import unittest<br>
from grass.gunittest.case import TestCase<br>
<br>
</span><a href="mailto:+@unittest.skip(%22See"><span lang="EN-GB">+@unittest.skip("See</span></a><span lang="EN-GB"> #3822")<br>
class TestRasterbasin(TestCase):<br>
celevation='elevation'<br>
tgeology='geology'<o:p></o:p></span></p>
</blockquote>
</div>
</div>
<div>
<p class="MsoNormal"><span lang="EN-GB"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-GB"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-GB">Did you see the attachment?<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-GB">I'd prefer to fix the test rather than skip it (and forget)...<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-GB"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal">Markus<o:p></o:p></p>
</div>
</div>
</div>
</body>
</html>