[GRASS-QA] GRASS QA: markus |
./grass6/raster/r.le/r.le.patch/driver.c |no clones | 6
monsters | 1 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Wed Dec 13 10:02:43 EST 2006
Hello markus,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
raster/r.le/r.le.patch/driver.c functions
patch_fore (Begins at: 66 Ends at: 127)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 22 | | OK |
LOC: | 62 | | OK |
--------------+---------+-------+---------+
metrics are OK
open_files (Begins at: 135 Ends at: 416)
--------------+---------+-------+---------+
Complexity: | 31 | ** | Warning |
ParamNBR: | 0 | | OK |
CalledNBR: | 160 | *** | MONSTER |
LOC: | 282 | *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!
fopen0 (Begins at: 423 Ends at: 437)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
fopen1 (Begins at: 443 Ends at: 460)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
fopen2 (Begins at: 465 Ends at: 481)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
mv_driver (Begins at: 487 Ends at: 2186)
--------------+---------+-------+---------+
Complexity: | 347 | *** | MONSTER |
ParamNBR: | 0 | | OK |
CalledNBR: | 761 | *** | MONSTER |
LOC: | 1700 | *** | MONSTER |
--------------+---------+-------+---------+
3 metric are OUT OF RANGE!
set_colors (Begins at: 2188 Ends at: 2199)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 12 | | OK |
--------------+---------+-------+---------+
metrics are OK
read_mwind (Begins at: 2207 Ends at: 2235)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 12 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
meter (Begins at: 2243 Ends at: 2281)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 39 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_para (Begins at: 2286 Ends at: 2382)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 21 | | OK |
LOC: | 97 | | OK |
--------------+---------+-------+---------+
metrics are OK
free_para (Begins at: 2384 Ends at: 2412)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
read_para (Begins at: 2414 Ends at: 2483)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 70 | | OK |
--------------+---------+-------+---------+
metrics are OK
read_line (Begins at: 2491 Ends at: 2535)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 12 | | OK |
LOC: | 45 | | OK |
--------------+---------+-------+---------+
metrics are OK
unit_driver (Begins at: 2537 Ends at: 2666)
--------------+---------+-------+---------+
Complexity: | 22 | * | |
ParamNBR: | 0 | | OK |
CalledNBR: | 49 | * | |
LOC: | 130 | * | |
--------------+---------+-------+---------+
metrics are OK
run_clip (Begins at: 2668 Ends at: 2716)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 9 | *** | MONSTER |
CalledNBR: | 12 | | OK |
LOC: | 49 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
whole_reg_driver (Begins at: 2723 Ends at: 2797)
--------------+---------+-------+---------+
Complexity: | 14 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 75 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2006-12-13 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 86 |
LOC: 42 | 190 | 265 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list