[GRASS-QA] GRASS QA: hamish | ./grass6/imagery/i.vpoints/analyze.c |6 clones ( analyze.c analyze.c )| 0 monsters | 3 warnings

cvs at proxy.soccerlab.polymtl.ca cvs at proxy.soccerlab.polymtl.ca
Mon Jun 26 04:05:19 EDT 2006


Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


imagery/i.vpoints/analyze.c functions


do_1st (Begins at: 65 Ends at: 73)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

do_2nd (Begins at: 75 Ends at: 83)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

do_3rd (Begins at: 85 Ends at: 93)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

delete_mark (Begins at: 95 Ends at: 112)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

delete_control_point (Begins at: 114 Ends at: 140)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

do_warp (Begins at: 144 Ends at: 165)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

no_warp (Begins at: 167 Ends at: 170)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

warp (Begins at: 172 Ends at: 176)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

rast_redraw (Begins at: 178 Ends at: 183)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

uparrow (Begins at: 186 Ends at: 192)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

downarrow (Begins at: 194 Ends at: 200)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

pick (Begins at: 202 Ends at: 262)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      61 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

done (Begins at: 264 Ends at: 268)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

cancel_which (Begins at: 270 Ends at: 282)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

inbox (Begins at: 284 Ends at: 287)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

dotext (Begins at: 289 Ends at: 303)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       9 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

compute_transformation (Begins at: 305 Ends at: 379)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       8 |       |      OK |
LOC:          |      75 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

to_file (Begins at: 381 Ends at: 407)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      10 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

askfile (Begins at: 409 Ends at: 430)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      10 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

to_printer (Begins at: 432 Ends at: 443)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

do_report (Begins at: 445 Ends at: 489)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      20 |       |      OK |
LOC:          |      45 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

printcentered (Begins at: 491 Ends at: 508)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

show_point (Begins at: 510 Ends at: 521)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

get_order (Begins at: 523 Ends at: 541)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

analyze (Begins at: 543 Ends at: 778)
--------------+---------+-------+---------+
Complexity:   |      15 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      60 |    ** | Warning |
LOC:          |     236 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

Clone analysis:

This file has 6 potentially cloned functions:
  dotext  to_file  printcentered  askfile  delete_mark  do_report

In imagery/i.vpoints/analyze.c clones of  printcentered are:
	imagery/i.points/analyze.c  printcentered
	imagery/i.ortho.photo/photo.2target/analyze.c  printcentered
	imagery/i.ortho.photo/photo.2image/analyze.c  printcentered

In imagery/i.vpoints/analyze.c clones of  do_report are:
	imagery/i.points/analyze.c  do_report
	imagery/i.ortho.photo/photo.2image/analyze.c  do_report

In imagery/i.vpoints/analyze.c clones of  delete_mark are:
	lib/gis/color_org.c  G__organize_colors

In imagery/i.vpoints/analyze.c clones of  to_file are:
	imagery/i.points/analyze.c  to_file
	imagery/i.ortho.photo/photo.2target/analyze.c  to_file
	imagery/i.ortho.photo/photo.2image/analyze.c  to_file

In imagery/i.vpoints/analyze.c clones of  askfile are:
	imagery/i.points/analyze.c  askfile
	imagery/i.ortho.photo/photo.2target/analyze.c  askfile
	imagery/i.ortho.photo/photo.2image/analyze.c  askfile

In imagery/i.vpoints/analyze.c clones of  dotext are:
	imagery/i.points/analyze.c  dotext
	imagery/i.ortho.photo/photo.2image/use_camera.c  dotext
	imagery/i.ortho.photo/photo.2image/mark.c  dotext


__________________________________________

Threshold GRASS6 key metrics values at 2006-06-26 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list