[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/ask.c |2 clones (
main.c main.c ask.c )| 1 monsters | 1 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Fri Apr 13 20:44:01 EDT 2007
Hello glynn,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/ask.c functions
G_ask_new (Begins at: 130 Ends at: 134)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_ask_new_ext (Begins at: 136 Ends at: 158)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_ask_old (Begins at: 160 Ends at: 164)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_ask_old_ext (Begins at: 166 Ends at: 188)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_ask_any (Begins at: 190 Ends at: 194)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_ask_any_ext (Begins at: 196 Ends at: 218)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
G_ask_in_mapset (Begins at: 221 Ends at: 225)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_ask_in_mapset_ext (Begins at: 228 Ends at: 245)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 1 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_ask_new_file (Begins at: 248 Ends at: 280)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_ask_old_file (Begins at: 283 Ends at: 314)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_set_ask_return_msg (Begins at: 316 Ends at: 334)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_get_ask_return_msg (Begins at: 336 Ends at: 341)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
ask (Begins at: 343 Ends at: 592)
--------------+---------+-------+---------+
Complexity: | 46 | *** | MONSTER |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 68 | ** | Warning |
LOC: | 250 | ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
parselist (Begins at: 594 Ends at: 627)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 34 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
G_ask_old_ext G_ask_new_ext
In lib/gis/ask.c clones of G_ask_old_ext are:
lib/gis/ask.c G_ask_new_ext
In lib/gis/ask.c clones of G_ask_new_ext are:
lib/gis/ask.c G_ask_old_ext
__________________________________________
Threshold GRASS6 key metrics values at 2007-04-13 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list