[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/range.c |1 clones ( orig_wind.c get_row.c range.c )| 0 monsters | 0 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Sun Apr 15 23:22:20 EDT 2007



Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gis/range.c functions


G__remove_fp_range (Begins at: 93 Ends at: 108)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_construct_default_range (Begins at: 110 Ends at: 135)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_read_fp_range (Begins at: 137 Ends at: 227)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      18 |       |      OK |
LOC:          |      91 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_read_range (Begins at: 229 Ends at: 336)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      23 |       |      OK |
LOC:          |     108 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_write_range (Begins at: 338 Ends at: 384)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      12 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_write_fp_range (Begins at: 386 Ends at: 438)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      53 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_update_range (Begins at: 440 Ends at: 458)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_update_fp_range (Begins at: 462 Ends at: 495)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_row_update_range (Begins at: 497 Ends at: 502)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G__row_update_range (Begins at: 506 Ends at: 532)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_row_update_fp_range (Begins at: 536 Ends at: 590)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      55 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_init_range (Begins at: 592 Ends at: 619)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_get_range_min_max (Begins at: 621 Ends at: 657)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      37 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_init_fp_range (Begins at: 659 Ends at: 682)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_get_fp_range_min_max (Begins at: 684 Ends at: 707)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  G__remove_fp_range

In lib/gis/range.c clones of  G__remove_fp_range are:
	lib/gis/timestamp.c  G_remove_vector_timestamp


__________________________________________

Threshold GRASS6 key metrics values at 2007-04-15 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list