[GRASS-QA] GRASS QA: brad | ./grass6/gem/tools.c |no clones | 0
monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Wed Aug 29 05:58:04 EDT 2007
Hello brad,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
gem/tools.c functions
basename (Begins at: 32 Ends at: 64)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
mkdir_s (Begins at: 71 Ends at: 77)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 7 | | OK |
--------------+---------+-------+---------+
metrics are OK
chop (Begins at: 83 Ends at: 119)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 37 | | OK |
--------------+---------+-------+---------+
metrics are OK
insert_str (Begins at: 121 Ends at: 182)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 19 | | OK |
LOC: | 62 | | OK |
--------------+---------+-------+---------+
metrics are OK
delete_str (Begins at: 184 Ends at: 220)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 37 | | OK |
--------------+---------+-------+---------+
metrics are OK
find_pos (Begins at: 222 Ends at: 242)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
dump_str (Begins at: 249 Ends at: 257)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
get_package_name (Begins at: 263 Ends at: 291)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
nc_fgets (Begins at: 293 Ends at: 317)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
nc_fgets_html (Begins at: 323 Ends at: 448)
--------------+---------+-------+---------+
Complexity: | 22 | * | |
ParamNBR: | 3 | | OK |
CalledNBR: | 19 | | OK |
LOC: | 126 | * | |
--------------+---------+-------+---------+
metrics are OK
is_text (Begins at: 455 Ends at: 473)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
nc_fgets_nb (Begins at: 480 Ends at: 510)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
dump_ascii (Begins at: 517 Ends at: 532)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
dump_plain (Begins at: 539 Ends at: 565)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 12 | | OK |
LOC: | 27 | | OK |
--------------+---------+-------+---------+
metrics are OK
dump_html (Begins at: 572 Ends at: 607)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 17 | | OK |
LOC: | 36 | | OK |
--------------+---------+-------+---------+
metrics are OK
list_binaries (Begins at: 615 Ends at: 655)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 14 | | OK |
LOC: | 41 | | OK |
--------------+---------+-------+---------+
metrics are OK
binaries_exist (Begins at: 662 Ends at: 707)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 9 | | OK |
LOC: | 46 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_filetype (Begins at: 709 Ends at: 731)
--------------+---------+-------+---------+
Complexity: | 7 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
wget_extension (Begins at: 737 Ends at: 757)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 7 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
su (Begins at: 764 Ends at: 795)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
vercmp (Begins at: 797 Ends at: 821)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 6 | * | |
CalledNBR: | 0 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2007-08-29 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 88 |
LOC: 43 | 195 | 272 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list