[GRASS-QA] GRASS QA: soeren | ./grass6/lib/gpde/N_les_assemble.c |2 clones ( N_les_assemble.c )| 4 monsters | 5 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Mon Jun 4 17:48:12 EDT 2007



Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gpde/N_les_assemble.c functions


N_alloc_5star (Begins at: 44 Ends at: 58)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_alloc_7star (Begins at: 60 Ends at: 77)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_alloc_9star (Begins at: 79 Ends at: 96)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_alloc_27star (Begins at: 98 Ends at: 118)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_create_5star (Begins at: 120 Ends at: 153)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_create_7star (Begins at: 155 Ends at: 194)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |       2 |       |      OK |
LOC:          |      40 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

N_create_9star (Begins at: 196 Ends at: 257)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |       2 |       |      OK |
LOC:          |      62 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

N_create_27star (Begins at: 259 Ends at: 333)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |      28 |   *** | MONSTER |
CalledNBR:    |       4 |       |      OK |
LOC:          |      75 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

N_set_les_callback_3d_func (Begins at: 336 Ends at: 350)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_set_les_callback_2d_func (Begins at: 353 Ends at: 368)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_alloc_les_callback_3d (Begins at: 370 Ends at: 388)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_alloc_les_callback_2d (Begins at: 390 Ends at: 414)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_callback_template_3d (Begins at: 416 Ends at: 453)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |      38 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_callback_template_2d (Begins at: 455 Ends at: 483)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      29 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_assemble_les_2d (Begins at: 485 Ends at: 491)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_assemble_les_2d_active (Begins at: 499 Ends at: 505)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_assemble_les_2d_dirichlet (Begins at: 513 Ends at: 549)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      37 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_assemble_les_2d_param (Begins at: 551 Ends at: 769)
--------------+---------+-------+---------+
Complexity:   |      22 |     * |         |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      31 |       |      OK |
LOC:          |     219 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

N_les_integrate_dirichlet_2d (Begins at: 771 Ends at: 852)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      82 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

make_les_entry_2d (Begins at: 857 Ends at: 921)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |      13 |   *** | MONSTER |
CalledNBR:    |       8 |       |      OK |
LOC:          |      65 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

N_assemble_les_3d (Begins at: 923 Ends at: 929)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_assemble_les_3d_active (Begins at: 936 Ends at: 942)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_assemble_les_3d_dirichlet (Begins at: 949 Ends at: 983)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       1 |       |      OK |
LOC:          |      35 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_assemble_les_3d_param (Begins at: 985 Ends at: 1201)
--------------+---------+-------+---------+
Complexity:   |      19 |     * |         |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |      29 |       |      OK |
LOC:          |     217 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

N_les_integrate_dirichlet_3d (Begins at: 1203 Ends at: 1289)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      87 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

make_les_entry_3d (Begins at: 1294 Ends at: 1351)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |      15 |   *** | MONSTER |
CalledNBR:    |       8 |       |      OK |
LOC:          |      58 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

Clone analysis:

This file has 2 potentially cloned functions:
  N_alloc_9star  N_alloc_7star

In lib/gpde/N_les_assemble.c clones of  N_alloc_9star are:
	lib/gpde/N_les_assemble.c  N_alloc_7star
	lib/gpde/N_geom.c  N_alloc_geom_data

In lib/gpde/N_les_assemble.c clones of  N_alloc_7star are:
	lib/gpde/N_les_assemble.c  N_alloc_9star
	lib/gpde/N_geom.c  N_alloc_geom_data


__________________________________________

Threshold GRASS6 key metrics values at 2007-06-04 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list