[GRASS-QA] GRASS QA: martinl |datum.c | 7 clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Thu Sep 4 15:00:38 EDT 2008


Hello martinl,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/branches/develbranch_6/lib/proj/datum.c
*****************************************************************

          Function
free_datum_list(Begins at: 540, Ends at:554)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |      15 |       |           OK |        15 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


GPJ_ask_datum_params(Begins at: 240, Ends at:364)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      14 |    ** | BABY-MONSTER |        14 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      44 |   *** |      MONSTER |        44 |
LOC:          |     125 |    ** | BABY-MONSTER |       125 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


GPJ_free_datum(Begins at: 526, Ends at:532)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |       7 |       |           OK |         7 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


GPJ_get_datum_by_name(Begins at: 37, Ends at:58)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      22 |       |           OK |        22 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


GPJ_get_datum_params(Begins at: 136, Ends at:145)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      10 |       |           OK |        10 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


GPJ_get_datum_transform_by_name(Begins at: 378, Ends at:458)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      28 |    ** | BABY-MONSTER |        28 |
LOC:          |      81 |     * |      WARNING |        81 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metrics are OK


GPJ_get_default_datum_params_by_name(Begins at: 85, Ends at:111)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |      27 |       |           OK |        27 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


GPJ__get_datum_params(Begins at: 174, Ends at:216)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      20 |     * |      WARNING |        20 |
LOC:          |      43 |     * |      WARNING |        43 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


read_datum_table(Begins at: 470, Ends at:518)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      18 |     * |      WARNING |        18 |
LOC:          |      49 |     * |      WARNING |        49 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 7 potentially cloned functions:
  GPJ_get_datum_by_name  GPJ_get_datum_params  GPJ_get_datum_transform_by_name  GPJ_get_default_datum_params_by_name  GPJ__get_datum_params  read_datum_table

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/datum.c clones of free_datum_list are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/proj/datum.c  free_datum_list

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/datum.c clones of GPJ_get_datum_by_name are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/proj/datum.c  GPJ_get_datum_by_name

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/datum.c clones of GPJ_get_datum_params are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/proj/datum.c  GPJ_get_datum_params

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/datum.c clones of GPJ_get_datum_transform_by_name are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/proj/datum.c  GPJ_get_datum_transform_by_name

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/datum.c clones of GPJ_get_default_datum_params_by_name are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/proj/datum.c  GPJ_get_default_datum_params_by_name

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/datum.c clones of GPJ__get_datum_params are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/proj/datum.c  GPJ__get_datum_params

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/datum.c clones of read_datum_table are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/proj/datum.c  read_datum_table

____________________________________________


Threshold GRASS6 key metrics values at Thu Sep 04 15:12:49 EDT 2008 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
    SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 
    http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html 



More information about the grass-qa mailing list