From soccerlab.info at gmail.com Wed Jul 1 05:56:26 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 1 05:56:40 2009 Subject: [GRASS-QA] GRASS QA: martinl |fancy.c local_proto.h local_proto.h local_proto.h ...| no clones | 0 monsters |0 warnings Message-ID: <16402966.1211246441441613.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/display/d.title/fancy.c ***************************************************************** Function fancy(Begins at: 4, Ends at:19) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 11 | * | WARNING | 11 | LOC: | 16 | | OK | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/display/d.title/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.cca/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.gensig/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.his.rgb/globals.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1a.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1c.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1d.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1e.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1sa.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1sb.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1sc.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1sd.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1se.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1sf.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1sg.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1sh.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1si.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1sj.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09A1sk.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09Q1a.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09Q1b.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09Q1c.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09Q1d.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09Q1e.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod09Q1f.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod11A2a.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod11A2b.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod11A2c.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.modis.qc/mod11A2d.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.rgb.his/globals.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/imagery/i.smap/bouman.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/include/G3d.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/include/gis.h ***************************************************************** Class Categories(Begins at: 452, Ends at:476) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Cell_head(Begins at: 257, Ends at:279) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Cell_stats(Begins at: 492, Ends at:507) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Cell_stats_node(Begins at: 494, Ends at:500) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Colors(Begins at: 322, Ends at:340) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class FPRange(Begins at: 527, Ends at:532) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class FPReclass(Begins at: 377, Ends at:399) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class FPReclass_table(Begins at: 367, Ends at:373) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Flag(Begins at: 600, Ends at:608) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class GModule(Begins at: 610, Ends at:618) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class G_3dview(Begins at: 537, Ends at:562) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Histogram(Begins at: 509, Ends at:518) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Histogram_list(Begins at: 513, Ends at:517) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class History(Begins at: 478, Ends at:490) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Key_Value(Begins at: 564, Ends at:570) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Option(Begins at: 572, Ends at:598) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 1 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 1 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Quant(Begins at: 409, Ends at:450) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Quant_table(Begins at: 401, Ends at:407) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Range(Begins at: 520, Ends at:525) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Reclass(Begins at: 356, Ends at:365) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class TimeStamp(Begins at: 620, Ends at:624) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class _Color_Info_(Begins at: 295, Ends at:320) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class _Color_Rule_(Begins at: 281, Ends at:293) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/include/raster.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/include/rasterdefs.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/include/site.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/include/stats.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/raster/color_init.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/raster/color_insrt.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/raster/color_invrt.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/raster/color_range.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/raster/color_rule_get.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/raster/color_shift.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/raster/history.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/raster/interp.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/ps/ps.map/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/ps/ps.map/parse_list.c ***************************************************************** Function parse_val_list(Begins at: 24, Ends at:62) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 9 | | OK | 9 | LOC: | 39 | | OK | 39 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/ps/ps.map/ps_info.h ***************************************************************** Class PS_data(Begins at: 22, Ends at:72) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.carve/enforce.h ***************************************************************** Class parms(Begins at: 49, Ends at:55) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.cross/glob.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.describe/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.describe/tree.c ***************************************************************** Function add_node_to_tree(Begins at: 49, Ends at:114) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | * | WARNING | 9 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 7 | | OK | 7 | LOC: | 66 | * | WARNING | 66 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! first_cat(Begins at: 156, Ends at:162) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 7 | | OK | 7 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK first_node(Begins at: 122, Ends at:132) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 11 | | OK | 11 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK next_cat(Begins at: 164, Ends at:189) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | * | WARNING | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 1 | | OK | 1 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! next_node(Begins at: 134, Ends at:153) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 20 | | OK | 20 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK plant_tree(Begins at: 38, Ends at:47) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 10 | | OK | 10 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.distance/defs.h ***************************************************************** Class CatEdgeList(Begins at: 27, Ends at:33) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class EdgeList(Begins at: 25, Ends at:37) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Map(Begins at: 39, Ends at:46) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Parms(Begins at: 48, Ends at:54) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.distance/distance.c ***************************************************************** Function find_minimum_distance(Begins at: 27, Ends at:76) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | * | WARNING | 8 | ParamNBR: | 11 | *** | MONSTER | 11 | CalledNBR: | 8 | | OK | 8 | LOC: | 50 | * | WARNING | 50 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! null_distance(Begins at: 78, Ends at:166) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | ** | BABY-MONSTER | 14 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 27 | ** | BABY-MONSTER | 27 | LOC: | 89 | * | WARNING | 89 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.distance/edges.c ***************************************************************** Function add_edge_cell(Begins at: 95, Ends at:136) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | * | WARNING | 6 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 6 | | OK | 6 | LOC: | 42 | * | WARNING | 42 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! cmp(Begins at: 146, Ends at:151) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | | OK | 0 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK find_edge_cells(Begins at: 32, Ends at:93) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 23 | ** | BABY-MONSTER | 23 | LOC: | 62 | * | WARNING | 62 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! init_edge_list(Begins at: 138, Ends at:144) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 7 | | OK | 7 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK print_edge_info(Begins at: 22, Ends at:30) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | | OK | 3 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK sort_edge_list(Begins at: 153, Ends at:158) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.distance/report.c ***************************************************************** Function report(Begins at: 21, Ends at:79) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 22 | * | WARNING | 22 | LOC: | 59 | * | WARNING | 59 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.flow/r.flow.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.in.gridatb/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.in.poly/getformat.c ***************************************************************** Function getformat(Begins at: 4, Ends at:54) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | * | WARNING | 10 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | | OK | 3 | LOC: | 51 | * | WARNING | 51 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.info/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.kappa/kappa.h ***************************************************************** Class _gstats_(Begins at: 5, Ends at:9) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class _layer_(Begins at: 11, Ends at:16) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.li/r.li.daemon/daemon.h ***************************************************************** Class area_entry(Begins at: 107, Ends at:120) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class cell_memory_entry(Begins at: 51, Ends at:56) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class dcell_memory_entry(Begins at: 69, Ends at:74) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class fcell_memory_entry(Begins at: 87, Ends at:92) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.li/r.li.daemon/GenericCell.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.los/delete.c ***************************************************************** Function delete(Begins at: 24, Ends at:94) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | * | WARNING | 8 | ParamNBR: | 5 | * | WARNING | 5 | CalledNBR: | 5 | | OK | 5 | LOC: | 71 | * | WARNING | 71 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.los/mark_pts.c ***************************************************************** Function mark_visible_points(Begins at: 21, Ends at:47) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 6 | ** | BABY-MONSTER | 6 | CalledNBR: | 2 | | OK | 2 | LOC: | 27 | | OK | 27 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.mapcalc/mapcalc.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.mapcalc/xrand.c ***************************************************************** Function f_rand(Begins at: 19, Ends at:95) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | ** | BABY-MONSTER | 14 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 3 | | OK | 3 | LOC: | 77 | * | WARNING | 77 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.mapcalc/xrowcol.c ***************************************************************** Function f_col(Begins at: 13, Ends at:28) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 0 | | OK | 0 | LOC: | 16 | | OK | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! f_depth(Begins at: 48, Ends at:64) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 0 | | OK | 0 | LOC: | 17 | | OK | 17 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! f_row(Begins at: 30, Ends at:46) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 0 | | OK | 0 | LOC: | 17 | | OK | 17 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.mfilter/filter.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.neighbors/ncb.h ***************************************************************** Class ncb(Begins at: 2, Ends at:15) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.out.gridatb/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.param.scale/param.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.profile/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.quant/global.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.random/local_proto.h ***************************************************************** Class RASTER_MAP_PTR(Begins at: 13, Ends at:17) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class RASTER_PTR(Begins at: 5, Ends at:11) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class rr_state(Begins at: 24, Ends at:32) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.random.cells/ransurf.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.random.surface/ransurf.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.reclass/rule.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.recode/global.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.report/global.h ***************************************************************** Class _gstats_(Begins at: 25, Ends at:30) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class _layer_(Begins at: 13, Ends at:20) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class _units_(Begins at: 36, Ends at:44) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.report/main.c ***************************************************************** Function main(Begins at: 57, Ends at:76) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 9 | | OK | 9 | LOC: | 20 | | OK | 20 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.report/parse.c ***************************************************************** Function match(Begins at: 270, Ends at:278) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 2 | | OK | 2 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! parse_command_line(Begins at: 6, Ends at:196) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 15 | ** | BABY-MONSTER | 15 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 56 | *** | MONSTER | 56 | LOC: | 191 | *** | MONSTER | 191 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! parse_layer(Begins at: 232, Ends at:268) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | * | WARNING | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 21 | * | WARNING | 21 | LOC: | 37 | | OK | 37 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! parse_units(Begins at: 198, Ends at:230) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | * | WARNING | 10 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 10 | * | WARNING | 10 | LOC: | 33 | | OK | 33 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.report/stats.c ***************************************************************** Function die(Begins at: 95, Ends at:100) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | | OK | 3 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK get_stats(Begins at: 8, Ends at:93) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 23 | *** | MONSTER | 23 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 39 | *** | MONSTER | 39 | LOC: | 86 | * | WARNING | 86 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.ros/spot_dist.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.spread/select_linksB.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.spread/spot.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.spread/spread.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.surf.contour/contour.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.surf.idw/main.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.thin/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.water.outlet/basin.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster/r.watershed/seg/cseg.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/raster3d/base/mask_functions.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/vector/lidar/v.lidar.edgedetection/edgedetection.c ***************************************************************** Function Create_AuxEdge_Table(Begins at: 507, Ends at:542) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | *** | MONSTER | 2 | ParamNBR: | 1 | *** | MONSTER | 1 | CalledNBR: | 18 | *** | MONSTER | 18 | LOC: | 36 | *** | MONSTER | 36 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Create_Interpolation_Table(Begins at: 556, Ends at:584) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 14 | * | WARNING | 14 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Drop_Aux_Table(Begins at: 544, Ends at:553) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | * | WARNING | 4 | LOC: | 10 | | OK | 10 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Get_Gradient(Begins at: 146, Ends at:169) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 4 | | OK | 4 | CalledNBR: | 2 | | OK | 2 | LOC: | 24 | | OK | 24 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Insert(Begins at: 401, Ends at:417) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 5 | * | WARNING | 5 | CalledNBR: | 6 | | OK | 6 | LOC: | 17 | | OK | 17 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Insert_Interpolation(Begins at: 419, Ends at:433) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 6 | | OK | 6 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Select(Begins at: 452, Ends at:504) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | | OK | 6 | ParamNBR: | 5 | * | WARNING | 5 | CalledNBR: | 22 | | OK | 22 | LOC: | 53 | | OK | 53 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! UpDate(Begins at: 436, Ends at:450) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | * | WARNING | 1 | ParamNBR: | 5 | * | WARNING | 5 | CalledNBR: | 4 | * | WARNING | 4 | LOC: | 15 | * | WARNING | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! classification(Begins at: 171, Ends at:399) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 25 | | OK | 25 | ParamNBR: | 16 | * | WARNING | 16 | CalledNBR: | 58 | | OK | 58 | LOC: | 229 | | OK | 229 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! edge_detection(Begins at: 34, Ends at:144) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | * | WARNING | 8 | ParamNBR: | 10 | *** | MONSTER | 10 | CalledNBR: | 32 | ** | BABY-MONSTER | 32 | LOC: | 111 | ** | BABY-MONSTER | 111 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/vector/v.to.rast/local.h ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 01 05:44:01 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 1 07:49:57 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 1 07:50:06 2009 Subject: [GRASS-QA] GRASS QA: martinl |display.h imagery.h raster.h interpf.h | no clones | 0 monsters |0 warnings Message-ID: <1431230.1221246448251233.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/include/display.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/include/imagery.h ***************************************************************** Class ClassData(Begins at: 84, Ends at:90) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class ClassSig(Begins at: 67, Ends at:91) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Control_Points(Begins at: 35, Ends at:43) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class One_Sig(Begins at: 50, Ends at:59) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Ref(Begins at: 9, Ends at:26) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Ref_Color(Begins at: 17, Ends at:25) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Ref_Files(Begins at: 12, Ends at:16) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class SigSet(Begins at: 62, Ends at:92) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Signature(Begins at: 45, Ends at:60) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class SubSig(Begins at: 74, Ends at:83) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Tape_Info(Begins at: 28, Ends at:33) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/include/raster.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/rst/interp_float/interpf.h ***************************************************************** Class fcell_triple(Begins at: 12, Ends at:18) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class interp_params(Begins at: 38, Ends at:72) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 7 | 0 | 21 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 7 | 0 | 21 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Wed Jul 01 07:37:31 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 1 07:59:37 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 1 07:59:45 2009 Subject: [GRASS-QA] GRASS QA: hamish |local_proto.h main.c printwindow.c | no clones | 0 monsters |0 warnings Message-ID: <32036656.1231246448830743.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello hamish, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/branches/develbranch_6/general/g.region/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/branches/develbranch_6/general/g.region/main.c ***************************************************************** Function die(Begins at: 844, Ends at:850) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 7 | | OK | 7 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK llinfo(Begins at: 863, Ends at:872) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 3 | | OK | 3 | LOC: | 10 | | OK | 10 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! main(Begins at: 29, Ends at:842) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 120 | *** | MONSTER | 120 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 258 | *** | MONSTER | 258 | LOC: | 814 | *** | MONSTER | 814 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! nsew(Begins at: 852, Ends at:861) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 6 | | OK | 6 | LOC: | 10 | | OK | 10 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/branches/develbranch_6/general/g.region/printwindow.c ***************************************************************** Function print_window(Begins at: 8, Ends at:673) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 71 | *** | MONSTER | 71 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 232 | *** | MONSTER | 232 | LOC: | 666 | *** | MONSTER | 666 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Wed Jul 01 07:47:10 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 1 08:01:41 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 1 08:01:48 2009 Subject: [GRASS-QA] GRASS QA: hamish |local_proto.h main.c printwindow.c | no clones | 0 monsters |0 warnings Message-ID: <26318895.1241246448954308.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello hamish, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/general/g.region/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/general/g.region/main.c ***************************************************************** Function die(Begins at: 826, Ends at:832) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 7 | | OK | 7 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK llinfo(Begins at: 845, Ends at:854) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 3 | | OK | 3 | LOC: | 10 | | OK | 10 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! main(Begins at: 29, Ends at:824) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 120 | *** | MONSTER | 120 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 259 | *** | MONSTER | 259 | LOC: | 796 | *** | MONSTER | 796 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! nsew(Begins at: 834, Ends at:843) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 6 | | OK | 6 | LOC: | 10 | | OK | 10 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/general/g.region/printwindow.c ***************************************************************** Function print_window(Begins at: 8, Ends at:653) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 71 | *** | MONSTER | 71 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 232 | *** | MONSTER | 232 | LOC: | 646 | *** | MONSTER | 646 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Wed Jul 01 07:49:14 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 1 13:14:16 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 1 13:14:25 2009 Subject: [GRASS-QA] GRASS QA: martinl |colors.h | no clones | 0 monsters |0 warnings Message-ID: <2842857.1251246467704415.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/include/colors.h ***************************************************************** Class color_name(Begins at: 38, Ends at:42) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class color_rgb(Begins at: 33, Ends at:36) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Wed Jul 01 13:01:44 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 10:45:59 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 10:46:11 2009 Subject: [GRASS-QA] GRASS QA: hamish |rsunlib.c | no clones | 0 monsters |0 warnings Message-ID: <33482373.01247063438837.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello hamish, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/branches/develbranch_6/raster/r.sun2/rsunlib.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 08 10:30:38 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 10:53:17 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 10:54:11 2009 Subject: [GRASS-QA] GRASS QA: hamish |main.c | no clones | 0 monsters |0 warnings Message-ID: <5468896.11247063875887.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello hamish, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/branches/develbranch_6/raster/r.sun2/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 08 10:37:55 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 11:00:30 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 11:00:39 2009 Subject: [GRASS-QA] GRASS QA: hamish |main.c | no clones | 0 monsters |0 warnings Message-ID: <9532848.21247064309460.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello hamish, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/branches/releasebranch_6_4/raster/r.sun2/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 08 10:45:09 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 11:07:47 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 11:07:55 2009 Subject: [GRASS-QA] GRASS QA: hamish |rsunlib.c | no clones | 0 monsters |0 warnings Message-ID: <17306481.31247064745927.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello hamish, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/raster/r.sun2/rsunlib.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 08 10:52:25 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 11:15:06 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 11:15:10 2009 Subject: [GRASS-QA] GRASS QA: hamish |main.c | no clones | 0 monsters |0 warnings Message-ID: <15155478.41247065184701.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello hamish, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/raster/r.sun2/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 08 10:59:44 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 11:22:44 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 11:22:52 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c | 2 clones | 0 monsters |0 warnings Message-ID: <4917273.51247065642928.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/db/db.connect/main.c ***************************************************************** Function main(Begins at: 30, Ends at:174) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | * | WARNING | 12 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 39 | *** | MONSTER | 39 | LOC: | 145 | *** | MONSTER | 145 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file has 2 potentially cloned functions: main In /var/project-manager/grass/grassSVN/grass/trunk/db/db.connect/main.c clones of main are: /var/project-manager/grass/grassSVN/grass/trunk/db/base/connect.c main /var/project-manager/grass/grassSVN/grass/trunk/db/db.connect/connect.c main ____________________________________________ Threshold grass key metrics values at Wed Jul 08 11:07:22 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 11:30:08 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 11:30:16 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c | 4 clones | 0 monsters |0 warnings Message-ID: <6622692.61247066086876.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/db/db.execute/main.c ***************************************************************** Function get_stmt(Begins at: 136, Ends at:163) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 7 | | OK | 7 | LOC: | 28 | | OK | 28 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK main(Begins at: 37, Ends at:91) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | * | WARNING | 9 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 25 | ** | BABY-MONSTER | 25 | LOC: | 55 | * | WARNING | 55 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! parse_command_line(Begins at: 94, Ends at:133) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 15 | * | WARNING | 15 | LOC: | 40 | | OK | 40 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! stmt_is_empty(Begins at: 166, Ends at:171) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file has 4 potentially cloned functions: main parse_command_line parse_command_line In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/main.c clones of main are: /var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c main /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c main In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/main.c clones of parse_command_line are: /var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c parse_command_line /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c parse_command_line ____________________________________________ Threshold grass key metrics values at Wed Jul 08 11:14:46 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 11:37:42 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 11:37:50 2009 Subject: [GRASS-QA] GRASS QA: martinl |execute.c | no clones | 0 monsters |0 warnings Message-ID: <18283153.71247066540722.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/branches/develbranch_6/db/base/execute.c ***************************************************************** Function get_stmt(Begins at: 136, Ends at:168) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 12 | * | WARNING | 12 | LOC: | 33 | | OK | 33 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! main(Begins at: 37, Ends at:91) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | * | WARNING | 9 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 25 | ** | BABY-MONSTER | 25 | LOC: | 55 | * | WARNING | 55 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! parse_command_line(Begins at: 94, Ends at:133) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 15 | * | WARNING | 15 | LOC: | 40 | | OK | 40 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! stmt_is_empty(Begins at: 171, Ends at:176) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Wed Jul 08 11:22:20 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 11:44:52 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 11:45:00 2009 Subject: [GRASS-QA] GRASS QA: martinl |execute.c | no clones | 0 monsters |0 warnings Message-ID: <16405215.81247066970251.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/branches/releasebranch_6_4/db/base/execute.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 08 11:29:30 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 11:52:18 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 11:52:27 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c main.c gis.h parser.c | 8 clones | 0 monsters |0 warnings Message-ID: <5329145.91247067415904.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/db/db.connect/main.c ***************************************************************** Function main(Begins at: 30, Ends at:174) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | * | WARNING | 12 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 39 | *** | MONSTER | 39 | LOC: | 145 | *** | MONSTER | 145 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file has 2 potentially cloned functions: main In /var/project-manager/grass/grassSVN/grass/trunk/db/db.connect/main.c clones of main are: /var/project-manager/grass/grassSVN/grass/trunk/db/base/connect.c main /var/project-manager/grass/grassSVN/grass/trunk/db/db.connect/connect.c main ***************************************************************** File :grass/trunk/db/db.execute/main.c ***************************************************************** Function get_stmt(Begins at: 136, Ends at:163) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 7 | | OK | 7 | LOC: | 28 | | OK | 28 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK main(Begins at: 37, Ends at:91) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | * | WARNING | 9 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 25 | ** | BABY-MONSTER | 25 | LOC: | 55 | * | WARNING | 55 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! parse_command_line(Begins at: 94, Ends at:133) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 15 | * | WARNING | 15 | LOC: | 40 | | OK | 40 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! stmt_is_empty(Begins at: 166, Ends at:171) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file has 4 potentially cloned functions: main parse_command_line parse_command_line In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/main.c clones of main are: /var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c main /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c main In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/main.c clones of parse_command_line are: /var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c parse_command_line /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c parse_command_line ***************************************************************** File :grass/trunk/include/gis.h ***************************************************************** Class Categories(Begins at: 452, Ends at:476) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Cell_head(Begins at: 257, Ends at:279) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Cell_stats(Begins at: 492, Ends at:507) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Cell_stats_node(Begins at: 494, Ends at:500) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Colors(Begins at: 322, Ends at:340) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class FPRange(Begins at: 527, Ends at:532) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class FPReclass(Begins at: 377, Ends at:399) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class FPReclass_table(Begins at: 367, Ends at:373) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Flag(Begins at: 600, Ends at:608) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class GModule(Begins at: 610, Ends at:618) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class G_3dview(Begins at: 537, Ends at:562) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Histogram(Begins at: 509, Ends at:518) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Histogram_list(Begins at: 513, Ends at:517) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class History(Begins at: 478, Ends at:490) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Key_Value(Begins at: 564, Ends at:570) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Option(Begins at: 572, Ends at:598) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 1 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 1 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Quant(Begins at: 409, Ends at:450) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Quant_table(Begins at: 401, Ends at:407) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Range(Begins at: 520, Ends at:525) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Reclass(Begins at: 356, Ends at:365) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class TimeStamp(Begins at: 620, Ends at:624) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class _Color_Info_(Begins at: 295, Ends at:320) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class _Color_Rule_(Begins at: 281, Ends at:293) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/gis/parser.c ***************************************************************** Class Item(Begins at: 109, Ends at:114) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Function G_define_flag(Begins at: 176, Ends at:213) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | * | WARNING | 1 | CalledNBR: | 4 | * | WARNING | 4 | LOC: | 38 | * | WARNING | 38 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! G_define_module(Begins at: 649, Ends at:662) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | ** | BABY-MONSTER | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 14 | | OK | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_define_option(Begins at: 232, Ends at:283) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | ** | BABY-MONSTER | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | | OK | 4 | LOC: | 52 | | OK | 52 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_define_standard_option(Begins at: 312, Ends at:640) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 38 | * | WARNING | 38 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 43 | | OK | 43 | LOC: | 329 | | OK | 329 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_disable_interactive(Begins at: 155, Ends at:160) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | * | WARNING | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_gui(Begins at: 1973, Ends at:1988) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | * | WARNING | 5 | LOC: | 16 | * | WARNING | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! G_gui_tcltk(Begins at: 1918, Ends at:1947) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | | OK | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 12 | | OK | 12 | LOC: | 30 | | OK | 30 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_gui_wx(Begins at: 1952, Ends at:1964) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 6 | | OK | 6 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_parser(Begins at: 701, Ends at:955) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 41 | | OK | 41 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 83 | | OK | 83 | LOC: | 255 | | OK | 255 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_recreate_command(Begins at: 2600, Ends at:2699) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | * | WARNING | 14 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 26 | ** | BABY-MONSTER | 26 | LOC: | 100 | ** | BABY-MONSTER | 100 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_script(Begins at: 1696, Ends at:1808) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 24 | * | WARNING | 24 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 46 | * | WARNING | 46 | LOC: | 113 | * | WARNING | 113 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! G_tcltk(Begins at: 1993, Ends at:2001) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_usage(Begins at: 1008, Ends at:1179) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 34 | | OK | 34 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 53 | | OK | 53 | LOC: | 172 | | OK | 172 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_usage_html(Begins at: 1472, Ends at:1691) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 42 | | OK | 42 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 85 | | OK | 85 | LOC: | 220 | * | WARNING | 220 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_usage_xml(Begins at: 1234, Ends at:1467) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 31 | *** | MONSTER | 31 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 87 | *** | MONSTER | 87 | LOC: | 234 | *** | MONSTER | 234 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_an_opt(Begins at: 2201, Ends at:2243) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | | OK | 10 | ParamNBR: | 4 | | OK | 4 | CalledNBR: | 13 | | OK | 13 | LOC: | 43 | | OK | 43 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_double(Begins at: 2309, Ends at:2345) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | | OK | 14 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 37 | | OK | 37 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_int(Begins at: 2245, Ends at:2281) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | * | WARNING | 14 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | * | WARNING | 6 | LOC: | 37 | | OK | 37 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! check_multiple_opts(Begins at: 2457, Ends at:2492) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | | OK | 8 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | | OK | 5 | LOC: | 36 | | OK | 36 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_opts(Begins at: 2165, Ends at:2199) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | *** | MONSTER | 7 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | *** | MONSTER | 3 | LOC: | 35 | *** | MONSTER | 35 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_overwrite(Begins at: 2495, Ends at:2560) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | ** | BABY-MONSTER | 12 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 16 | ** | BABY-MONSTER | 16 | LOC: | 66 | ** | BABY-MONSTER | 66 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_required(Begins at: 2373, Ends at:2395) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | *** | MONSTER | 2 | LOC: | 23 | ** | BABY-MONSTER | 23 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_string(Begins at: 2347, Ends at:2371) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | | OK | 9 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 25 | | OK | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK contains(Begins at: 2083, Ends at:2091) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | *** | MONSTER | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | *** | MONSTER | 0 | LOC: | 9 | *** | MONSTER | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! generate_tcl(Begins at: 1815, Ends at:1913) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | *** | MONSTER | 12 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 34 | *** | MONSTER | 34 | LOC: | 99 | *** | MONSTER | 99 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! is_option(Begins at: 2093, Ends at:2106) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | *** | MONSTER | 2 | LOC: | 14 | *** | MONSTER | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! print_escaped_for_html(Begins at: 1213, Ends at:1227) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | * | WARNING | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | | OK | 5 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! print_escaped_for_xml(Begins at: 1189, Ends at:1206) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | | OK | 7 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 4 | | OK | 4 | LOC: | 18 | | OK | 18 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK set_flag(Begins at: 2054, Ends at:2078) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | *** | MONSTER | 4 | LOC: | 25 | ** | BABY-MONSTER | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! set_option(Begins at: 2108, Ends at:2163) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | | OK | 8 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 13 | | OK | 13 | LOC: | 56 | | OK | 56 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK show(Begins at: 2040, Ends at:2052) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 3 | | OK | 3 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK show_options(Begins at: 2010, Ends at:2038) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | * | WARNING | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 11 | | OK | 11 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! split_gisprompt(Begins at: 2562, Ends at:2590) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | | OK | 7 | ParamNBR: | 4 | | OK | 4 | CalledNBR: | 0 | | OK | 0 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK split_opts(Begins at: 2397, Ends at:2455) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | * | WARNING | 10 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 6 | * | WARNING | 6 | LOC: | 59 | * | WARNING | 59 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! uses_new_gisprompt(Begins at: 958, Ends at:983) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | | OK | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file has 2 potentially cloned functions: check_double In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c clones of check_double are: /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c check_int In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c clones of check_int are: /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c check_double ____________________________________________ Threshold grass key metrics values at Wed Jul 08 11:36:55 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 11:59:52 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 11:59:58 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c | 4 clones | 0 monsters |0 warnings Message-ID: <21248743.101247067869654.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/db/db.execute/main.c ***************************************************************** Function get_stmt(Begins at: 136, Ends at:163) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 7 | | OK | 7 | LOC: | 28 | | OK | 28 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK main(Begins at: 37, Ends at:91) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | * | WARNING | 9 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 25 | ** | BABY-MONSTER | 25 | LOC: | 55 | * | WARNING | 55 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! parse_command_line(Begins at: 94, Ends at:133) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 15 | * | WARNING | 15 | LOC: | 40 | | OK | 40 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! stmt_is_empty(Begins at: 166, Ends at:171) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file has 4 potentially cloned functions: main parse_command_line parse_command_line In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/main.c clones of main are: /var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c main /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c main In /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/main.c clones of parse_command_line are: /var/project-manager/grass/grassSVN/grass/trunk/db/base/execute.c parse_command_line /var/project-manager/grass/grassSVN/grass/trunk/db/db.execute/execute.c parse_command_line ____________________________________________ Threshold grass key metrics values at Wed Jul 08 11:44:29 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 12:07:29 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 12:07:38 2009 Subject: [GRASS-QA] GRASS QA: martinl |args.c | no clones | 0 monsters |0 warnings Message-ID: <25686002.111247068327435.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/vector/v.select/args.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 08 11:52:07 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 12:14:54 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 12:15:05 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c | no clones | 0 monsters |0 warnings Message-ID: <28155930.121247068771610.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/vector/v.select/main.c ***************************************************************** Function add_aarea(Begins at: 27, Ends at:55) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 8 | | OK | 8 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! line_overlap_area(Begins at: 59, Ends at:105) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 14 | * | WARNING | 14 | LOC: | 47 | * | WARNING | 47 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! main(Begins at: 107, Ends at:518) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 52 | *** | MONSTER | 52 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 121 | *** | MONSTER | 121 | LOC: | 412 | *** | MONSTER | 412 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Wed Jul 08 11:59:31 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 12:22:04 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 12:22:10 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c | no clones | 0 monsters |0 warnings Message-ID: <20582140.131247069201538.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/branches/develbranch_6/vector/v.select/main.c ***************************************************************** Function add_aarea(Begins at: 27, Ends at:55) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 8 | | OK | 8 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! line_overlap_area(Begins at: 59, Ends at:105) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 14 | * | WARNING | 14 | LOC: | 47 | * | WARNING | 47 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! main(Begins at: 107, Ends at:518) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 52 | *** | MONSTER | 52 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 121 | *** | MONSTER | 121 | LOC: | 412 | *** | MONSTER | 412 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Wed Jul 08 12:06:41 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 12:29:39 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 12:29:46 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c | no clones | 0 monsters |0 warnings Message-ID: <19280503.141247069656386.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass-addons/grass7/imagery/i.landsat.toar/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 08 12:14:16 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 12:37:23 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 12:37:31 2009 Subject: [GRASS-QA] GRASS QA: dano |centrality.c flow.c neta.h path.c ...| no clones | 0 monsters |0 warnings Message-ID: <28715121.151247070120057.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello dano, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass-addons/vector/net.analyze/netalib/centrality.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/net.analyze/netalib/flow.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/net.analyze/netalib/neta.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/net.analyze/netalib/path.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/net.analyze/netalib/utils.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/net.analyze/v.net.allpairs/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/net.analyze/v.net.centrality/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/net.analyze/v.net.connectivity/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/net.analyze/v.net.distance/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/net.analyze/v.net.flow/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 08 12:21:59 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 12:44:39 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 12:44:47 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c trans2.c trans3.c | no clones | 0 monsters |0 warnings Message-ID: <4779954.161247070556802.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/vector/v.to.3d/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/vector/v.to.3d/trans2.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/vector/v.to.3d/trans3.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 08 12:29:16 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 12:52:00 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 12:52:08 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c trans2.c trans3.c | no clones | 0 monsters |0 warnings Message-ID: <6511942.171247070997837.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/branches/develbranch_6/vector/v.to.3d/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/branches/develbranch_6/vector/v.to.3d/trans2.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/branches/develbranch_6/vector/v.to.3d/trans3.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 08 12:36:37 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Wed Jul 8 12:59:13 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Wed Jul 8 12:59:21 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c trans2.c trans3.c | no clones | 0 monsters |0 warnings Message-ID: <1120036.181247071430745.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/branches/releasebranch_6_4/vector/v.to.3d/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/branches/releasebranch_6_4/vector/v.to.3d/trans2.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/branches/releasebranch_6_4/vector/v.to.3d/trans3.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Wed Jul 08 12:43:50 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Fri Jul 10 10:07:56 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Fri Jul 10 10:08:09 2009 Subject: [GRASS-QA] GRASS QA: martinl |gis.h parser.c main.c | 2 clones | 0 monsters |0 warnings Message-ID: <30132298.191247233910857.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/include/gis.h ***************************************************************** Class Categories(Begins at: 452, Ends at:476) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Cell_head(Begins at: 257, Ends at:279) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Cell_stats(Begins at: 492, Ends at:507) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Cell_stats_node(Begins at: 494, Ends at:500) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Colors(Begins at: 322, Ends at:340) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class FPRange(Begins at: 527, Ends at:532) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class FPReclass(Begins at: 377, Ends at:399) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class FPReclass_table(Begins at: 367, Ends at:373) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Flag(Begins at: 600, Ends at:608) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class GModule(Begins at: 610, Ends at:618) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class G_3dview(Begins at: 537, Ends at:562) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Histogram(Begins at: 509, Ends at:518) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Histogram_list(Begins at: 513, Ends at:517) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class History(Begins at: 478, Ends at:490) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Key_Value(Begins at: 564, Ends at:570) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Option(Begins at: 572, Ends at:598) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 1 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 1 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Quant(Begins at: 409, Ends at:450) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Quant_table(Begins at: 401, Ends at:407) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Range(Begins at: 520, Ends at:525) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Reclass(Begins at: 356, Ends at:365) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class TimeStamp(Begins at: 620, Ends at:624) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class _Color_Info_(Begins at: 295, Ends at:320) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class _Color_Rule_(Begins at: 281, Ends at:293) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/gis/parser.c ***************************************************************** Class Item(Begins at: 109, Ends at:114) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Function G_define_flag(Begins at: 176, Ends at:213) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | * | WARNING | 1 | CalledNBR: | 4 | * | WARNING | 4 | LOC: | 38 | * | WARNING | 38 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! G_define_module(Begins at: 649, Ends at:662) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | ** | BABY-MONSTER | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 14 | | OK | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_define_option(Begins at: 232, Ends at:283) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | ** | BABY-MONSTER | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | | OK | 4 | LOC: | 52 | | OK | 52 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_define_standard_option(Begins at: 312, Ends at:640) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 38 | * | WARNING | 38 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 43 | | OK | 43 | LOC: | 329 | | OK | 329 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_disable_interactive(Begins at: 155, Ends at:160) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | * | WARNING | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_gui(Begins at: 1973, Ends at:1988) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | * | WARNING | 5 | LOC: | 16 | * | WARNING | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! G_gui_tcltk(Begins at: 1918, Ends at:1947) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | | OK | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 12 | | OK | 12 | LOC: | 30 | | OK | 30 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_gui_wx(Begins at: 1952, Ends at:1964) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 6 | | OK | 6 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_parser(Begins at: 701, Ends at:955) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 41 | | OK | 41 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 83 | | OK | 83 | LOC: | 255 | | OK | 255 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_recreate_command(Begins at: 2600, Ends at:2699) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | * | WARNING | 14 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 26 | ** | BABY-MONSTER | 26 | LOC: | 100 | ** | BABY-MONSTER | 100 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_script(Begins at: 1696, Ends at:1808) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 24 | * | WARNING | 24 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 46 | * | WARNING | 46 | LOC: | 113 | * | WARNING | 113 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! G_tcltk(Begins at: 1993, Ends at:2001) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_usage(Begins at: 1008, Ends at:1179) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 34 | | OK | 34 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 53 | | OK | 53 | LOC: | 172 | | OK | 172 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_usage_html(Begins at: 1472, Ends at:1691) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 42 | | OK | 42 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 85 | | OK | 85 | LOC: | 220 | * | WARNING | 220 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_usage_xml(Begins at: 1234, Ends at:1467) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 31 | *** | MONSTER | 31 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 87 | *** | MONSTER | 87 | LOC: | 234 | *** | MONSTER | 234 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_an_opt(Begins at: 2201, Ends at:2243) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | | OK | 10 | ParamNBR: | 4 | | OK | 4 | CalledNBR: | 13 | | OK | 13 | LOC: | 43 | | OK | 43 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_double(Begins at: 2309, Ends at:2345) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | | OK | 14 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 37 | | OK | 37 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_int(Begins at: 2245, Ends at:2281) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | * | WARNING | 14 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | * | WARNING | 6 | LOC: | 37 | | OK | 37 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! check_multiple_opts(Begins at: 2457, Ends at:2492) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | | OK | 8 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | | OK | 5 | LOC: | 36 | | OK | 36 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_opts(Begins at: 2165, Ends at:2199) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | *** | MONSTER | 7 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | *** | MONSTER | 3 | LOC: | 35 | *** | MONSTER | 35 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_overwrite(Begins at: 2495, Ends at:2560) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | ** | BABY-MONSTER | 12 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 16 | ** | BABY-MONSTER | 16 | LOC: | 66 | ** | BABY-MONSTER | 66 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_required(Begins at: 2373, Ends at:2395) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | *** | MONSTER | 2 | LOC: | 23 | ** | BABY-MONSTER | 23 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_string(Begins at: 2347, Ends at:2371) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | | OK | 9 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 25 | | OK | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK contains(Begins at: 2083, Ends at:2091) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | *** | MONSTER | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | *** | MONSTER | 0 | LOC: | 9 | *** | MONSTER | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! generate_tcl(Begins at: 1815, Ends at:1913) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | *** | MONSTER | 12 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 34 | *** | MONSTER | 34 | LOC: | 99 | *** | MONSTER | 99 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! is_option(Begins at: 2093, Ends at:2106) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | *** | MONSTER | 2 | LOC: | 14 | *** | MONSTER | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! print_escaped_for_html(Begins at: 1213, Ends at:1227) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | * | WARNING | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | | OK | 5 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! print_escaped_for_xml(Begins at: 1189, Ends at:1206) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | | OK | 7 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 4 | | OK | 4 | LOC: | 18 | | OK | 18 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK set_flag(Begins at: 2054, Ends at:2078) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | *** | MONSTER | 4 | LOC: | 25 | ** | BABY-MONSTER | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! set_option(Begins at: 2108, Ends at:2163) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | | OK | 8 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 13 | | OK | 13 | LOC: | 56 | | OK | 56 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK show(Begins at: 2040, Ends at:2052) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 3 | | OK | 3 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK show_options(Begins at: 2010, Ends at:2038) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | * | WARNING | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 11 | | OK | 11 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! split_gisprompt(Begins at: 2562, Ends at:2590) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | | OK | 7 | ParamNBR: | 4 | | OK | 4 | CalledNBR: | 0 | | OK | 0 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK split_opts(Begins at: 2397, Ends at:2455) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | * | WARNING | 10 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 6 | * | WARNING | 6 | LOC: | 59 | * | WARNING | 59 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! uses_new_gisprompt(Begins at: 958, Ends at:983) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | | OK | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file has 2 potentially cloned functions: check_double In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c clones of check_double are: /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c check_int In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c clones of check_int are: /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c check_double ***************************************************************** File :grass/trunk/vector/v.distance/main.c ***************************************************************** Function cmp_exist(Begins at: 1189, Ends at:1199) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | | OK | 0 | LOC: | 11 | | OK | 11 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK cmp_near(Begins at: 1156, Ends at:1166) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | | OK | 0 | LOC: | 11 | | OK | 11 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK cmp_near_to(Begins at: 1168, Ends at:1186) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | | OK | 0 | LOC: | 19 | | OK | 19 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK main(Begins at: 72, Ends at:1153) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 174 | *** | MONSTER | 174 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 340 | *** | MONSTER | 340 | LOC: | 1082 | *** | MONSTER | 1082 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! print_upload(Begins at: 1204, Ends at:1277) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 21 | *** | MONSTER | 21 | ParamNBR: | 5 | * | WARNING | 5 | CalledNBR: | 17 | * | WARNING | 17 | LOC: | 74 | * | WARNING | 74 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Fri Jul 10 09:51:50 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Fri Jul 10 10:15:07 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Fri Jul 10 10:15:15 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c parser.c | 2 clones | 0 monsters |0 warnings Message-ID: <22557912.201247234341265.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/general/g.parser/main.c ***************************************************************** Class context(Begins at: 36, Ends at:46) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Function main(Begins at: 258, Ends at:421) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 21 | *** | MONSTER | 21 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 42 | *** | MONSTER | 42 | LOC: | 164 | *** | MONSTER | 164 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! parse_boolean(Begins at: 171, Ends at:183) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 3 | | OK | 3 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK parse_flag(Begins at: 118, Ends at:153) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 14 | * | WARNING | 14 | LOC: | 36 | | OK | 36 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! parse_module(Begins at: 89, Ends at:116) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 11 | * | WARNING | 11 | LOC: | 28 | | OK | 28 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! parse_option(Begins at: 185, Ends at:256) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | ** | BABY-MONSTER | 14 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 30 | ** | BABY-MONSTER | 30 | LOC: | 72 | * | WARNING | 72 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! parse_toplevel(Begins at: 62, Ends at:87) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | * | WARNING | 6 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 7 | | OK | 7 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! parse_type(Begins at: 155, Ends at:169) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 4 | | OK | 4 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK translate(Begins at: 52, Ends at:60) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | | OK | 3 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/gis/parser.c ***************************************************************** Class Item(Begins at: 109, Ends at:114) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Function G_define_flag(Begins at: 176, Ends at:213) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | * | WARNING | 1 | CalledNBR: | 4 | * | WARNING | 4 | LOC: | 38 | * | WARNING | 38 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! G_define_module(Begins at: 649, Ends at:662) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | ** | BABY-MONSTER | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 14 | | OK | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_define_option(Begins at: 232, Ends at:283) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | ** | BABY-MONSTER | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | | OK | 4 | LOC: | 52 | | OK | 52 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_define_standard_option(Begins at: 312, Ends at:640) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 38 | * | WARNING | 38 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 43 | | OK | 43 | LOC: | 329 | | OK | 329 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_disable_interactive(Begins at: 155, Ends at:160) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | * | WARNING | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_gui(Begins at: 1973, Ends at:1988) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | * | WARNING | 5 | LOC: | 16 | * | WARNING | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! G_gui_tcltk(Begins at: 1918, Ends at:1947) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | | OK | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 12 | | OK | 12 | LOC: | 30 | | OK | 30 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_gui_wx(Begins at: 1952, Ends at:1964) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 6 | | OK | 6 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_parser(Begins at: 701, Ends at:955) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 41 | | OK | 41 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 83 | | OK | 83 | LOC: | 255 | | OK | 255 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_recreate_command(Begins at: 2600, Ends at:2699) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | * | WARNING | 14 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 26 | ** | BABY-MONSTER | 26 | LOC: | 100 | ** | BABY-MONSTER | 100 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_script(Begins at: 1696, Ends at:1808) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 24 | * | WARNING | 24 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 46 | * | WARNING | 46 | LOC: | 113 | * | WARNING | 113 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! G_tcltk(Begins at: 1993, Ends at:2001) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_usage(Begins at: 1008, Ends at:1179) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 34 | | OK | 34 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 53 | | OK | 53 | LOC: | 172 | | OK | 172 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_usage_html(Begins at: 1472, Ends at:1691) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 42 | | OK | 42 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 85 | | OK | 85 | LOC: | 220 | * | WARNING | 220 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_usage_xml(Begins at: 1234, Ends at:1467) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 31 | *** | MONSTER | 31 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 87 | *** | MONSTER | 87 | LOC: | 234 | *** | MONSTER | 234 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_an_opt(Begins at: 2201, Ends at:2243) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | | OK | 10 | ParamNBR: | 4 | | OK | 4 | CalledNBR: | 13 | | OK | 13 | LOC: | 43 | | OK | 43 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_double(Begins at: 2309, Ends at:2345) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | | OK | 14 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 37 | | OK | 37 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_int(Begins at: 2245, Ends at:2281) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | * | WARNING | 14 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | * | WARNING | 6 | LOC: | 37 | | OK | 37 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! check_multiple_opts(Begins at: 2457, Ends at:2492) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | | OK | 8 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | | OK | 5 | LOC: | 36 | | OK | 36 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_opts(Begins at: 2165, Ends at:2199) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | *** | MONSTER | 7 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | *** | MONSTER | 3 | LOC: | 35 | *** | MONSTER | 35 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_overwrite(Begins at: 2495, Ends at:2560) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | ** | BABY-MONSTER | 12 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 16 | ** | BABY-MONSTER | 16 | LOC: | 66 | ** | BABY-MONSTER | 66 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_required(Begins at: 2373, Ends at:2395) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | *** | MONSTER | 2 | LOC: | 23 | ** | BABY-MONSTER | 23 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_string(Begins at: 2347, Ends at:2371) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | | OK | 9 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 25 | | OK | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK contains(Begins at: 2083, Ends at:2091) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | *** | MONSTER | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | *** | MONSTER | 0 | LOC: | 9 | *** | MONSTER | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! generate_tcl(Begins at: 1815, Ends at:1913) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | *** | MONSTER | 12 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 34 | *** | MONSTER | 34 | LOC: | 99 | *** | MONSTER | 99 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! is_option(Begins at: 2093, Ends at:2106) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | *** | MONSTER | 2 | LOC: | 14 | *** | MONSTER | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! print_escaped_for_html(Begins at: 1213, Ends at:1227) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | * | WARNING | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | | OK | 5 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! print_escaped_for_xml(Begins at: 1189, Ends at:1206) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | | OK | 7 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 4 | | OK | 4 | LOC: | 18 | | OK | 18 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK set_flag(Begins at: 2054, Ends at:2078) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | *** | MONSTER | 4 | LOC: | 25 | ** | BABY-MONSTER | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! set_option(Begins at: 2108, Ends at:2163) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | | OK | 8 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 13 | | OK | 13 | LOC: | 56 | | OK | 56 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK show(Begins at: 2040, Ends at:2052) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 3 | | OK | 3 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK show_options(Begins at: 2010, Ends at:2038) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | * | WARNING | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 11 | | OK | 11 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! split_gisprompt(Begins at: 2562, Ends at:2590) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | | OK | 7 | ParamNBR: | 4 | | OK | 4 | CalledNBR: | 0 | | OK | 0 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK split_opts(Begins at: 2397, Ends at:2455) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | * | WARNING | 10 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 6 | * | WARNING | 6 | LOC: | 59 | * | WARNING | 59 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! uses_new_gisprompt(Begins at: 958, Ends at:983) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | | OK | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file has 2 potentially cloned functions: check_double In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c clones of check_double are: /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c check_int In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c clones of check_int are: /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c check_double ____________________________________________ Threshold grass key metrics values at Fri Jul 10 09:59:00 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Fri Jul 10 15:01:06 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Fri Jul 10 15:01:16 2009 Subject: [GRASS-QA] GRASS QA: martinl |parser.c | 2 clones | 0 monsters |0 warnings Message-ID: <23353346.211247251495954.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/lib/gis/parser.c ***************************************************************** Class Item(Begins at: 109, Ends at:114) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Function G_define_flag(Begins at: 176, Ends at:213) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | * | WARNING | 1 | CalledNBR: | 4 | * | WARNING | 4 | LOC: | 38 | * | WARNING | 38 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! G_define_module(Begins at: 649, Ends at:662) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | ** | BABY-MONSTER | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 14 | | OK | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_define_option(Begins at: 232, Ends at:283) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | ** | BABY-MONSTER | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | | OK | 4 | LOC: | 52 | | OK | 52 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_define_standard_option(Begins at: 312, Ends at:640) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 38 | * | WARNING | 38 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 43 | | OK | 43 | LOC: | 329 | | OK | 329 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_disable_interactive(Begins at: 155, Ends at:160) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | * | WARNING | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_gui(Begins at: 1973, Ends at:1988) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | * | WARNING | 5 | LOC: | 16 | * | WARNING | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! G_gui_tcltk(Begins at: 1918, Ends at:1947) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | | OK | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 12 | | OK | 12 | LOC: | 30 | | OK | 30 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_gui_wx(Begins at: 1952, Ends at:1964) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 6 | | OK | 6 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_parser(Begins at: 701, Ends at:955) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 41 | | OK | 41 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 83 | | OK | 83 | LOC: | 255 | | OK | 255 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_recreate_command(Begins at: 2600, Ends at:2699) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | * | WARNING | 14 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 26 | ** | BABY-MONSTER | 26 | LOC: | 100 | ** | BABY-MONSTER | 100 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_script(Begins at: 1696, Ends at:1808) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 24 | * | WARNING | 24 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 46 | * | WARNING | 46 | LOC: | 113 | * | WARNING | 113 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! G_tcltk(Begins at: 1993, Ends at:2001) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_usage(Begins at: 1008, Ends at:1179) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 34 | | OK | 34 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 53 | | OK | 53 | LOC: | 172 | | OK | 172 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_usage_html(Begins at: 1472, Ends at:1691) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 42 | | OK | 42 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 85 | | OK | 85 | LOC: | 220 | * | WARNING | 220 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_usage_xml(Begins at: 1234, Ends at:1467) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 31 | *** | MONSTER | 31 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 87 | *** | MONSTER | 87 | LOC: | 234 | *** | MONSTER | 234 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_an_opt(Begins at: 2201, Ends at:2243) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | | OK | 10 | ParamNBR: | 4 | | OK | 4 | CalledNBR: | 13 | | OK | 13 | LOC: | 43 | | OK | 43 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_double(Begins at: 2309, Ends at:2345) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | | OK | 14 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 37 | | OK | 37 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_int(Begins at: 2245, Ends at:2281) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | * | WARNING | 14 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | * | WARNING | 6 | LOC: | 37 | | OK | 37 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! check_multiple_opts(Begins at: 2457, Ends at:2492) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | | OK | 8 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | | OK | 5 | LOC: | 36 | | OK | 36 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_opts(Begins at: 2165, Ends at:2199) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | *** | MONSTER | 7 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | *** | MONSTER | 3 | LOC: | 35 | *** | MONSTER | 35 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_overwrite(Begins at: 2495, Ends at:2560) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | ** | BABY-MONSTER | 12 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 16 | ** | BABY-MONSTER | 16 | LOC: | 66 | ** | BABY-MONSTER | 66 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_required(Begins at: 2373, Ends at:2395) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | *** | MONSTER | 2 | LOC: | 23 | ** | BABY-MONSTER | 23 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_string(Begins at: 2347, Ends at:2371) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | | OK | 9 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 25 | | OK | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK contains(Begins at: 2083, Ends at:2091) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | *** | MONSTER | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | *** | MONSTER | 0 | LOC: | 9 | *** | MONSTER | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! generate_tcl(Begins at: 1815, Ends at:1913) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | *** | MONSTER | 12 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 34 | *** | MONSTER | 34 | LOC: | 99 | *** | MONSTER | 99 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! is_option(Begins at: 2093, Ends at:2106) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | *** | MONSTER | 2 | LOC: | 14 | *** | MONSTER | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! print_escaped_for_html(Begins at: 1213, Ends at:1227) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | * | WARNING | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | | OK | 5 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! print_escaped_for_xml(Begins at: 1189, Ends at:1206) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | | OK | 7 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 4 | | OK | 4 | LOC: | 18 | | OK | 18 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK set_flag(Begins at: 2054, Ends at:2078) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | *** | MONSTER | 4 | LOC: | 25 | ** | BABY-MONSTER | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! set_option(Begins at: 2108, Ends at:2163) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | | OK | 8 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 13 | | OK | 13 | LOC: | 56 | | OK | 56 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK show(Begins at: 2040, Ends at:2052) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 3 | | OK | 3 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK show_options(Begins at: 2010, Ends at:2038) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | * | WARNING | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 11 | | OK | 11 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! split_gisprompt(Begins at: 2562, Ends at:2590) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | | OK | 7 | ParamNBR: | 4 | | OK | 4 | CalledNBR: | 0 | | OK | 0 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK split_opts(Begins at: 2397, Ends at:2455) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | * | WARNING | 10 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 6 | * | WARNING | 6 | LOC: | 59 | * | WARNING | 59 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! uses_new_gisprompt(Begins at: 958, Ends at:983) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | | OK | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file has 2 potentially cloned functions: check_double In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c clones of check_double are: /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c check_int In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c clones of check_int are: /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c check_double ____________________________________________ Threshold grass key metrics values at Fri Jul 10 14:44:55 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Fri Jul 10 17:12:24 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Fri Jul 10 17:12:33 2009 Subject: [GRASS-QA] GRASS QA: martinl |rowio.h fileno.c forget.c get.c ...| no clones | 0 monsters |0 warnings Message-ID: <25220656.221247259371160.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/include/rowio.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/rowio/fileno.c ***************************************************************** Function rowio_fileno(Begins at: 13, Ends at:16) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 4 | | OK | 4 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/rowio/forget.c ***************************************************************** Function rowio_forget(Begins at: 3, Ends at:15) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | | OK | 0 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/rowio/get.c ***************************************************************** Function my_select(Begins at: 92, Ends at:102) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | | OK | 0 | LOC: | 11 | | OK | 11 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK pageout(Begins at: 82, Ends at:90) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | | OK | 0 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK rowio_flush(Begins at: 74, Ends at:80) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 1 | | OK | 1 | LOC: | 7 | | OK | 7 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK rowio_get(Begins at: 31, Ends at:72) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | * | WARNING | 10 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 3 | | OK | 3 | LOC: | 42 | * | WARNING | 42 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/rowio/put.c ***************************************************************** Function rowio_put(Begins at: 27, Ends at:41) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 1 | | OK | 1 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/rowio/release.c ***************************************************************** Function rowio_release(Begins at: 5, Ends at:15) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 11 | | OK | 11 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/rowio/setup.c ***************************************************************** Function rowio_setup(Begins at: 28, Ends at:57) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 14 | *** | MONSTER | 14 | CalledNBR: | 5 | | OK | 5 | LOC: | 30 | | OK | 30 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.mfilter/execute.c ***************************************************************** Function execute_filter(Begins at: 6, Ends at:120) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 18 | ** | BABY-MONSTER | 18 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 17 | * | WARNING | 17 | LOC: | 115 | ** | BABY-MONSTER | 115 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.mfilter/perform.c ***************************************************************** Function perform_filter(Begins at: 9, Ends at:102) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | ** | BABY-MONSTER | 14 | ParamNBR: | 5 | * | WARNING | 5 | CalledNBR: | 36 | ** | BABY-MONSTER | 36 | LOC: | 94 | ** | BABY-MONSTER | 94 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/raster/r.thin/io.c ***************************************************************** Function close_file(Begins at: 155, Ends at:187) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 19 | * | WARNING | 19 | LOC: | 33 | | OK | 33 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! get_a_row(Begins at: 56, Ends at:61) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 1 | | OK | 1 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK map_size(Begins at: 189, Ends at:196) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 0 | | OK | 0 | LOC: | 8 | | OK | 8 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! open_file(Begins at: 84, Ends at:153) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | | OK | 12 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 36 | | OK | 36 | LOC: | 70 | | OK | 70 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK put_a_row(Begins at: 63, Ends at:69) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | * | WARNING | 2 | CalledNBR: | 1 | | OK | 1 | LOC: | 7 | | OK | 7 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! read_row(Begins at: 72, Ends at:76) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 2 | | OK | 2 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! write_row(Begins at: 78, Ends at:82) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | * | WARNING | 1 | ParamNBR: | 4 | | OK | 4 | CalledNBR: | 2 | ** | BABY-MONSTER | 2 | LOC: | 5 | * | WARNING | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Fri Jul 10 16:56:11 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Sat Jul 11 08:00:23 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Sat Jul 11 08:00:32 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c | no clones | 0 monsters |0 warnings Message-ID: <33472303.231247312635730.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/general/g.parser/main.c ***************************************************************** Class context(Begins at: 36, Ends at:46) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Function main(Begins at: 258, Ends at:421) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 21 | *** | MONSTER | 21 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 42 | *** | MONSTER | 42 | LOC: | 164 | *** | MONSTER | 164 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! parse_boolean(Begins at: 171, Ends at:183) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 3 | | OK | 3 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK parse_flag(Begins at: 118, Ends at:153) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 14 | * | WARNING | 14 | LOC: | 36 | | OK | 36 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! parse_module(Begins at: 89, Ends at:116) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 11 | * | WARNING | 11 | LOC: | 28 | | OK | 28 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! parse_option(Begins at: 185, Ends at:256) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | ** | BABY-MONSTER | 14 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 30 | ** | BABY-MONSTER | 30 | LOC: | 72 | * | WARNING | 72 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! parse_toplevel(Begins at: 62, Ends at:87) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | * | WARNING | 6 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 7 | | OK | 7 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! parse_type(Begins at: 155, Ends at:169) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 4 | | OK | 4 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK translate(Begins at: 52, Ends at:60) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | | OK | 3 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Sat Jul 11 07:43:55 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Sat Jul 11 10:12:38 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Sat Jul 11 10:12:48 2009 Subject: [GRASS-QA] GRASS QA: martinl |color_rules.c | no clones | 0 monsters |0 warnings Message-ID: <3024710.241247320568851.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/branches/develbranch_6/lib/gis/color_rules.c ***************************************************************** Class rule(Begins at: 27, Ends at:32) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Function G_load_colors(Begins at: 243, Ends at:246) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 1 | | OK | 1 | LOC: | 4 | | OK | 4 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_load_fp_colors(Begins at: 248, Ends at:252) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 1 | | OK | 1 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_make_colors(Begins at: 264, Ends at:267) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 1 | | OK | 1 | LOC: | 4 | | OK | 4 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_make_fp_colors(Begins at: 269, Ends at:273) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 1 | | OK | 1 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_parse_color_rule(Begins at: 44, Ends at:102) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | * | WARNING | 10 | ParamNBR: | 10 | *** | MONSTER | 10 | CalledNBR: | 10 | * | WARNING | 10 | LOC: | 59 | * | WARNING | 59 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_parse_color_rule_error(Begins at: 104, Ends at:122) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | * | WARNING | 9 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 6 | | OK | 6 | LOC: | 19 | | OK | 19 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_read_color_rule(Begins at: 124, Ends at:156) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | * | WARNING | 6 | ParamNBR: | 10 | *** | MONSTER | 10 | CalledNBR: | 8 | | OK | 8 | LOC: | 33 | | OK | 33 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_read_color_rules(Begins at: 158, Ends at:223) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 11 | * | WARNING | 11 | ParamNBR: | 5 | * | WARNING | 5 | CalledNBR: | 7 | | OK | 7 | LOC: | 66 | * | WARNING | 66 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! load_rules_file(Begins at: 225, Ends at:241) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 3 | | OK | 3 | LOC: | 17 | | OK | 17 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! load_rules_name(Begins at: 254, Ends at:262) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 3 | | OK | 3 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Sat Jul 11 09:56:08 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Sun Jul 12 05:28:47 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Sun Jul 12 05:28:55 2009 Subject: [GRASS-QA] GRASS QA: martinl |list.c local_proto.h main.c | no clones | 0 monsters |0 warnings Message-ID: <24267517.251247389919052.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/vector/v.external/list.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/vector/v.external/local_proto.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/vector/v.external/main.c ***************************************************************** Function main(Begins at: 28, Ends at:165) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 15 | ** | BABY-MONSTER | 15 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 60 | *** | MONSTER | 60 | LOC: | 138 | ** | BABY-MONSTER | 138 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Sun Jul 12 05:11:59 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Sun Jul 12 05:35:53 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Sun Jul 12 05:36:02 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c | no clones | 0 monsters |0 warnings Message-ID: <1125185.261247390345718.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/vector/v.external/main.c ***************************************************************** Function main(Begins at: 28, Ends at:165) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 15 | ** | BABY-MONSTER | 15 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 60 | *** | MONSTER | 60 | LOC: | 138 | ** | BABY-MONSTER | 138 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Sun Jul 12 05:19:05 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Sun Jul 12 05:43:05 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Sun Jul 12 05:43:13 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c | no clones | 0 monsters |0 warnings Message-ID: <27207717.271247390777452.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/vector/v.external/main.c ***************************************************************** Function main(Begins at: 28, Ends at:165) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 15 | ** | BABY-MONSTER | 15 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 60 | *** | MONSTER | 60 | LOC: | 138 | ** | BABY-MONSTER | 138 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Sun Jul 12 05:26:17 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 01:15:06 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 01:15:18 2009 Subject: [GRASS-QA] GRASS QA: hamish |parser.c | 2 clones | 0 monsters |0 warnings Message-ID: <11193800.281247461078455.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello hamish, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/lib/gis/parser.c ***************************************************************** Class Item(Begins at: 109, Ends at:114) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Function G_define_flag(Begins at: 176, Ends at:213) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | * | WARNING | 1 | CalledNBR: | 4 | * | WARNING | 4 | LOC: | 38 | * | WARNING | 38 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! G_define_module(Begins at: 649, Ends at:662) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | ** | BABY-MONSTER | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 14 | | OK | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_define_option(Begins at: 232, Ends at:283) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | ** | BABY-MONSTER | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | | OK | 4 | LOC: | 52 | | OK | 52 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_define_standard_option(Begins at: 312, Ends at:640) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 38 | * | WARNING | 38 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 43 | | OK | 43 | LOC: | 329 | | OK | 329 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_disable_interactive(Begins at: 155, Ends at:160) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | * | WARNING | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_gui(Begins at: 1973, Ends at:1988) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | * | WARNING | 5 | LOC: | 16 | * | WARNING | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! G_gui_tcltk(Begins at: 1918, Ends at:1947) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | | OK | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 12 | | OK | 12 | LOC: | 30 | | OK | 30 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_gui_wx(Begins at: 1952, Ends at:1964) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | * | WARNING | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 6 | | OK | 6 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_parser(Begins at: 701, Ends at:955) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 41 | | OK | 41 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 83 | | OK | 83 | LOC: | 255 | | OK | 255 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_recreate_command(Begins at: 2600, Ends at:2699) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | * | WARNING | 14 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 26 | ** | BABY-MONSTER | 26 | LOC: | 100 | ** | BABY-MONSTER | 100 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! G_script(Begins at: 1696, Ends at:1808) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 24 | * | WARNING | 24 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 46 | * | WARNING | 46 | LOC: | 113 | * | WARNING | 113 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! G_tcltk(Begins at: 1993, Ends at:2001) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_usage(Begins at: 1008, Ends at:1179) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 34 | | OK | 34 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 53 | | OK | 53 | LOC: | 172 | | OK | 172 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK G_usage_html(Begins at: 1472, Ends at:1691) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 42 | | OK | 42 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 85 | | OK | 85 | LOC: | 220 | * | WARNING | 220 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! G_usage_xml(Begins at: 1234, Ends at:1467) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 31 | *** | MONSTER | 31 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 87 | *** | MONSTER | 87 | LOC: | 234 | *** | MONSTER | 234 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_an_opt(Begins at: 2201, Ends at:2243) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | | OK | 10 | ParamNBR: | 4 | | OK | 4 | CalledNBR: | 13 | | OK | 13 | LOC: | 43 | | OK | 43 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_double(Begins at: 2309, Ends at:2345) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | | OK | 14 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 37 | | OK | 37 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_int(Begins at: 2245, Ends at:2281) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | * | WARNING | 14 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | * | WARNING | 6 | LOC: | 37 | | OK | 37 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! check_multiple_opts(Begins at: 2457, Ends at:2492) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | | OK | 8 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | | OK | 5 | LOC: | 36 | | OK | 36 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK check_opts(Begins at: 2165, Ends at:2199) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | *** | MONSTER | 7 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | *** | MONSTER | 3 | LOC: | 35 | *** | MONSTER | 35 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_overwrite(Begins at: 2495, Ends at:2560) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | ** | BABY-MONSTER | 12 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 16 | ** | BABY-MONSTER | 16 | LOC: | 66 | ** | BABY-MONSTER | 66 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_required(Begins at: 2373, Ends at:2395) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | *** | MONSTER | 2 | LOC: | 23 | ** | BABY-MONSTER | 23 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! check_string(Begins at: 2347, Ends at:2371) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | | OK | 9 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 25 | | OK | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK contains(Begins at: 2083, Ends at:2091) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | *** | MONSTER | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | *** | MONSTER | 0 | LOC: | 9 | *** | MONSTER | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! generate_tcl(Begins at: 1815, Ends at:1913) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | *** | MONSTER | 12 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 34 | *** | MONSTER | 34 | LOC: | 99 | *** | MONSTER | 99 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! is_option(Begins at: 2093, Ends at:2106) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | *** | MONSTER | 2 | LOC: | 14 | *** | MONSTER | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! print_escaped_for_html(Begins at: 1213, Ends at:1227) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | * | WARNING | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | | OK | 5 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! print_escaped_for_xml(Begins at: 1189, Ends at:1206) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | | OK | 7 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 4 | | OK | 4 | LOC: | 18 | | OK | 18 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK set_flag(Begins at: 2054, Ends at:2078) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | *** | MONSTER | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | *** | MONSTER | 4 | LOC: | 25 | ** | BABY-MONSTER | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! set_option(Begins at: 2108, Ends at:2163) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | | OK | 8 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 13 | | OK | 13 | LOC: | 56 | | OK | 56 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK show(Begins at: 2040, Ends at:2052) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 3 | | OK | 3 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK show_options(Begins at: 2010, Ends at:2038) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | * | WARNING | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 11 | | OK | 11 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! split_gisprompt(Begins at: 2562, Ends at:2590) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | | OK | 7 | ParamNBR: | 4 | | OK | 4 | CalledNBR: | 0 | | OK | 0 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK split_opts(Begins at: 2397, Ends at:2455) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | * | WARNING | 10 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 6 | * | WARNING | 6 | LOC: | 59 | * | WARNING | 59 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! uses_new_gisprompt(Begins at: 958, Ends at:983) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | | OK | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file has 2 potentially cloned functions: check_double In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c clones of check_double are: /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c check_int In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c clones of check_int are: /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/parser.c check_double ____________________________________________ Threshold grass key metrics values at Mon Jul 13 00:57:58 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 02:58:54 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 02:59:02 2009 Subject: [GRASS-QA] GRASS QA: mmetz |build_nat.c | no clones | 0 monsters |0 warnings Message-ID: <32285907.291247467304661.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello mmetz, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/lib/vector/Vlib/build_nat.c ***************************************************************** Function Vect_attach_centroids(Begins at: 332, Ends at:413) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | * | WARNING | 9 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 9 | | OK | 9 | LOC: | 82 | * | WARNING | 82 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Vect_attach_isle(Begins at: 261, Ends at:288) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | | OK | 5 | LOC: | 28 | | OK | 28 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_attach_isles(Begins at: 298, Ends at:322) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | | OK | 5 | LOC: | 25 | | OK | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_build_line_area(Begins at: 40, Ends at:118) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | * | WARNING | 10 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 26 | ** | BABY-MONSTER | 26 | LOC: | 79 | * | WARNING | 79 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Vect_build_nat(Begins at: 425, Ends at:677) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 42 | *** | MONSTER | 42 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 59 | *** | MONSTER | 59 | LOC: | 253 | *** | MONSTER | 253 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Vect_isle_find_area(Begins at: 129, Ends at:251) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 11 | * | WARNING | 11 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 27 | ** | BABY-MONSTER | 27 | LOC: | 123 | ** | BABY-MONSTER | 123 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Mon Jul 13 02:41:44 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 03:06:01 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 03:06:09 2009 Subject: [GRASS-QA] GRASS QA: mmetz |poly.c | no clones | 0 monsters |0 warnings Message-ID: <30071640.301247467731863.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello mmetz, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/lib/vector/diglib/poly.c ***************************************************************** Function dig_find_area_poly(Begins at: 93, Ends at:116) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | | OK | 0 | LOC: | 24 | | OK | 24 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_get_poly_points(Begins at: 34, Ends at:86) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 1 | | OK | 1 | LOC: | 53 | * | WARNING | 53 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Mon Jul 13 02:48:51 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 05:57:58 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 05:58:05 2009 Subject: [GRASS-QA] GRASS QA: martinl |global.h head.c main.c parse.c ...| no clones | 0 monsters |0 warnings Message-ID: <11325951.311247478045786.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass-addons/vector/v.in.gama/global.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/v.in.gama/head.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/v.in.gama/main.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/v.in.gama/parse.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/v.in.gama/table.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/v.in.gama/tree.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/v.in.gama/vect.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Mon Jul 13 05:40:45 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 08:32:02 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 08:32:11 2009 Subject: [GRASS-QA] GRASS QA: mmetz |card.c card.h gammavol.c index.c ...| no clones | 0 monsters |0 warnings Message-ID: <20117085.321247487287269.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello mmetz, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/lib/vector/rtree/card.c ***************************************************************** Function RTreeGetLeafMax(Begins at: 44, Ends at:47) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 4 | | OK | 4 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeGetNodeMax(Begins at: 40, Ends at:43) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 4 | | OK | 4 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeSetLeafMax(Begins at: 36, Ends at:39) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 1 | | OK | 1 | LOC: | 4 | | OK | 4 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeSetNodeMax(Begins at: 32, Ends at:35) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 1 | | OK | 1 | LOC: | 4 | | OK | 4 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK set_max(Begins at: 24, Ends at:30) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | | OK | 0 | LOC: | 7 | | OK | 7 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/rtree/card.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/vector/rtree/gammavol.c ***************************************************************** Function main(Begins at: 36, Ends at:48) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 0 | | OK | 0 | CalledNBR: | 5 | | OK | 5 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK sphere_volume(Begins at: 27, Ends at:34) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | | OK | 3 | LOC: | 8 | | OK | 8 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/rtree/index.c ***************************************************************** Function RTreeDeleteRect(Begins at: 262, Ends at:311) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | * | WARNING | 8 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 10 | * | WARNING | 10 | LOC: | 50 | * | WARNING | 50 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! RTreeDeleteRect2(Begins at: 210, Ends at:254) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | * | WARNING | 8 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 9 | | OK | 9 | LOC: | 45 | * | WARNING | 45 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! RTreeFreeListNode(Begins at: 184, Ends at:188) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 1 | | OK | 1 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeInsertRect(Begins at: 138, Ends at:172) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 9 | | OK | 9 | LOC: | 35 | | OK | 35 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! RTreeInsertRect2(Begins at: 81, Ends at:128) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 5 | * | WARNING | 5 | CalledNBR: | 10 | * | WARNING | 10 | LOC: | 48 | * | WARNING | 48 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! RTreeNewIndex(Begins at: 25, Ends at:32) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 1 | | OK | 1 | LOC: | 8 | | OK | 8 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeNewListNode(Begins at: 178, Ends at:182) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeReInsert(Begins at: 194, Ends at:202) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 1 | | OK | 1 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeSearch(Begins at: 39, Ends at:70) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | * | WARNING | 8 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 7 | | OK | 7 | LOC: | 32 | | OK | 32 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/rtree/index.h ***************************************************************** Class Branch(Begins at: 47, Ends at:51) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class ListNode(Begins at: 63, Ends at:67) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Node(Begins at: 56, Ends at:61) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Rect(Begins at: 40, Ends at:43) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/rtree/node.c ***************************************************************** Function RTreeAddBranch(Begins at: 179, Ends at:204) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 6 | | OK | 6 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! RTreeDestroyNode(Begins at: 217, Ends at:231) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeDisconnectBranch(Begins at: 207, Ends at:214) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 4 | | OK | 4 | LOC: | 8 | | OK | 8 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeFreeNode(Begins at: 55, Ends at:60) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeInitBranch(Begins at: 25, Ends at:29) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 1 | | OK | 1 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeInitNode(Begins at: 32, Ends at:41) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 1 | | OK | 1 | LOC: | 10 | | OK | 10 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeNewNode(Begins at: 44, Ends at:53) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | | OK | 4 | LOC: | 10 | | OK | 10 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeNodeCover(Begins at: 111, Ends at:130) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | | OK | 4 | LOC: | 20 | | OK | 20 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreePickBranch(Begins at: 139, Ends at:171) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | | OK | 5 | LOC: | 33 | | OK | 33 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreePrintBranch(Begins at: 62, Ends at:66) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 2 | | OK | 2 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreePrintNode(Begins at: 77, Ends at:105) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 10 | * | WARNING | 10 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! RTreeTabIn(Begins at: 68, Ends at:74) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 1 | | OK | 1 | LOC: | 7 | | OK | 7 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/rtree/rect.c ***************************************************************** Function RTreeCombineRect(Begins at: 305, Ends at:325) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | | OK | 5 | LOC: | 21 | | OK | 21 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeContained(Begins at: 352, Ends at:374) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 3 | | OK | 3 | LOC: | 23 | | OK | 23 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeInitRect(Begins at: 38, Ends at:45) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 8 | | OK | 8 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeNullRect(Begins at: 52, Ends at:62) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 11 | | OK | 11 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeOverlap(Begins at: 331, Ends at:346) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 1 | | OK | 1 | LOC: | 16 | | OK | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreePrintRect(Begins at: 130, Ends at:143) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | | OK | 5 | LOC: | 14 | | OK | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeRectSphericalVolume(Begins at: 253, Ends at:269) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | | OK | 4 | LOC: | 17 | | OK | 17 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeRectSurfaceArea(Begins at: 275, Ends at:298) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 24 | | OK | 24 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreeRectVolume(Begins at: 148, Ends at:162) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | | OK | 3 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK sphere_volume(Begins at: 178, Ends at:185) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | | OK | 3 | LOC: | 8 | | OK | 8 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/rtree/rtree.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/vector/rtree/split.c ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/vector/rtree/split.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/vector/rtree/split_q.c ***************************************************************** Function RTreeClassify(Begins at: 61, Ends at:76) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 4 | | OK | 4 | LOC: | 16 | | OK | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! RTreeGetBranches(Begins at: 30, Ends at:53) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 10 | * | WARNING | 10 | LOC: | 24 | | OK | 24 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! RTreeInitPVars(Begins at: 142, Ends at:157) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 2 | | OK | 2 | LOC: | 16 | | OK | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! RTreeLoadNodes(Begins at: 118, Ends at:134) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 6 | | OK | 6 | LOC: | 17 | | OK | 17 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! RTreeMethodZero(Begins at: 216, Ends at:278) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 11 | * | WARNING | 11 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 11 | * | WARNING | 11 | LOC: | 63 | * | WARNING | 63 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! RTreePickSeeds(Begins at: 85, Ends at:110) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | | OK | 5 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK RTreePrintPVars(Begins at: 165, Ends at:200) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | * | WARNING | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 16 | * | WARNING | 16 | LOC: | 36 | | OK | 36 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! RTreeSplitNode(Begins at: 287, Ends at:312) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 6 | | OK | 6 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/rtree/split_q.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/lib/vector/rtree/docs/test.c ***************************************************************** The system don't find class, method and function in this file during analysis! ____________________________________________ Threshold grass key metrics values at Mon Jul 13 08:14:47 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 08:39:11 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 08:39:21 2009 Subject: [GRASS-QA] GRASS QA: mmetz |plus.c spindex.c spindex_rw.c | 32 clones | 0 monsters |0 warnings Message-ID: <19836484.331247487716559.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello mmetz, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/lib/vector/diglib/plus.c ***************************************************************** Function dig_free_plus(Begins at: 241, Ends at:250) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 6 | | OK | 6 | LOC: | 10 | | OK | 10 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_free_plus_areas(Begins at: 173, Ends at:200) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | * | WARNING | 6 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | | OK | 5 | LOC: | 28 | | OK | 28 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_free_plus_isles(Begins at: 207, Ends at:232) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | | OK | 4 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_free_plus_lines(Begins at: 137, Ends at:166) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | | OK | 3 | LOC: | 30 | | OK | 30 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_free_plus_nodes(Begins at: 105, Ends at:130) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | | OK | 5 | LOC: | 26 | | OK | 26 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_init_plus(Begins at: 31, Ends at:98) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 3 | | OK | 3 | LOC: | 68 | * | WARNING | 68 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_load_plus(Begins at: 262, Ends at:327) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 15 | ** | BABY-MONSTER | 15 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 32 | ** | BABY-MONSTER | 32 | LOC: | 66 | * | WARNING | 66 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! dig_write_areas(Begins at: 437, Ends at:451) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 2 | | OK | 2 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_write_isles(Begins at: 462, Ends at:476) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 2 | | OK | 2 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_write_lines(Begins at: 412, Ends at:426) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 2 | | OK | 2 | LOC: | 15 | | OK | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_write_nodes(Begins at: 388, Ends at:401) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 2 | | OK | 2 | LOC: | 14 | | OK | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_write_plus_file(Begins at: 338, Ends at:377) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 22 | * | WARNING | 22 | LOC: | 40 | | OK | 40 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Clone analysis: This file has 12 potentially cloned functions: dig_write_lines dig_write_isles dig_write_nodes dig_write_lines dig_write_areas dig_write_nodes dig_write_areas dig_write_isles dig_write_lines dig_write_areas dig_write_isles In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c clones of dig_write_areas are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_nodes /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_lines /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_isles In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c clones of dig_write_isles are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_nodes /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_lines /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_areas In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c clones of dig_write_lines are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_nodes /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_areas /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_isles In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c clones of dig_write_nodes are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_lines /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_areas /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_isles ***************************************************************** File :grass/trunk/lib/vector/diglib/spindex.c ***************************************************************** Function _add_item(Begins at: 368, Ends at:372) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 1 | | OK | 1 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK _add_node(Begins at: 405, Ends at:409) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | | OK | 0 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_find_node(Begins at: 420, Ends at:441) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 3 | | OK | 3 | LOC: | 22 | | OK | 22 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_select_areas(Begins at: 481, Ends at:499) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 2 | | OK | 2 | LOC: | 19 | | OK | 19 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_select_isles(Begins at: 510, Ends at:528) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 2 | | OK | 2 | LOC: | 19 | | OK | 19 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_select_lines(Begins at: 452, Ends at:470) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 2 | | OK | 2 | LOC: | 19 | | OK | 19 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_select_nodes(Begins at: 384, Ends at:402) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 2 | | OK | 2 | LOC: | 19 | | OK | 19 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_spidx_add_area(Begins at: 174, Ends at:189) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 2 | | OK | 2 | LOC: | 16 | | OK | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_spidx_add_isle(Begins at: 201, Ends at:216) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 2 | | OK | 2 | LOC: | 16 | | OK | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_spidx_add_line(Begins at: 148, Ends at:163) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 2 | | OK | 2 | LOC: | 16 | | OK | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_spidx_add_node(Begins at: 119, Ends at:137) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 5 | * | WARNING | 5 | CalledNBR: | 2 | | OK | 2 | LOC: | 19 | | OK | 19 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_spidx_del_area(Begins at: 303, Ends at:330) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 28 | | OK | 28 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_spidx_del_isle(Begins at: 342, Ends at:365) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 4 | | OK | 4 | LOC: | 24 | | OK | 24 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_spidx_del_line(Begins at: 263, Ends at:291) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_spidx_del_node(Begins at: 228, Ends at:251) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 4 | | OK | 4 | LOC: | 24 | | OK | 24 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_spidx_free(Begins at: 101, Ends at:107) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | | OK | 4 | LOC: | 7 | | OK | 7 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_spidx_free_areas(Begins at: 79, Ends at:83) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_spidx_free_isles(Begins at: 90, Ends at:94) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_spidx_free_lines(Begins at: 68, Ends at:72) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_spidx_free_nodes(Begins at: 57, Ends at:61) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_spidx_init(Begins at: 31, Ends at:50) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 5 | | OK | 5 | LOC: | 20 | | OK | 20 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file has 20 potentially cloned functions: dig_select_lines dig_select_isles dig_select_nodes dig_select_lines dig_select_areas dig_select_nodes dig_select_areas dig_select_isles dig_select_lines dig_select_areas dig_select_isles dig_spidx_add_line dig_spidx_add_isle dig_spidx_add_line dig_spidx_add_area dig_spidx_add_area dig_spidx_add_isle dig_spidx_del_node dig_spidx_del_isle In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_select_areas are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_select_nodes /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_select_lines /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_select_isles In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_select_isles are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_select_nodes /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_select_lines /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_select_areas In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_select_lines are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_select_nodes /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_select_areas /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_select_isles In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_select_nodes are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_select_lines /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_select_areas /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_select_isles In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_spidx_add_area are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_spidx_add_line /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_spidx_add_isle In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_spidx_add_isle are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_spidx_add_line /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_spidx_add_area In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_spidx_add_line are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_spidx_add_area /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_spidx_add_isle In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_spidx_del_isle are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_spidx_del_node In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c clones of dig_spidx_del_node are: /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/spindex.c dig_spidx_del_isle ***************************************************************** File :grass/trunk/lib/vector/diglib/spindex_rw.c ***************************************************************** Function dig_Rd_spindx_head(Begins at: 79, Ends at:162) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | ** | BABY-MONSTER | 14 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 22 | * | WARNING | 22 | LOC: | 84 | * | WARNING | 84 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! dig_Wr_spindx_head(Begins at: 23, Ends at:76) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | * | WARNING | 12 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 16 | * | WARNING | 16 | LOC: | 54 | * | WARNING | 54 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! dig_dump_spidx(Begins at: 383, Ends at:399) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 8 | | OK | 8 | LOC: | 17 | | OK | 17 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_read_spidx(Begins at: 356, Ends at:380) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 13 | * | WARNING | 13 | LOC: | 25 | | OK | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_write_spidx(Begins at: 330, Ends at:353) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 13 | * | WARNING | 13 | LOC: | 24 | | OK | 24 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! rtree_dump_branch(Begins at: 167, Ends at:183) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 3 | | OK | 3 | LOC: | 17 | | OK | 17 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! rtree_dump_node(Begins at: 186, Ends at:205) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 3 | | OK | 3 | LOC: | 20 | | OK | 20 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! rtree_read_branch(Begins at: 268, Ends at:302) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 7 | | OK | 7 | LOC: | 35 | | OK | 35 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! rtree_read_node(Begins at: 305, Ends at:327) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 4 | | OK | 4 | LOC: | 23 | | OK | 23 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! rtree_write_branch(Begins at: 210, Ends at:237) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 5 | | OK | 5 | LOC: | 28 | | OK | 28 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! rtree_write_node(Begins at: 240, Ends at:263) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | * | WARNING | 6 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 3 | | OK | 3 | LOC: | 24 | | OK | 24 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Mon Jul 13 08:21:56 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 08:46:27 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 08:46:37 2009 Subject: [GRASS-QA] GRASS QA: mmetz |build.c build_nat.c close.c intersect.c ...| 1 clones | 0 monsters |0 warnings Message-ID: <14469727.341247488152547.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello mmetz, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/lib/vector/Vlib/build.c ***************************************************************** Function Vect_build(Begins at: 73, Ends at:76) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 1 | | OK | 1 | LOC: | 4 | | OK | 4 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_build_partial(Begins at: 128, Ends at:248) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 20 | | OK | 20 | ParamNBR: | 3 | | OK | 3 | CalledNBR: | 46 | | OK | 46 | LOC: | 121 | | OK | 121 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_get_built(Begins at: 86, Ends at:89) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 4 | | OK | 4 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_save_spatial_index(Begins at: 408, Ends at:440) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | ** | BABY-MONSTER | 3 | ParamNBR: | 1 | * | WARNING | 1 | CalledNBR: | 14 | *** | MONSTER | 14 | LOC: | 33 | ** | BABY-MONSTER | 33 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Vect_save_topo(Begins at: 257, Ends at:289) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 14 | | OK | 14 | LOC: | 33 | | OK | 33 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_spatial_index_dump(Begins at: 451, Ends at:462) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 3 | * | WARNING | 3 | LOC: | 12 | | OK | 12 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Vect_topo_dump(Begins at: 300, Ends at:398) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 13 | | OK | 13 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 21 | * | WARNING | 21 | LOC: | 99 | | OK | 99 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! format(Begins at: 29, Ends at:33) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 0 | | OK | 0 | CalledNBR: | 2 | | OK | 2 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK prnmsg(Begins at: 48, Ends at:62) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | ** | BABY-MONSTER | 2 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | * | WARNING | 5 | LOC: | 15 | ** | BABY-MONSTER | 15 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/Vlib/build_nat.c ***************************************************************** Function Vect_attach_centroids(Begins at: 332, Ends at:413) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | * | WARNING | 9 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 9 | | OK | 9 | LOC: | 82 | * | WARNING | 82 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Vect_attach_isle(Begins at: 261, Ends at:288) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | | OK | 5 | LOC: | 28 | | OK | 28 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_attach_isles(Begins at: 298, Ends at:322) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 5 | | OK | 5 | LOC: | 25 | | OK | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_build_line_area(Begins at: 40, Ends at:118) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | * | WARNING | 10 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 26 | ** | BABY-MONSTER | 26 | LOC: | 79 | * | WARNING | 79 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Vect_build_nat(Begins at: 425, Ends at:677) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 42 | *** | MONSTER | 42 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 59 | *** | MONSTER | 59 | LOC: | 253 | *** | MONSTER | 253 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Vect_isle_find_area(Begins at: 129, Ends at:251) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 11 | * | WARNING | 11 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 27 | ** | BABY-MONSTER | 27 | LOC: | 123 | ** | BABY-MONSTER | 123 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/Vlib/close.c ***************************************************************** Function Vect_close(Begins at: 64, Ends at:148) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | * | WARNING | 12 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 33 | ** | BABY-MONSTER | 33 | LOC: | 85 | * | WARNING | 85 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! clo_dummy(Begins at: 30, Ends at:33) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 0 | | OK | 0 | CalledNBR: | 0 | | OK | 0 | LOC: | 4 | | OK | 4 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK format(Begins at: 36, Ends at:40) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 0 | | OK | 0 | CalledNBR: | 2 | | OK | 2 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/Vlib/intersect.c ***************************************************************** Function Vect_line_check_intersection(Begins at: 1110, Ends at:1248) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 18 | | OK | 18 | ParamNBR: | 3 | ** | BABY-MONSTER | 3 | CalledNBR: | 6 | | OK | 6 | LOC: | 139 | | OK | 139 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Vect_line_intersection(Begins at: 600, Ends at:1066) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 44 | | OK | 44 | ParamNBR: | 7 | | OK | 7 | CalledNBR: | 48 | | OK | 48 | LOC: | 467 | | OK | 467 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_segment_intersection(Begins at: 109, Ends at:456) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 41 | | OK | 41 | ParamNBR: | 19 | | OK | 19 | CalledNBR: | 43 | | OK | 43 | LOC: | 348 | | OK | 348 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK add_cross(Begins at: 474, Ends at:498) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 6 | * | WARNING | 6 | CalledNBR: | 5 | | OK | 5 | LOC: | 25 | | OK | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! cmp_cross(Begins at: 500, Ends at:515) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 0 | | OK | 0 | LOC: | 16 | | OK | 16 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK cross_seg(Begins at: 545, Ends at:580) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | ** | BABY-MONSTER | 4 | ParamNBR: | 2 | * | WARNING | 2 | CalledNBR: | 7 | | OK | 7 | LOC: | 36 | ** | BABY-MONSTER | 36 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! dist2(Begins at: 517, Ends at:524) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | *** | MONSTER | 1 | ParamNBR: | 4 | ** | BABY-MONSTER | 4 | CalledNBR: | 0 | *** | MONSTER | 0 | LOC: | 8 | *** | MONSTER | 8 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! find_cross(Begins at: 1073, Ends at:1096) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | *** | MONSTER | 2 | ParamNBR: | 2 | *** | MONSTER | 2 | CalledNBR: | 1 | *** | MONSTER | 1 | LOC: | 24 | *** | MONSTER | 24 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/Vlib/open.c ***************************************************************** Function Vect__open_old(Begins at: 124, Ends at:396) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 31 | | OK | 31 | ParamNBR: | 5 | | OK | 5 | CalledNBR: | 102 | | OK | 102 | LOC: | 273 | | OK | 273 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_coor_info(Begins at: 608, Ends at:646) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | *** | MONSTER | 6 | ParamNBR: | 2 | * | WARNING | 2 | CalledNBR: | 11 | *** | MONSTER | 11 | LOC: | 39 | *** | MONSTER | 39 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Vect_maptype_info(Begins at: 656, Ends at:673) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | * | WARNING | 5 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 4 | * | WARNING | 4 | LOC: | 18 | | OK | 18 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Vect_open_new(Begins at: 514, Ends at:597) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | | OK | 8 | ParamNBR: | 3 | | OK | 3 | CalledNBR: | 43 | | OK | 43 | LOC: | 84 | | OK | 84 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_open_old(Begins at: 410, Ends at:413) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | * | WARNING | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 1 | *** | MONSTER | 1 | LOC: | 4 | * | WARNING | 4 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Vect_open_old_head(Begins at: 464, Ends at:468) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 1 | | OK | 1 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Vect_open_spatial_index(Begins at: 767, Ends at:832) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | * | WARNING | 1 | CalledNBR: | 8 | | OK | 8 | LOC: | 66 | | OK | 66 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Vect_open_topo(Begins at: 686, Ends at:757) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | | OK | 7 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 16 | | OK | 16 | LOC: | 72 | * | WARNING | 72 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Vect_open_update(Begins at: 427, Ends at:449) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | * | WARNING | 2 | ParamNBR: | 3 | | OK | 3 | CalledNBR: | 2 | * | WARNING | 2 | LOC: | 23 | * | WARNING | 23 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! Vect_open_update_head(Begins at: 482, Ends at:502) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 1 | | OK | 1 | LOC: | 21 | | OK | 21 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Vect_set_open_level(Begins at: 96, Ends at:107) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | * | WARNING | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 12 | | OK | 12 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! fatal_error(Begins at: 59, Ends at:71) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 2 | | OK | 2 | LOC: | 13 | | OK | 13 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK format(Begins at: 38, Ends at:42) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 0 | | OK | 0 | CalledNBR: | 2 | | OK | 2 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK open_old_dummy(Begins at: 32, Ends at:35) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 0 | | OK | 0 | CalledNBR: | 0 | | OK | 0 | LOC: | 4 | | OK | 4 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/Vlib/select.c ***************************************************************** Function Vect_select_areas_by_box(Begins at: 91, Ends at:115) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 6 | | OK | 6 | LOC: | 25 | | OK | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Vect_select_areas_by_polygon(Begins at: 293, Ends at:351) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 10 | * | WARNING | 10 | ParamNBR: | 5 | * | WARNING | 5 | CalledNBR: | 18 | * | WARNING | 18 | LOC: | 59 | * | WARNING | 59 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! Vect_select_isles_by_box(Begins at: 130, Ends at:147) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 6 | | OK | 6 | LOC: | 18 | | OK | 18 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Vect_select_lines_by_box(Begins at: 37, Ends at:77) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | * | WARNING | 6 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 9 | | OK | 9 | LOC: | 41 | | OK | 41 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Vect_select_lines_by_polygon(Begins at: 197, Ends at:274) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | ** | BABY-MONSTER | 14 | ParamNBR: | 6 | ** | BABY-MONSTER | 6 | CalledNBR: | 15 | * | WARNING | 15 | LOC: | 78 | * | WARNING | 78 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Vect_select_nodes_by_box(Begins at: 158, Ends at:181) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 6 | | OK | 6 | LOC: | 24 | | OK | 24 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/lib/vector/Vlib/sindex.c ***************************************************************** Function Vect_build_sidx_from_topo(Begins at: 145, Ends at:236) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 9 | * | WARNING | 9 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 19 | * | WARNING | 19 | LOC: | 92 | ** | BABY-MONSTER | 92 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Vect_build_spatial_index(Begins at: 124, Ends at:134) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 3 | | OK | 3 | LOC: | 11 | | OK | 11 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_spatial_index_add_item(Begins at: 66, Ends at:79) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 2 | | OK | 2 | LOC: | 14 | | OK | 14 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Vect_spatial_index_del_item(Begins at: 89, Ends at:110) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 6 | | OK | 6 | LOC: | 22 | | OK | 22 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_spatial_index_destroy(Begins at: 50, Ends at:55) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_spatial_index_init(Begins at: 34, Ends at:39) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 2 | | OK | 2 | LOC: | 6 | | OK | 6 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Vect_spatial_index_select(Begins at: 255, Ends at:275) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 3 | | OK | 3 | LOC: | 21 | | OK | 21 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! _add_item(Begins at: 240, Ends at:244) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 1 | | OK | 1 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file has 1 potentially cloned functions: In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/sindex.c clones of Vect_build_spatial_index are: /var/project-manager/grass/grassSVN/grass/trunk/lib/db/dbmi_driver/d_mkdir.c make_dir ____________________________________________ Threshold grass key metrics values at Mon Jul 13 08:29:12 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 08:53:39 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 08:53:49 2009 Subject: [GRASS-QA] GRASS QA: mmetz |vector.h dig_externs.h dig_structs.h | no clones | 0 monsters |0 warnings Message-ID: <4093943.351247488584529.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello mmetz, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/include/vector.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/include/vect/dig_externs.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass/trunk/include/vect/dig_structs.h ***************************************************************** Class Cat_index(Begins at: 223, Ends at:233) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 1 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 1 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Coor_info(Begins at: 161, Ends at:165) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Format_info(Begins at: 216, Ends at:220) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Format_info_ogr(Begins at: 170, Ends at:214) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Map_info(Begins at: 353, Ends at:418) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class P_area(Begins at: 454, Ends at:474) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class P_isle(Begins at: 476, Ends at:492) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class P_line(Begins at: 434, Ends at:452) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class P_node(Begins at: 420, Ends at:432) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Plus_head(Begins at: 235, Ends at:351) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class Port_info(Begins at: 92, Ends at:113) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class bound_box(Begins at: 53, Ends at:61) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class cat_list(Begins at: 511, Ends at:518) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class dblinks(Begins at: 85, Ends at:89) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class dig_head(Begins at: 122, Ends at:158) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class field_info(Begins at: 75, Ends at:83) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class ilist(Begins at: 521, Ends at:526) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class line_cats(Begins at: 503, Ends at:509) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class line_pnts(Begins at: 494, Ends at:501) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Class recycle(Begins at: 116, Ends at:120) +--------+--------+--------+--------+--------+--------+ | DIT | NOC | WMC | RFC | CBO | LCOM | +------------+--------+--------+--------+--------+--------+--------| |NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------| |OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 | +------------+--------+--------+--------+--------+--------+--------+ Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Mon Jul 13 08:36:24 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 09:00:47 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 09:00:55 2009 Subject: [GRASS-QA] GRASS QA: mmetz |main.c | no clones | 0 monsters |0 warnings Message-ID: <20175164.361247489012402.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello mmetz, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/vector/v.build/main.c ***************************************************************** Function main(Begins at: 24, Ends at:167) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 27 | *** | MONSTER | 27 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 47 | *** | MONSTER | 47 | LOC: | 144 | *** | MONSTER | 144 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Mon Jul 13 08:43:32 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 09:08:04 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 09:08:10 2009 Subject: [GRASS-QA] GRASS QA: mmetz |main.c | no clones | 0 monsters |0 warnings Message-ID: <6616753.371247489448770.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello mmetz, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/vector/v.what/main.c ***************************************************************** Function main(Begins at: 37, Ends at:193) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 18 | ** | BABY-MONSTER | 18 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 51 | *** | MONSTER | 51 | LOC: | 157 | *** | MONSTER | 157 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Mon Jul 13 08:50:48 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 09:15:10 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 09:15:18 2009 Subject: [GRASS-QA] GRASS QA: mmetz |main.c | no clones | 0 monsters |0 warnings Message-ID: <31289565.381247489874579.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello mmetz, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/vector/v.select/main.c ***************************************************************** Function add_aarea(Begins at: 27, Ends at:55) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 8 | | OK | 8 | LOC: | 29 | | OK | 29 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! line_overlap_area(Begins at: 59, Ends at:105) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 14 | * | WARNING | 14 | LOC: | 47 | * | WARNING | 47 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! main(Begins at: 107, Ends at:518) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 52 | *** | MONSTER | 52 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 121 | *** | MONSTER | 121 | LOC: | 412 | *** | MONSTER | 412 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Mon Jul 13 08:57:54 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 09:22:38 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 09:22:46 2009 Subject: [GRASS-QA] GRASS QA: mmetz |main.c | no clones | 0 monsters |0 warnings Message-ID: <3443905.391247490323244.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello mmetz, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/vector/v.in.ogr/main.c ***************************************************************** Function main(Begins at: 47, Ends at:1133) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 115 | *** | MONSTER | 115 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 422 | *** | MONSTER | 422 | LOC: | 1087 | *** | MONSTER | 1087 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Mon Jul 13 09:05:22 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 09:30:23 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 09:30:32 2009 Subject: [GRASS-QA] GRASS QA: mmetz |main.c | no clones | 0 monsters |0 warnings Message-ID: <1518303.401247490787655.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello mmetz, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/vector/v.what/main.c ***************************************************************** Function main(Begins at: 37, Ends at:193) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 18 | ** | BABY-MONSTER | 18 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 51 | *** | MONSTER | 51 | LOC: | 157 | *** | MONSTER | 157 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Mon Jul 13 09:13:07 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 11:36:05 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 11:36:16 2009 Subject: [GRASS-QA] GRASS QA: mmetz |spindex_rw.c | no clones | 0 monsters |0 warnings Message-ID: <684429.411247498327886.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello mmetz, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/lib/vector/diglib/spindex_rw.c ***************************************************************** Function dig_Rd_spindx_head(Begins at: 79, Ends at:162) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 14 | ** | BABY-MONSTER | 14 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 22 | * | WARNING | 22 | LOC: | 84 | * | WARNING | 84 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! dig_Wr_spindx_head(Begins at: 23, Ends at:76) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | * | WARNING | 12 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 16 | * | WARNING | 16 | LOC: | 54 | * | WARNING | 54 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 3 values are close to an outlier please consider revising code! dig_dump_spidx(Begins at: 383, Ends at:399) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 8 | | OK | 8 | LOC: | 17 | | OK | 17 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK dig_read_spidx(Begins at: 356, Ends at:380) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 13 | * | WARNING | 13 | LOC: | 25 | | OK | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! dig_write_spidx(Begins at: 330, Ends at:353) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 13 | * | WARNING | 13 | LOC: | 24 | | OK | 24 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! rtree_dump_branch(Begins at: 167, Ends at:183) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 3 | | OK | 3 | LOC: | 17 | | OK | 17 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! rtree_dump_node(Begins at: 186, Ends at:205) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 4 | | OK | 4 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 3 | | OK | 3 | LOC: | 20 | | OK | 20 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! rtree_read_branch(Begins at: 268, Ends at:302) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 7 | | OK | 7 | LOC: | 35 | | OK | 35 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! rtree_read_node(Begins at: 305, Ends at:327) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 5 | | OK | 5 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 4 | | OK | 4 | LOC: | 23 | | OK | 23 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! rtree_write_branch(Begins at: 210, Ends at:237) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 4 | * | WARNING | 4 | CalledNBR: | 5 | | OK | 5 | LOC: | 28 | | OK | 28 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! rtree_write_node(Begins at: 240, Ends at:263) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 6 | * | WARNING | 6 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 3 | | OK | 3 | LOC: | 24 | | OK | 24 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 2 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Mon Jul 13 11:18:47 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Mon Jul 13 13:33:08 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Mon Jul 13 13:33:17 2009 Subject: [GRASS-QA] GRASS QA: martinl |main.c main.c | no clones | 0 monsters |0 warnings Message-ID: <26850078.421247505348854.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello martinl, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass/trunk/doc/raster/r.example/main.c ***************************************************************** Function c_calc(Begins at: 36, Ends at:40) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK d_calc(Begins at: 48, Ends at:52) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK f_calc(Begins at: 42, Ends at:46) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 1 | | OK | 1 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 0 | | OK | 0 | LOC: | 5 | | OK | 5 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK main(Begins at: 59, Ends at:199) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 16 | ** | BABY-MONSTER | 16 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 49 | *** | MONSTER | 49 | LOC: | 141 | *** | MONSTER | 141 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass/trunk/doc/vector/v.example/main.c ***************************************************************** Function main(Begins at: 27, Ends at:223) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 21 | *** | MONSTER | 21 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 89 | *** | MONSTER | 89 | LOC: | 197 | *** | MONSTER | 197 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Mon Jul 13 13:15:48 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html From soccerlab.info at gmail.com Tue Jul 14 01:59:54 2009 From: soccerlab.info at gmail.com (soccerlab.info@gmail.com) Date: Tue Jul 14 02:00:05 2009 Subject: [GRASS-QA] GRASS QA: hamish |forest2tree.c helper.c main.c strahler.c ...| no clones | 0 monsters |0 warnings Message-ID: <26298525.431247550142832.JavaMail.tomcat@web.soccerlab.polymtl.ca> Hello hamish, here's a report on your recent GRASS-SVN change : ANALYSIS your changes to files/class/methods/functions : ***************************************************************** File :grass-addons/vector/v.strahler/forest2tree.c ***************************************************************** Function StrahForestToTrees(Begins at: 46, Ends at:109) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 8 | * | WARNING | 8 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 16 | * | WARNING | 16 | LOC: | 64 | * | WARNING | 64 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! nexttree(Begins at: 36, Ends at:43) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 1 | | OK | 1 | LOC: | 8 | | OK | 8 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! pop_line(Begins at: 22, Ends at:30) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 1 | | OK | 1 | LOC: | 9 | | OK | 9 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK push_line(Begins at: 13, Ends at:20) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 1 | | OK | 1 | CalledNBR: | 1 | | OK | 1 | LOC: | 8 | | OK | 8 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a OK | -----------------------------------------------------------+ metrics are OK Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass-addons/vector/v.strahler/helper.c ***************************************************************** Function StrahGetDegr(Begins at: 6, Ends at:51) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 3 | | OK | 3 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 8 | | OK | 8 | LOC: | 46 | * | WARNING | 46 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! StrahGetNodeLine(Begins at: 53, Ends at:77) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 3 | | OK | 3 | LOC: | 25 | | OK | 25 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass-addons/vector/v.strahler/main.c ***************************************************************** Function main(Begins at: 54, Ends at:356) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 26 | *** | MONSTER | 26 | ParamNBR: | 2 | | OK | 2 | CalledNBR: | 118 | *** | MONSTER | 118 | LOC: | 303 | *** | MONSTER | 303 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass-addons/vector/v.strahler/strahler.c ***************************************************************** Function StrahFindLeaves(Begins at: 4, Ends at:86) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 7 | * | WARNING | 7 | ParamNBR: | 5 | * | WARNING | 5 | CalledNBR: | 17 | * | WARNING | 17 | LOC: | 83 | * | WARNING | 83 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 4 values are close to an outlier please consider revising code! StrahOrder(Begins at: 89, Ends at:210) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 12 | * | WARNING | 12 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 14 | * | WARNING | 14 | LOC: | 122 | ** | BABY-MONSTER | 122 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a BABY-MONSTER | -----------------------------------------------------------+ metric are OUT OF RANGE! Clone analysis: This file does not contain cloned functions ***************************************************************** File :grass-addons/vector/v.strahler/strahler.h ***************************************************************** The system don't find class, method and function in this file during analysis! ***************************************************************** File :grass-addons/vector/v.strahler/write.c ***************************************************************** Function StrahWriteToFile(Begins at: 3, Ends at:14) --------------+---------+-------+--------------+-----------+ | New Metrics |Old Metrics| --------------+---------+-------+--------------+-----------+ Complexity: | 2 | | OK | 2 | ParamNBR: | 3 | * | WARNING | 3 | CalledNBR: | 4 | | OK | 4 | LOC: | 12 | | OK | 12 | --------------+---------+-------+--------------+-----------+ Conclusion: | this function is a WARNING | -----------------------------------------------------------+ at least 1 values are close to an outlier please consider revising code! Clone analysis: This file does not contain cloned functions ____________________________________________ Threshold grass key metrics values at Tue Jul 14 01:42:22 EDT 2009 are: ----------------------+-----------+-----------+-----------+ | warning | middle | extrem | | limits | limits | limits | ----------------------+-----------+-----------+-----------+ Complexity (Cyclo): | 6 | 13 | 21 | ParamNBR: | 3 | 6 | 9 | CalledNBR: | 10 | 23 | 37 | LOC: | 42 | 91 | 141 | ----------------------+-----------+-----------+-----------+ Measures (see below Web page for details) : -Complexity (Cyclo): a complexity index -ParamNBR: number of passed parameters -CalledNBR: number of called functions -LOC: Lines Of Code -Global analysis: based on 21 metrics(the fourth preceding include) Message interpretation : OK : Nothing to say at all * : this is getting close to be out of range, consider revising the code ** : this is a baby monster, you should revise this function ***: this is a monster, definitely you should revise this function Conclusion interpretation : CORRECT : if all metrics are situated before warning limits WARNING : if 1 to more metrics are between warning and middle limits BABY_MONSTER: if 1 to more metrics are between middle and extreme limits MONSTERS : if 1 to more metrics are in the extreme limits _______________________________________________ Brought to you by : SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory Please visite our web site on your project at : http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html