[GRASS-QA] GRASS QA: mmetz |cindex_rw.c file.c head.c plus.c ...| 32
clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Mon Mar 16 05:55:46 EDT 2009
Hello mmetz,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/lib/vector/diglib/cindex_rw.c
*****************************************************************
Function
dig_read_cidx(Begins at: 253, Ends at:298)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 46 | * | WARNING | 46 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
dig_read_cidx_head(Begins at: 103, Ends at:212)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | ** | BABY-MONSTER | 16 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 22 | * | WARNING | 22 |
LOC: | 110 | ** | BABY-MONSTER | 110 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_write_cidx(Begins at: 215, Ends at:247)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_write_cidx_head(Begins at: 22, Ends at:100)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | ** | BABY-MONSTER | 13 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 19 | * | WARNING | 19 |
LOC: | 79 | * | WARNING | 79 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/diglib/file.c
*****************************************************************
Function
dig_fflush(Begins at: 85, Ends at:93)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_file_free(Begins at: 232, Ends at:239)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_file_init(Begins at: 138, Ends at:147)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_file_load(Begins at: 154, Ends at:226)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 18 | * | WARNING | 18 |
LOC: | 73 | * | WARNING | 73 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
dig_fread(Begins at: 99, Ends at:119)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dig_fseek(Begins at: 47, Ends at:65)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
dig_ftell(Begins at: 35, Ends at:41)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_fwrite(Begins at: 125, Ends at:132)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dig_rewind(Begins at: 71, Ends at:79)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/diglib/head.c
*****************************************************************
Function
dig__read_head(Begins at: 61, Ends at:129)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 69 | * | WARNING | 69 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
dig__write_head(Begins at: 22, Ends at:58)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 37 | | OK | 37 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/diglib/plus.c
*****************************************************************
Function
dig_free_plus(Begins at: 241, Ends at:250)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_free_plus_areas(Begins at: 173, Ends at:200)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 28 | | OK | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dig_free_plus_isles(Begins at: 207, Ends at:232)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_free_plus_lines(Begins at: 137, Ends at:166)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_free_plus_nodes(Begins at: 105, Ends at:130)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_init_plus(Begins at: 31, Ends at:98)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 68 | * | WARNING | 68 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dig_load_plus(Begins at: 262, Ends at:327)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 15 | ** | BABY-MONSTER | 15 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 32 | ** | BABY-MONSTER | 32 |
LOC: | 66 | * | WARNING | 66 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_write_areas(Begins at: 437, Ends at:451)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_write_isles(Begins at: 462, Ends at:476)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_write_lines(Begins at: 412, Ends at:426)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_write_nodes(Begins at: 388, Ends at:401)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_write_plus_file(Begins at: 338, Ends at:377)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 22 | * | WARNING | 22 |
LOC: | 40 | | OK | 40 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Clone analysis:
This file has 12 potentially cloned functions:
dig_write_lines dig_write_isles dig_write_nodes dig_write_lines dig_write_areas dig_write_nodes dig_write_areas dig_write_isles dig_write_lines dig_write_areas dig_write_isles
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c clones of dig_write_areas are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_nodes
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_lines
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_isles
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c clones of dig_write_isles are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_nodes
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_lines
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_areas
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c clones of dig_write_lines are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_nodes
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_areas
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_isles
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c clones of dig_write_nodes are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_lines
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_areas
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus.c dig_write_isles
*****************************************************************
File :grass/trunk/lib/vector/diglib/plus_line.c
*****************************************************************
Function
dig_add_line(Begins at: 31, Ends at:131)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | ** | BABY-MONSTER | 16 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 22 | * | WARNING | 22 |
LOC: | 101 | ** | BABY-MONSTER | 101 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_del_line(Begins at: 148, Ends at:213)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 66 | * | WARNING | 66 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
dig_line_get_area(Begins at: 226, Ends at:246)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dig_line_get_box(Begins at: 308, Ends at:322)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dig_line_set_area(Begins at: 258, Ends at:272)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dig_line_set_box(Begins at: 283, Ends at:297)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 6 potentially cloned functions:
dig_isle_set_box dig_line_set_box dig_area_set_box dig_isle_set_box dig_line_get_box
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus_line.c clones of dig_line_get_box are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus_area.c dig_area_set_box
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus_area.c dig_isle_set_box
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus_line.c dig_line_set_box
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus_line.c clones of dig_line_set_box are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus_area.c dig_area_set_box
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus_area.c dig_isle_set_box
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/plus_line.c dig_line_get_box
*****************************************************************
File :grass/trunk/lib/vector/diglib/plus_struct.c
*****************************************************************
Function
dig_Rd_P_area(Begins at: 335, Ends at:402)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 18 | *** | MONSTER | 18 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 15 | *** | MONSTER | 15 |
LOC: | 68 | ** | BABY-MONSTER | 68 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_Rd_P_isle(Begins at: 458, Ends at:514)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 14 | ** | BABY-MONSTER | 14 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 57 | * | WARNING | 57 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_Rd_P_line(Begins at: 148, Ends at:248)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 27 | ** | BABY-MONSTER | 27 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 21 | * | WARNING | 21 |
LOC: | 101 | * | WARNING | 101 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_Rd_P_node(Begins at: 49, Ends at:101)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | *** | MONSTER | 13 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 53 | ** | BABY-MONSTER | 53 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_Rd_Plus_head(Begins at: 566, Ends at:693)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 33 | ** | BABY-MONSTER | 33 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 41 | * | WARNING | 41 |
LOC: | 128 | * | WARNING | 128 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_Wr_P_area(Begins at: 404, Ends at:456)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 17 | *** | MONSTER | 17 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 12 | ** | BABY-MONSTER | 12 |
LOC: | 53 | ** | BABY-MONSTER | 53 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_Wr_P_isle(Begins at: 516, Ends at:560)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 14 | ** | BABY-MONSTER | 14 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 45 | * | WARNING | 45 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_Wr_P_line(Begins at: 250, Ends at:333)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 27 | ** | BABY-MONSTER | 27 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 21 | * | WARNING | 21 |
LOC: | 84 | * | WARNING | 84 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_Wr_P_node(Begins at: 103, Ends at:146)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | *** | MONSTER | 13 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 44 | * | WARNING | 44 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_Wr_Plus_head(Begins at: 695, Ends at:788)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 31 | ** | BABY-MONSTER | 31 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 34 | * | WARNING | 34 |
LOC: | 94 | * | WARNING | 94 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/diglib/portable.c
*****************************************************************
Function
buf_alloc(Begins at: 47, Ends at:61)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig__byte_order_out(Begins at: 652, Ends at:658)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig__fread_port_C(Begins at: 353, Ends at:361)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dig__fread_port_D(Begins at: 75, Ends at:103)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 29 | | OK | 29 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
dig__fread_port_F(Begins at: 106, Ends at:134)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 29 | | OK | 29 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
dig__fread_port_I(Begins at: 209, Ends at:278)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | ** | BABY-MONSTER | 16 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 14 | * | WARNING | 14 |
LOC: | 70 | * | WARNING | 70 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig__fread_port_L(Begins at: 137, Ends at:206)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | ** | BABY-MONSTER | 16 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 14 | * | WARNING | 14 |
LOC: | 70 | * | WARNING | 70 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig__fread_port_P(Begins at: 365, Ends at:372)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dig__fread_port_S(Begins at: 281, Ends at:350)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 17 | ** | BABY-MONSTER | 17 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 14 | * | WARNING | 14 |
LOC: | 70 | * | WARNING | 70 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig__fwrite_port_C(Begins at: 564, Ends at:571)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dig__fwrite_port_D(Begins at: 376, Ends at:400)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
dig__fwrite_port_F(Begins at: 402, Ends at:426)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
dig__fwrite_port_I(Begins at: 471, Ends at:512)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 42 | * | WARNING | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
dig__fwrite_port_L(Begins at: 428, Ends at:469)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 42 | * | WARNING | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
dig__fwrite_port_P(Begins at: 558, Ends at:562)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dig__fwrite_port_S(Begins at: 514, Ends at:555)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 42 | * | WARNING | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
dig_init_portable(Begins at: 574, Ends at:643)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | ** | BABY-MONSTER | 16 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 70 | * | WARNING | 70 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_set_cur_port(Begins at: 646, Ends at:650)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 10 potentially cloned functions:
dig__fread_port_D dig__fread_port_L dig__fread_port_I dig__fwrite_port_L dig__fwrite_port_S dig__fwrite_port_I dig__fwrite_port_S dig__fwrite_port_L dig__fwrite_port_I
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c clones of dig__fread_port_D are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c dig__fread_port_F
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c clones of dig__fread_port_F are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c dig__fread_port_D
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c clones of dig__fread_port_I are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c dig__fread_port_L
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c clones of dig__fread_port_L are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c dig__fread_port_I
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c clones of dig__fwrite_port_I are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c dig__fwrite_port_L
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c dig__fwrite_port_S
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c clones of dig__fwrite_port_L are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c dig__fwrite_port_I
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c dig__fwrite_port_S
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c clones of dig__fwrite_port_S are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c dig__fwrite_port_L
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/portable.c dig__fwrite_port_I
*****************************************************************
File :grass/trunk/lib/vector/diglib/port_init.c
*****************************************************************
Function
find_offset(Begins at: 102, Ends at:112)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
find_offsets(Begins at: 114, Ends at:146)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
port_init(Begins at: 148, Ends at:188)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 41 | | OK | 41 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/port_init.c clones of find_offset are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/port_test.c find_offset
*****************************************************************
File :grass/trunk/lib/vector/diglib/port_test.c
*****************************************************************
Class
type_conv(Begins at: 63, Ends at:71)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Function
dumpflags(Begins at: 301, Ends at:351)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 20 | * | WARNING | 20 |
LOC: | 51 | * | WARNING | 51 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
find_offset(Begins at: 288, Ends at:298)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
main(Begins at: 97, Ends at:281)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 42 | *** | MONSTER | 42 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 37 | *** | MONSTER | 37 |
LOC: | 185 | *** | MONSTER | 185 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/port_test.c clones of find_offset are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/diglib/port_init.c find_offset
*****************************************************************
File :grass/trunk/lib/vector/diglib/spindex_rw.c
*****************************************************************
Function
dig_Rd_spindx_head(Begins at: 79, Ends at:162)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 14 | ** | BABY-MONSTER | 14 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 22 | * | WARNING | 22 |
LOC: | 84 | * | WARNING | 84 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
dig_Wr_spindx_head(Begins at: 23, Ends at:76)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 54 | * | WARNING | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
dig_dump_spidx(Begins at: 383, Ends at:399)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
dig_read_spidx(Begins at: 356, Ends at:380)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 13 | * | WARNING | 13 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dig_write_spidx(Begins at: 330, Ends at:353)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 13 | * | WARNING | 13 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
rtree_dump_branch(Begins at: 167, Ends at:183)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
rtree_dump_node(Begins at: 186, Ends at:205)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
rtree_read_branch(Begins at: 268, Ends at:302)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 35 | | OK | 35 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
rtree_read_node(Begins at: 305, Ends at:327)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 23 | | OK | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
rtree_write_branch(Begins at: 210, Ends at:237)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 28 | | OK | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
rtree_write_node(Begins at: 240, Ends at:263)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/diglib/test.c
*****************************************************************
Function
main(Begins at: 28, Ends at:163)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 15 | ** | BABY-MONSTER | 15 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 53 | *** | MONSTER | 53 |
LOC: | 136 | ** | BABY-MONSTER | 136 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/break_lines.c
*****************************************************************
Function
Vect_break_lines(Begins at: 36, Ends at:43)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Vect_break_lines_list(Begins at: 68, Ends at:392)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 56 | *** | MONSTER | 56 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 75 | *** | MONSTER | 75 |
LOC: | 325 | *** | MONSTER | 325 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/break_polygons.c
*****************************************************************
Function
Vect_break_polygons(Begins at: 62, Ends at:352)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 37 | | OK | 37 |
ParamNBR: | 4 | | OK | 4 |
CalledNBR: | 66 | | OK | 66 |
LOC: | 291 | | OK | 291 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
srch(Begins at: 39, Ends at:42)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | *** | MONSTER | 1 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 0 | *** | MONSTER | 0 |
LOC: | 4 | *** | MONSTER | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/bridges.c
*****************************************************************
Function
Vect_chtype_bridges(Begins at: 67, Ends at:71)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | ** | BABY-MONSTER | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | *** | MONSTER | 1 |
LOC: | 5 | ** | BABY-MONSTER | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_remove_bridges(Begins at: 45, Ends at:49)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
remove_bridges(Begins at: 86, Ends at:212)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | | OK | 19 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 40 | | OK | 40 |
LOC: | 127 | | OK | 127 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/build_nat.c
*****************************************************************
Function
Vect_attach_centroids(Begins at: 332, Ends at:413)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 82 | * | WARNING | 82 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Vect_attach_isle(Begins at: 261, Ends at:288)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 28 | | OK | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_attach_isles(Begins at: 298, Ends at:322)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_build_line_area(Begins at: 40, Ends at:118)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 26 | ** | BABY-MONSTER | 26 |
LOC: | 79 | * | WARNING | 79 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_build_nat(Begins at: 425, Ends at:677)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 42 | *** | MONSTER | 42 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 59 | *** | MONSTER | 59 |
LOC: | 253 | *** | MONSTER | 253 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_isle_find_area(Begins at: 129, Ends at:251)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 27 | ** | BABY-MONSTER | 27 |
LOC: | 123 | ** | BABY-MONSTER | 123 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/clean_nodes.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/lib/vector/Vlib/dangles.c
*****************************************************************
Function
Vect_chtype_dangles(Begins at: 81, Ends at:86)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | *** | MONSTER | 1 |
ParamNBR: | 4 | ** | BABY-MONSTER | 4 |
CalledNBR: | 1 | *** | MONSTER | 1 |
LOC: | 6 | *** | MONSTER | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_remove_dangles(Begins at: 54, Ends at:59)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Vect_select_dangles(Begins at: 106, Ends at:111)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
dangles(Begins at: 132, Ends at:288)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 25 | | OK | 25 |
ParamNBR: | 7 | * | WARNING | 7 |
CalledNBR: | 45 | | OK | 45 |
LOC: | 157 | | OK | 157 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/map.c
*****************************************************************
Function
Vect_copy(Begins at: 156, Ends at:285)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 15 | * | WARNING | 15 |
ParamNBR: | 4 | | OK | 4 |
CalledNBR: | 60 | | OK | 60 |
LOC: | 130 | | OK | 130 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Vect_copy_map_lines(Begins at: 44, Ends at:99)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | ** | BABY-MONSTER | 10 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 20 | *** | MONSTER | 20 |
LOC: | 56 | ** | BABY-MONSTER | 56 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_copy_table(Begins at: 644, Ends at:650)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | * | WARNING | 1 |
ParamNBR: | 6 | | OK | 6 |
CalledNBR: | 1 | * | WARNING | 1 |
LOC: | 7 | * | WARNING | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Vect_copy_table_by_cats(Begins at: 667, Ends at:720)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 13 | | OK | 13 |
LOC: | 54 | | OK | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_copy_tables(Begins at: 567, Ends at:629)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 22 | * | WARNING | 22 |
LOC: | 63 | * | WARNING | 63 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
Vect_delete(Begins at: 430, Ends at:553)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | * | WARNING | 16 |
ParamNBR: | 1 | ** | BABY-MONSTER | 1 |
CalledNBR: | 62 | * | WARNING | 62 |
LOC: | 124 | * | WARNING | 124 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_rename(Begins at: 302, Ends at:420)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 14 | ** | BABY-MONSTER | 14 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 50 | *** | MONSTER | 50 |
LOC: | 119 | ** | BABY-MONSTER | 119 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_set_category_index_update(Begins at: 746, Ends at:749)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | ** | BABY-MONSTER | 1 |
ParamNBR: | 1 | * | WARNING | 1 |
CalledNBR: | 0 | *** | MONSTER | 0 |
LOC: | 4 | ** | BABY-MONSTER | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_set_release_support(Begins at: 731, Ends at:734)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
copy_file(Begins at: 110, Ends at:141)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 32 | | OK | 32 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/open.c
*****************************************************************
Function
Vect__open_old(Begins at: 124, Ends at:396)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 31 | | OK | 31 |
ParamNBR: | 5 | | OK | 5 |
CalledNBR: | 102 | | OK | 102 |
LOC: | 273 | | OK | 273 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_coor_info(Begins at: 608, Ends at:646)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | *** | MONSTER | 6 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 11 | *** | MONSTER | 11 |
LOC: | 39 | *** | MONSTER | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_maptype_info(Begins at: 656, Ends at:673)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | * | WARNING | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 4 | * | WARNING | 4 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Vect_open_new(Begins at: 514, Ends at:597)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | | OK | 8 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 43 | | OK | 43 |
LOC: | 84 | | OK | 84 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_open_old(Begins at: 410, Ends at:413)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | * | WARNING | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | *** | MONSTER | 1 |
LOC: | 4 | * | WARNING | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_open_old_head(Begins at: 464, Ends at:468)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Vect_open_spatial_index(Begins at: 767, Ends at:832)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | * | WARNING | 1 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 66 | | OK | 66 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Vect_open_topo(Begins at: 686, Ends at:757)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 16 | | OK | 16 |
LOC: | 72 | * | WARNING | 72 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Vect_open_update(Begins at: 427, Ends at:449)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | * | WARNING | 2 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 2 | * | WARNING | 2 |
LOC: | 23 | * | WARNING | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Vect_open_update_head(Begins at: 482, Ends at:502)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Vect_set_open_level(Begins at: 96, Ends at:107)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | * | WARNING | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
fatal_error(Begins at: 59, Ends at:71)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
format(Begins at: 38, Ends at:42)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
open_old_dummy(Begins at: 32, Ends at:35)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/open_nat.c
*****************************************************************
Function
V1_open_new_nat(Begins at: 86, Ends at:131)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 17 | | OK | 17 |
LOC: | 46 | | OK | 46 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
V1_open_old_nat(Begins at: 43, Ends at:73)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 9 | * | WARNING | 9 |
LOC: | 31 | * | WARNING | 31 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
check_coor(Begins at: 134, Ends at:153)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/read.c
*****************************************************************
Function
Vect_area_alive(Begins at: 155, Ends at:161)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_isle_alive(Begins at: 172, Ends at:178)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_line_alive(Begins at: 121, Ends at:127)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_node_alive(Begins at: 138, Ends at:144)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_read_line(Begins at: 95, Ends at:110)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | | OK | 4 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_read_next_line(Begins at: 70, Ends at:82)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
format(Begins at: 30, Ends at:34)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | * | WARNING | 0 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
read_next_dummy(Begins at: 24, Ends at:27)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | * | WARNING | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/read_nat.c
*****************************************************************
Function
V1_read_line_nat(Begins at: 47, Ends at:53)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
V1_read_next_line_nat(Begins at: 67, Ends at:108)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 42 | * | WARNING | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
V2_read_line_nat(Begins at: 123, Ends at:139)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
V2_read_next_line_nat(Begins at: 153, Ends at:195)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 43 | * | WARNING | 43 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Vect__Read_line_nat(Begins at: 211, Ends at:342)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 29 | *** | MONSTER | 29 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 23 | ** | BABY-MONSTER | 23 |
LOC: | 132 | ** | BABY-MONSTER | 132 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/remove_areas.c
*****************************************************************
Function
Vect_remove_small_areas(Begins at: 39, Ends at:190)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 23 | *** | MONSTER | 23 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 45 | *** | MONSTER | 45 |
LOC: | 152 | *** | MONSTER | 152 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/remove_duplicates.c
*****************************************************************
Function
Vect_line_check_duplicate(Begins at: 141, Ends at:179)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Vect_remove_duplicates(Begins at: 38, Ends at:130)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | ** | BABY-MONSTER | 13 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 30 | ** | BABY-MONSTER | 30 |
LOC: | 93 | ** | BABY-MONSTER | 93 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/write.c
*****************************************************************
Function
Vect_delete_line(Begins at: 205, Ends at:236)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 32 | | OK | 32 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_rewrite_line(Begins at: 145, Ends at:171)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 5 | | OK | 5 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 27 | | OK | 27 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Vect_write_line(Begins at: 99, Ends at:125)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 4 | | OK | 4 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 27 | | OK | 27 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
delete_dummy(Begins at: 36, Ends at:41)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
format(Begins at: 44, Ends at:48)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | * | WARNING | 0 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 5 | | OK | 5 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
rewrite_dummy(Begins at: 30, Ends at:35)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | * | WARNING | 0 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
write_dummy(Begins at: 24, Ends at:29)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/vector/Vlib/write_nat.c
*****************************************************************
Function
V1__rewrite_line_nat(Begins at: 444, Ends at:531)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 21 | | OK | 21 |
ParamNBR: | 5 | | OK | 5 |
CalledNBR: | 14 | | OK | 14 |
LOC: | 88 | | OK | 88 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
V1_delete_line_nat(Begins at: 542, Ends at:571)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
V1_rewrite_line_nat(Begins at: 354, Ends at:399)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | * | WARNING | 5 |
ParamNBR: | 5 | | OK | 5 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 46 | | OK | 46 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
V1_write_line_nat(Begins at: 97, Ends at:111)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 15 | * | WARNING | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
V2_delete_line_nat(Begins at: 582, Ends at:770)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 35 | | OK | 35 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 45 | | OK | 45 |
LOC: | 189 | | OK | 189 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
V2_rewrite_line_nat(Begins at: 415, Ends at:430)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | *** | MONSTER | 1 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 2 | * | WARNING | 2 |
LOC: | 16 | * | WARNING | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
V2_write_line_nat(Begins at: 124, Ends at:332)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 37 | *** | MONSTER | 37 |
ParamNBR: | 4 | | OK | 4 |
CalledNBR: | 41 | *** | MONSTER | 41 |
LOC: | 209 | *** | MONSTER | 209 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
add_area_cats_to_cidx(Begins at: 56, Ends at:81)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
delete_area_cats_from_cidx(Begins at: 29, Ends at:54)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | *** | MONSTER | 5 |
ParamNBR: | 2 | * | WARNING | 2 |
CalledNBR: | 6 | *** | MONSTER | 6 |
LOC: | 26 | *** | MONSTER | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 2 potentially cloned functions:
add_area_cats_to_cidx
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/write_nat.c clones of add_area_cats_to_cidx are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/write_nat.c delete_area_cats_from_cidx
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/write_nat.c clones of delete_area_cats_from_cidx are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/write_nat.c add_area_cats_to_cidx
____________________________________________
Threshold grass key metrics values at Mon Mar 16 05:03:37 EST 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list