[GRASS-QA] GRASS QA: |raster.c lidar.h zones.c InterpSpline.c | 22 clones | 8 monsters |13 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Thu May 20 16:04:46 EDT 2010


Hello ,

here's a report on your recent grass-SVN change for the revision : 42317 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/lib/lidar/raster.c
*****************************************************************

          Function
P_Regular_Points(Begins at: 190, Ends at:308)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      23 |     * |      WARNING |        23 |
ParamNBR:     |      15 |   *** |      MONSTER |        15 |
CalledNBR:    |       6 |       |           OK |         6 |
LOC:          |     119 |     * |      WARNING |       119 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


P_Sparse_Points(Begins at: 8, Ends at:186)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      24 |    ** | BABY-MONSTER |        24 |
ParamNBR:     |      18 |   *** |      MONSTER |        18 |
CalledNBR:    |      72 |    ** | BABY-MONSTER |        72 |
LOC:          |     179 |     * |      WARNING |       179 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file has 2 potentially cloned functions:
  P_Sparse_Points

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/raster.c clones of P_Regular_Points are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/raster.c  P_Regular_Points

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/raster.c clones of P_Sparse_Points are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/raster.c  P_Sparse_Points

*****************************************************************
          File :/lib/lidar/lidar.h
*****************************************************************

          Class
Point(Begins at: 79, Ends at:86)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |        |        |        |        |        |        |
+------------+--------+--------+--------+--------+--------+--------+



          Class
Reg_dimens(Begins at: 70, Ends at:77)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |        |        |        |        |        |        |
+------------+--------+--------+--------+--------+--------+--------+



          Class
element(Begins at: 88, Ends at:93)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |        |        |        |        |        |        |
+------------+--------+--------+--------+--------+--------+--------+



Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/lidar/zones.c
*****************************************************************

          Function
P_Aux_to_Raster(Begins at: 546, Ends at:571)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      12 |       |           OK |        12 |
LOC:          |      26 |       |           OK |        26 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


P_Aux_to_Vector(Begins at: 574, Ends at:646)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |       |           OK |         6 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      33 |     * |      WARNING |        33 |
LOC:          |      73 |       |           OK |        73 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


P_Create_Aux2_Table(Begins at: 469, Ends at:495)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      14 |       |           OK |        14 |
LOC:          |      27 |       |           OK |        27 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


P_Create_Aux4_Table(Begins at: 498, Ends at:532)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      20 |       |           OK |        20 |
LOC:          |      35 |       |           OK |        35 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


P_Drop_Aux_Table(Begins at: 535, Ends at:543)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |       9 |       |           OK |         9 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


P_Mean_Calc(Begins at: 232, Ends at:258)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      27 |       |           OK |        27 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


P_Read_Raster_Region_Map(Begins at: 387, Ends at:466)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      80 |     * |      WARNING |        80 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


P_Read_Vector_Region_Map(Begins at: 320, Ends at:385)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |       |           OK |         6 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      13 |       |           OK |        13 |
LOC:          |      66 |       |           OK |        66 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


P_estimate_splinestep(Begins at: 260, Ends at:318)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      11 |     * |      WARNING |        11 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      59 |       |           OK |        59 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


P_get_BandWidth(Begins at: 219, Ends at:229)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      11 |       |           OK |        11 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


P_get_edge(Begins at: 198, Ends at:216)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      19 |       |           OK |        19 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


P_set_dim(Begins at: 118, Ends at:195)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      11 |     * |      WARNING |        11 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      15 |       |           OK |        15 |
LOC:          |      78 |       |           OK |        78 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


P_set_regions(Begins at: 52, Ends at:115)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |       |           OK |         8 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      64 |       |           OK |        64 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


P_zero_dim(Begins at: 8, Ends at:16)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |       9 |       |           OK |         9 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 12 potentially cloned functions:
  P_Aux_to_Vector  P_Create_Aux2_Table  P_Create_Aux4_Table  P_Mean_Calc  P_Read_Raster_Region_Map  P_Read_Vector_Region_Map  P_estimate_splinestep  P_get_BandWidth  P_get_edge  P_set_dim  P_set_regions

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_Aux_to_Raster are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c  P_Aux_to_Raster

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_Aux_to_Vector are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c  P_Aux_to_Vector

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_Create_Aux2_Table are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c  P_Create_Aux2_Table

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_Create_Aux4_Table are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c  P_Create_Aux4_Table

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_Mean_Calc are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c  P_Mean_Calc

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_Read_Raster_Region_Map are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c  P_Read_Raster_Region_Map

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_Read_Vector_Region_Map are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c  P_Read_Vector_Region_Map

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_estimate_splinestep are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c  P_estimate_splinestep

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_get_BandWidth are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c  P_get_BandWidth

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_get_edge are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c  P_get_edge

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_set_dim are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c  P_set_dim

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/zones.c clones of P_set_regions are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/zones.c  P_set_regions

*****************************************************************
          File :/lib/lidar/InterpSpline.c
*****************************************************************

          Function
dataInterpolateBicubic(Begins at: 533, Ends at:589)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |      19 |       |           OK |        19 |
LOC:          |      57 |       |           OK |        57 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


dataInterpolateBilin(Begins at: 644, Ends at:683)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      40 |       |           OK |        40 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


nCorrectGrad(Begins at: 432, Ends at:462)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      31 |       |           OK |        31 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


nCorrectLapl(Begins at: 211, Ends at:308)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      11 |     * |      WARNING |        11 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      98 |     * |      WARNING |        98 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


node_x(Begins at: 30, Ends at:37)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |       8 |       |           OK |         8 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


node_y(Begins at: 42, Ends at:49)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |       8 |       |           OK |         8 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


normalDefBicubic(Begins at: 108, Ends at:205)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |      13 |   *** |      MONSTER |        13 |
CalledNBR:    |      22 |     * |      WARNING |        22 |
LOC:          |      98 |     * |      WARNING |        98 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


normalDefBilin(Begins at: 313, Ends at:393)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |      13 |   *** |      MONSTER |        13 |
CalledNBR:    |      10 |       |           OK |        10 |
LOC:          |      81 |     * |      WARNING |        81 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


obsEstimateBicubic(Begins at: 467, Ends at:527)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |       |           OK |         6 |
ParamNBR:     |      10 |   *** |      MONSTER |        10 |
CalledNBR:    |      19 |       |           OK |        19 |
LOC:          |      61 |       |           OK |        61 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


obsEstimateBilin(Begins at: 595, Ends at:638)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |       |           OK |         6 |
ParamNBR:     |      10 |   *** |      MONSTER |        10 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      44 |       |           OK |        44 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


order(Begins at: 54, Ends at:58)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


phi(Begins at: 99, Ends at:103)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


phi_3(Begins at: 63, Ends at:67)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


phi_33(Begins at: 75, Ends at:79)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


phi_34(Begins at: 81, Ends at:85)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


phi_4(Begins at: 69, Ends at:73)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


phi_43(Begins at: 87, Ends at:91)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


phi_44(Begins at: 93, Ends at:97)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       5 |       |           OK |         5 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 8 potentially cloned functions:
  dataInterpolateBilin  nCorrectGrad  nCorrectLapl  normalDefBicubic  normalDefBilin  obsEstimateBicubic  obsEstimateBilin

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/InterpSpline.c clones of dataInterpolateBicubic are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/InterpSpline.c  dataInterpolateBicubic

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/InterpSpline.c clones of dataInterpolateBilin are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/InterpSpline.c  dataInterpolateBilin

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/InterpSpline.c clones of nCorrectGrad are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/InterpSpline.c  nCorrectGrad

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/InterpSpline.c clones of nCorrectLapl are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/InterpSpline.c  nCorrectLapl

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/InterpSpline.c clones of normalDefBicubic are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/InterpSpline.c  normalDefBicubic

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/InterpSpline.c clones of normalDefBilin are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/InterpSpline.c  normalDefBilin

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/InterpSpline.c clones of obsEstimateBicubic are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/InterpSpline.c  obsEstimateBicubic

In /data/project-manager/grass/grassSVN/grass/trunk/lib/lidar/InterpSpline.c clones of obsEstimateBilin are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/lidarlib/InterpSpline.c  obsEstimateBilin

____________________________________________


Threshold grass key metrics values at Thu May 20 16:04:34 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |        11 |        24 |        38 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        22 |        52 |        82 |
LOC:                  |        79 |       181 |       283 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list