[GRASS-QA] GRASS QA: martinl |main.cpp 6s.cpp | no clones | 1
monsters |1 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Mon Nov 29 15:08:53 EST 2010
Hello martinl,
here's a report on your recent grass-SVN change for the revision : 44251
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/imagery/i.atcorr/main.cpp
*****************************************************************
Class
IntPair(Begins at: 218, Ends at:232)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 5 | 2 | 0 | 1 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 5 | 2 | 0 | 1 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Options(Begins at: 48, Ends at:67)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
Position(Begins at: 187, Ends at:193)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 2 | 2 | 0 | 1 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 2 | 2 | 0 | 1 |
+------------+--------+--------+--------+--------+--------+--------+
Class
ScaleRange(Begins at: 69, Ends at:73)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
TICache(Begins at: 129, Ends at:161)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 8 | 4 | 0 | 2 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 8 | 4 | 0 | 2 |
+------------+--------+--------+--------+--------+--------+--------+
Class
TIMap(Begins at: 173, Ends at:215)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 8 | 7 | 0 | 4 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 8 | 7 | 0 | 4 |
+------------+--------+--------+--------+--------+--------+--------+
Function
process_raster(Begins at: 275, Ends at:408)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 21 | ** | BABY-MONSTER | 21 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 41 | * | WARNING | 41 |
LOC: | 134 | * | WARNING | 134 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/imagery/i.atcorr/6s.cpp
*****************************************************************
Function
printOutput(Begins at: 157, Ends at:244)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 52 | ** | BABY-MONSTER | 52 |
LOC: | 88 | * | WARNING | 88 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Mon Nov 29 15:08:40 EST 2010 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 19 | 30 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 18 | 43 | 69 |
LOC: | 67 | 152 | 237 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list