[GRASS-QA] GRASS QA: hamish |tools.c main.c algorithm.c | no clones | 0 monsters |3 warnings

[soccerlab.info at gmail.com]

Hello hamish,

here's a report on your recent grass-SVN change for the revision : 43432 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/imagery/i.landsat.acca/tools.c
*****************************************************************

          Function
mean(Begins at: 40, Ends at:56)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      17 |       |           OK |        17 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/imagery/i.landsat.acca/main.c
*****************************************************************

          Function
main(Begins at: 89, Ends at:206)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |       |           OK |         8 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      42 |     * |      WARNING |        42 |
LOC:          |     118 |     * |      WARNING |       118 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/imagery/i.landsat.acca/algorithm.c
*****************************************************************

          Function
acca_first(Begins at: 210, Ends at:347)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      23 |    ** | BABY-MONSTER |        23 |
ParamNBR:     |       8 |    ** | BABY-MONSTER |         8 |
CalledNBR:    |      21 |     * |      WARNING |        21 |
LOC:          |     138 |     * |      WARNING |       138 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


acca_second(Begins at: 350, Ends at:457)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |     * |      WARNING |        16 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |      42 |     * |      WARNING |        42 |
LOC:          |     108 |     * |      WARNING |       108 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Thu Sep 09 03:53:29 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        19 |        30 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        18 |        43 |        69 |
LOC:                  |        66 |       149 |       233 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html