[GRASS-QA] GRASS QA: huhabla |observation_points.c utils.c
waterglobs.h hydro.c ...| 35 clones | 4 monsters |12 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Tue Mar 15 06:19:26 EDT 2011
Hello huhabla,
here's a report on your recent grass-SVN change for the revision : 45670
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/raster/simwe/simlib/observation_points.c
*****************************************************************
Function
create_observation_points(Begins at: 14, Ends at:95)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | * | WARNING | 13 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 21 | * | WARNING | 21 |
LOC: | 82 | * | WARNING | 82 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
init_points(Begins at: 99, Ends at:108)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
insert_next_point(Begins at: 122, Ends at:133)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
realloc_points(Begins at: 112, Ends at:118)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/simwe/simlib/utils.c
*****************************************************************
Function
amax1(Begins at: 5, Ends at:17)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
amin1(Begins at: 19, Ends at:31)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
max(Begins at: 47, Ends at:59)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
min(Begins at: 33, Ends at:45)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 28 potentially cloned functions:
min max amax1 amin1 min max amax1 min max amax1 amin1 min max amax1 amin1 min amax1 amin1 min max amax1 amin1 max amax1 amin1 min max
In /data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c clones of amax1 are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c amin1
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c min
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c max
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c amax1
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c amin1
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c min
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c max
In /data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c clones of amin1 are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c amax1
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c min
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c max
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c amax1
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c amin1
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c min
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c max
In /data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c clones of max are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c amax1
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c amin1
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c min
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c amax1
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c amin1
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c min
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c max
In /data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c clones of min are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c amax1
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c amin1
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/utils.c max
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c amax1
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c amin1
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c min
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c max
*****************************************************************
File :/raster/simwe/simlib/waterglobs.h
*****************************************************************
Class
_points(Begins at: 68, Ends at:77)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | | | | | | |
+------------+--------+--------+--------+--------+--------+--------+
Class
flags(Begins at: 51, Ends at:54)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
options(Begins at: 40, Ends at:47)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
seed(Begins at: 58, Ends at:61)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/simwe/simlib/hydro.c
*****************************************************************
Function
main_loop(Begins at: 120, Ends at:467)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 43 | *** | MONSTER | 43 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 38 | ** | BABY-MONSTER | 38 |
LOC: | 348 | *** | MONSTER | 348 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/simwe/simlib/output.c
*****************************************************************
Function
output_data(Begins at: 72, Ends at:594)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 72 | *** | MONSTER | 72 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 174 | *** | MONSTER | 174 |
LOC: | 523 | *** | MONSTER | 523 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
output_et(Begins at: 597, Ends at:738)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 17 | * | WARNING | 17 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 33 | * | WARNING | 33 |
LOC: | 142 | * | WARNING | 142 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
output_walker_as_vector(Begins at: 21, Ends at:68)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 48 | | OK | 48 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/simwe/r.sim.sediment/main.c
*****************************************************************
Function
main(Begins at: 101, Ends at:390)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 100 | *** | MONSTER | 100 |
LOC: | 290 | *** | MONSTER | 290 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/simwe/r.sim.water/main.c
*****************************************************************
Function
main(Begins at: 99, Ends at:480)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | * | WARNING | 19 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 118 | *** | MONSTER | 118 |
LOC: | 382 | *** | MONSTER | 382 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/raster/simwe/simlib/input.c
*****************************************************************
Function
copy_matrix_undef_double_to_float_values(Begins at: 344, Ends at:354)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
copy_matrix_undef_float_values(Begins at: 358, Ends at:368)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
create_double_matrix(Begins at: 391, Ends at:406)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
create_float_matrix(Begins at: 372, Ends at:387)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
grad_check(Begins at: 125, Ends at:340)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 31 | ** | BABY-MONSTER | 31 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 47 | ** | BABY-MONSTER | 47 |
LOC: | 216 | ** | BABY-MONSTER | 216 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
input_data(Begins at: 34, Ends at:120)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | * | WARNING | 13 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 29 | * | WARNING | 29 |
LOC: | 87 | * | WARNING | 87 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
read_double_raster_map(Begins at: 453, Ends at:492)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 40 | | OK | 40 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
read_float_raster_map(Begins at: 410, Ends at:449)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 40 | | OK | 40 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 7 potentially cloned functions:
copy_matrix_undef_double_to_float_values create_float_matrix create_double_matrix grad_check read_float_raster_map read_double_raster_map
In /data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c clones of copy_matrix_undef_double_to_float_values are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c copy_matrix_undef_float_values
In /data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c clones of copy_matrix_undef_float_values are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c copy_matrix_undef_double_to_float_values
In /data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c clones of create_double_matrix are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c create_float_matrix
In /data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c clones of create_float_matrix are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c create_double_matrix
In /data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c clones of grad_check are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c grad_check
In /data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c clones of read_double_raster_map are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c read_float_raster_map
In /data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c clones of read_float_raster_map are:
/data/project-manager/grass/grassSVN/grass/trunk/raster/simwe/simlib/input.c read_double_raster_map
____________________________________________
Threshold grass key metrics values at Tue Mar 15 06:19:22 EDT 2011 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 21 | 33 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 16 | 38 | 61 |
LOC: | 64 | 145 | 226 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list