i.rectify BUGFIX !!

[Luca Palmeri]

Hello all,
               I've found the bug in i.rectify for GRASS 5b2. The bug is in the
routine
write_map, in the source file write.c. I do not know if there is a bugfixes site
or any standard procedure to report bugs and to submit bugfixes. Anyhow here
attached you can find a correct version of the file write.c. To fix the i.rectify
module copy this file in $GRASS_SRC/src/imaging/i.rectify/ and recompile the
module.
Incidentally I report that I found some problems in the i.points3 module. It seems
that
it is not possible to set the GCPs.
bye
LP



-------------- next part --------------
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include "global.h"

/********************************************
  file write.c - Bugfix by Luca Palmeri
                 lpalmeri at ux1.unipd.it
                           13 Aug 1999  
*********************************************/

int write_matrix (int row, int col)
{
    int n;
    long offset;

    select_target_env();
    if(!temp_fd) 
    {
	temp_name = G_tempfile();
	temp_fd = creat(temp_name,0660);
    }
    for (n=0; n < matrix_rows; n++)
    {
	offset = (row++ * target_window.cols + col) * G_raster_size(map_type);
	lseek(temp_fd,offset,0);

	if(write(temp_fd,cell_buf[n],G_raster_size(map_type)*matrix_cols) 
				!= G_raster_size(map_type)*matrix_cols)
	{
	   unlink(temp_name);
	   G_fatal_error("error while writing to temp file");
        }
	/*G_put_map_row_random (outfd, cell_buf[n], row++, col, matrix_cols);*/
    }
    select_current_env();

    return 0;
}

int write_map(char *name)
{
   int fd, row;
   char buf[100];
   void *rast;
   

   rast = G_allocate_raster_buf(map_type);
   close(temp_fd);
   temp_fd = open(temp_name,0);
   fd = G_open_raster_new(name,map_type);

   if(fd <=0)
   {
       sprintf(buf, "Can't open map %s\n", name);
       G_fatal_error(buf);
   }

   for(row = 0; row < target_window.rows; row++)
   {
       /* BUGFIX: Removed semi-column at the end of line */
       if(read(temp_fd,rast,target_window.cols * G_raster_size(map_type))
		    != target_window.cols * G_raster_size(map_type)) 
       {
         /* BUGFIX: printf substituted with sprintf */
	 sprintf(buf, "error writing row %d\n", row);
	  G_fatal_error(buf);
       }
       if(G_put_raster_row(fd,rast, map_type) < 0)
       {
	  G_fatal_error("error while writing to raster file");
	  unlink(temp_name);
       }
   }
   /* BUGFIX: next three lines moved after the } */
   close(temp_fd);
   unlink(temp_name);
   G_close_cell(fd);

   return 0;
}