<div dir="ltr"><div>Hi All,</div><div><br></div><div>Added the patch please test it and let me know. r.drain(drain.c) now uses gmath lib for storing elevation data as matrix. </div><div>Also a problem i found is outmap is always of type CELL</div>
<div><br></div><div>Will these be a problem?<br></div><div><br></div><div>[0] <a href="http://trac.osgeo.org/grass/attachment/ticket/1840/r.drain.diff">http://trac.osgeo.org/grass/attachment/ticket/1840/r.drain.diff</a></div>
<div style>[1] <a href="http://trac.osgeo.org/grass/attachment/ticket/1840/drain.c">http://trac.osgeo.org/grass/attachment/ticket/1840/drain.c</a></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Dec 23, 2012 at 11:51 PM, Mohammed Rashad <span dir="ltr"><<a href="mailto:mohammedrashadkm@gmail.com" target="_blank">mohammedrashadkm@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div class="h5">On Sun, Dec 23, 2012 at 10:54 PM, Markus Neteler <span dir="ltr"><<a href="mailto:neteler@osgeo.org" target="_blank">neteler@osgeo.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div>
On Sat, Dec 22, 2012 at 10:30 PM, Mohammed Rashad<br>
<<a href="mailto:mohammedrashadkm@gmail.com" target="_blank">mohammedrashadkm@gmail.com</a>> wrote:<br>
> Hi,<br>
><br>
> I made some modifications to the r.drain code (direction part) which gave me<br>
> the following output?<br>
><br>
> Is this correct?. If so I can finish polishing it ;)<br>
><br>
> Please see the attachments in the ticket[0]<br>
><br>
> [0] <a href="http://trac.osgeo.org/grass/ticket/1840" target="_blank">http://trac.osgeo.org/grass/ticket/1840</a><br>
><br>
> input<br>
> <a href="http://trac.osgeo.org/grass/attachment/ticket/1840/d.rast.num_input.png" target="_blank">http://trac.osgeo.org/grass/attachment/ticket/1840/d.rast.num_input.png</a><br>
><br>
> output<br>
> <a href="http://trac.osgeo.org/grass/attachment/ticket/1840/d.rast.output.png" target="_blank">http://trac.osgeo.org/grass/attachment/ticket/1840/d.rast.output.png</a><br>
> <a href="http://trac.osgeo.org/grass/attachment/ticket/1840/d.rast.rum.output.png" target="_blank">http://trac.osgeo.org/grass/attachment/ticket/1840/d.rast.rum.output.png</a><br>
<br>
</div>Nice, this looks now pretty similar to<br>
<a href="http://grass.osgeo.org/grass64/manuals/r.drain.html" target="_blank">http://grass.osgeo.org/grass64/manuals/r.drain.html</a><br>
<br>
Please upload the diff then, thanks!<br>
<br>
Unrelated: I wonder about the shift of grid and pixels in the wxGUI, shouldn't<br>
they overlap?<br></blockquote><div><br></div></div></div><div>Yes, you are right. There is a shit. I was trying something and that output came up yesterday. Just now I completed r.drain and output looks pretty good.</div>
<div><br></div>
<div><br></div><div>r.drain direction map generation code is completely wrong Or is not working for a long period when I checked trac last update was 3 years ago for filldir.c which i guess is incomplete</div><div><br></div>
<div><b>Anyone got good output recently with r.drain?</b></div><div><b><br></b></div><div>If so please let me know the revision.</div><div><br></div><div>@Markus</div><div>Can I continue fixing r.drain?</div><div>Because currently its works for -c flag which is by default?</div>
<div>please see new screenshot [0]</div><div><br></div><div>@Margherita Di Leo</div><div>Could you provide your data for testing r.drain module directon calculation feeding points from vector?</div><div><br></div><div><br>
</div><div>[0] <a href="http://lsi.iiit.ac.in/new_r.drain_output.png" target="_blank">http://lsi.iiit.ac.in/new_r.drain_output.png</a></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span><font color="#888888"><br>
Markus<span class="HOEnZb"><font color="#888888"><br>
</font></span></font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div><font face="arial, helvetica, sans-serif">Regards,<br> Rashad</font></div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div><font face="arial, helvetica, sans-serif">Regards,<br> Rashad</font></div>
</div>