<table cellspacing="0" cellpadding="0" border="0" ><tr><td valign="top" style="font: inherit;">Hi,<br><br>missing function definitions added in svn with r55235 & now it builds. I'll leave the other compiler warnings for the authors to look at ...<br><br><br>Hamish<br><br><br>--- On <b>Tue, 2/26/13, Moskovitz, Bob@DOC <i><Bob.Moskovitz@conservation.ca.gov></i></b> wrote:<br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;"><br>From: Moskovitz, Bob@DOC <Bob.Moskovitz@conservation.ca.gov><br>Subject: Re: [GRASS-user] Geomorphons and extension manager<br>To: "Robert Andrew Brown" <brown782@purdue.edu>, "grass-user@lists.osgeo.org" <grass-user@lists.osgeo.org><br>Cc: "Phillip Owens" <prowens@purdue.edu>, "jarekj@amu.edu.pl" <jarekj@amu.edu.pl><br>Date: Tuesday, February 26, 2013, 3:38 PM<br><br><div id="yiv1863614159">
<style><!--
#yiv1863614159
_filtered #yiv1863614159 {font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
_filtered #yiv1863614159 {font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
_filtered #yiv1863614159 {font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
_filtered #yiv1863614159 {font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
#yiv1863614159
#yiv1863614159 p.yiv1863614159MsoNormal, #yiv1863614159 li.yiv1863614159MsoNormal, #yiv1863614159 div.yiv1863614159MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman", "serif";}
#yiv1863614159 a:link, #yiv1863614159 span.yiv1863614159MsoHyperlink
{
color:blue;
text-decoration:underline;}
#yiv1863614159 a:visited, #yiv1863614159 span.yiv1863614159MsoHyperlinkFollowed
{
color:purple;
text-decoration:underline;}
#yiv1863614159 pre
{
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
#yiv1863614159 p.yiv1863614159MsoAcetate, #yiv1863614159 li.yiv1863614159MsoAcetate, #yiv1863614159 div.yiv1863614159MsoAcetate
{
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma", "sans-serif";}
#yiv1863614159 span.yiv1863614159BalloonTextChar
{
font-family:"Tahoma", "sans-serif";}
#yiv1863614159 span.yiv1863614159EmailStyle19
{
font-family:"Calibri", "sans-serif";
color:#1F497D;}
#yiv1863614159 span.yiv1863614159HTMLPreformattedChar
{
font-family:"Courier New";}
#yiv1863614159 .yiv1863614159MsoChpDefault
{
font-size:10.0pt;}
_filtered #yiv1863614159 {
margin:1.0in 1.0in 1.0in 1.0in;}
#yiv1863614159 div.yiv1863614159WordSection1
{}
--></style>
<div>
<div class="yiv1863614159WordSection1">
<p class="yiv1863614159MsoNormal"><span style="font-size:11.0pt;color:#1F497D;">When I tried to compile r.geomorphon, I got the errors you see below. I just tried g.extensions with similar results.</span></p>
<p class="yiv1863614159MsoNormal"><span style="font-size:11.0pt;color:#1F497D;"> </span></p>
<pre>$ make MODULE_TOPDIR=/home/bob/dev/gis/grass70</pre>
<pre>test -d OBJ.x86_64-unknown-linux-gnu || mkdir -p OBJ.x86_64-unknown-linux-gnu</pre>
<pre>gcc -g -Wall -Werror-implicit-function-declaration -fno-common -Wextra -Wunused -I/home/bob/dev/gis/grass70/dist.x86_64-unknown-linux-gnu/include -I/home/bob/dev/gis/grass70/dist.x86_64-unknown-linux-gnu/include -D_FILE_OFFSET_BITS=64 -DPACKAGE=\""grassmods"\" -I/home/bob/dev/gis/grass70/dist.x86_64-unknown-linux-gnu/include -I/home/bob/dev/gis/grass70/dist.x86_64-unknown-linux-gnu/include -o OBJ.x86_64-unknown-linux-gnu/geom.o -c geom.c</pre>
<pre>geom.c: In function ‘ternary_rotate’:</pre>
<pre>geom.c:21:5: warning: unused variable ‘res’ [-Wunused-variable]</pre>
<pre>geom.c: In function ‘radial2cartesian’:</pre>
<pre>geom.c:188:21: warning: ordered comparison of pointer with integer zero [-Wextra]</pre>
<pre>geom.c: In function ‘extends’:</pre>
<pre>geom.c:198:37: warning: unused parameter ‘pattern_size’ [-Wunused-parameter]</pre>
<pre>geom.c: At top level:</pre>
<pre>geom.c:2:15: warning: ‘dirs’ defined but not used [-Wunused-variable]</pre>
<pre>gcc -g -Wall -Werror-implicit-function-declaration -fno-common -Wextra -Wunused -I/home/bob/dev/gis/grass70/dist.x86_64-unknown-linux-gnu/include -I/home/bob/dev/gis/grass70/dist.x86_64-unknown-linux-gnu/include -D_FILE_OFFSET_BITS=64 -DPACKAGE=\""grassmods"\" -I/home/bob/dev/gis/grass70/dist.x86_64-unknown-linux-gnu/include -I/home/bob/dev/gis/grass70/dist.x86_64-unknown-linux-gnu/include -o OBJ.x86_64-unknown-linux-gnu/main.o -c main.c</pre>
<pre>main.c: In function ‘main’:</pre>
<pre>main.c:177:2: warning: format not a string literal and no format arguments [-Wformat-security]</pre>
<pre>main.c:198:2: warning: format not a string literal and no format arguments [-Wformat-security]</pre>
<pre>main.c:207:2: warning: format not a string literal and no format arguments [-Wformat-security]</pre>
<pre>main.c:213:2: warning: format not a string literal and no format arguments [-Wformat-security]</pre>
<pre>main.c:220:3: warning: format not a string literal and no format arguments [-Wformat-security]</pre>
<pre>main.c:234:3: warning: format not a string literal and no format arguments [-Wformat-security]</pre>
<pre>main.c:310:8: warning: format not a string literal and no format arguments [-Wformat-security]</pre>
<pre>main.c:366:5: error: implicit declaration of function ‘radial2cartesian’ [-Werror=implicit-function-declaration]</pre>
<pre>main.c:401:2: error: implicit declaration of function ‘write_contrast_colors’ [-Werror=implicit-function-declaration]</pre>
<pre>main.c:268:20: warning: unused variable ‘formC’ [-Wunused-variable]</pre>
<pre>main.c:268:13: warning: unused variable ‘formB’ [-Wunused-variable]</pre>
<pre>main.c:268:6: warning: unused variable ‘formA’ [-Wunused-variable]</pre>
<pre>main.c:76:22: warning: unused variable ‘radius’ [-Wunused-variable]</pre>
<pre>main.c:74:11: warning: unused variable ‘n’ [-Wunused-variable]</pre>
<pre>main.c:74:8: warning: unused variable ‘j’ [-Wunused-variable]</pre>
<pre>main.c:463:1: warning: control reaches end of non-void function [-Wreturn-type]</pre>
<pre>cc1: some warnings being treated as errors</pre>
<pre>make: *** [OBJ.x86_64-unknown-linux-gnu/main.o] Error 1</pre>
<p class="yiv1863614159MsoNormal" style="margin-bottom:12.0pt;"> </p>
<p class="yiv1863614159MsoNormal"><span style="font-size:11.0pt;color:#1F497D;"> </span></p>
<p class="yiv1863614159MsoNormal"><span style="font-size:11.0pt;color:#1F497D;"> </span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in;">
<p class="yiv1863614159MsoNormal"><b><span style="font-size:10.0pt;">From:</span></b><span style="font-size:10.0pt;"> grass-user-bounces@lists.osgeo.org [mailto:grass-user-bounces@lists.osgeo.org]
<b>On Behalf Of </b>Robert Andrew Brown<br>
<b>Sent:</b> Tuesday, February 26, 2013 9:21 AM<br>
<b>To:</b> grass-user@lists.osgeo.org<br>
<b>Cc:</b> Phillip Owens<br>
<b>Subject:</b> [GRASS-user] Geomorphons and extension manager</span></p>
</div>
</div>
<p class="yiv1863614159MsoNormal"> </p>
<p class="yiv1863614159MsoNormal">To whom it may concern,</p>
<div>
<p class="yiv1863614159MsoNormal"> </p>
</div>
<div>
<p class="yiv1863614159MsoNormal">I am trying to use extension manager in grass to install geomrphons. However, I am having trouble with the extension manager(error below). I emailed the geomorphon developer Jarek Jasiewicz(See Below) and he suggest I contact the GRASS-Users
forum.</p>
</div>
<div>
<p class="yiv1863614159MsoNormal"> </p>
</div>
<div>
<p class="yiv1863614159MsoNormal">Please advise,</p>
</div>
<div>
<p class="yiv1863614159MsoNormal"> </p>
</div>
<div>
<p class="yiv1863614159MsoNormal">-Robert Brown</p>
<div>
<p class="yiv1863614159MsoNormal"><br>
<br>
<br>
</p>
<div>
<p class="yiv1863614159MsoNormal"><b><span style="font-size:13.5pt;">From:
</span></b><span style="font-size:13.5pt;">JASIEWICZ Jarosław <<a rel="nofollow" ymailto="mailto:jarekj@amu.edu.pl" target="_blank" href="/mc/compose?to=jarekj@amu.edu.pl">jarekj@amu.edu.pl</a>></span></p>
</div>
<div>
<p class="yiv1863614159MsoNormal"><b><span style="font-size:13.5pt;">Subject: Re: Geomorphons</span></b></p>
</div>
<div>
<p class="yiv1863614159MsoNormal"><b><span style="font-size:13.5pt;">Date:
</span></b><span style="font-size:13.5pt;">February 26, 2013 11:56:20 AM EST</span></p>
</div>
<div>
<p class="yiv1863614159MsoNormal"><b><span style="font-size:13.5pt;">To:
</span></b><span style="font-size:13.5pt;"><a rel="nofollow" ymailto="mailto:brown782@purdue.edu" target="_blank" href="/mc/compose?to=brown782@purdue.edu">brown782@purdue.edu</a></span></p>
</div>
<p class="yiv1863614159MsoNormal"> </p>
<div>
<p class="yiv1863614159MsoNormal">On 02/26/2013 05:21 PM, <a rel="nofollow" ymailto="mailto:brown782@purdue.edu" target="_blank" href="/mc/compose?to=brown782@purdue.edu">
brown782@purdue.edu</a> wrote:<br>
<br>
</p>
<p class="yiv1863614159MsoNormal">Dear Sir,<br>
<br>
I use grass on my Mac OS X 10.8.2. I have been trying to compile grass to install the add-on Geomorphons. However, it is overwhelming to compile grass from source code as I have very little experience compiling programs. When I saw that your Geomorphons algorithm
was part of the grass 7.0 add-ons I was pleased and tried to use the extension manager to add it to my grass add-on repository, however, I get an several errors which I have posted below. Any Suggestions?<br>
#####################</p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt;">
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt;">
<p class="yiv1863614159MsoNormal">g.extension extension=r.geomorphon/ operation=add<br>
Fetching <r.geomorphon/> from GRASS-Addons SVN (be patient)...<br>
Compiling...<br>
In file included from geom.c:1:<br>
local_proto.h:1:20: error: stdlib.h: No such file or<br>
directory<br>
local_proto.h:2:20: error: string.h: No such file or<br>
directory<br>
local_proto.h:3:18: error: math.h: No such file or directory<br>
local_proto.h:4:27: error: grass/glocale.h: No such file or<br>
directory<br>
local_proto.h:5:23: error: grass/gis.h: No such file or<br>
directory<br>
local_proto.h:6:26: error: grass/raster.h: No such file or<br>
directory<br>
In file included from geom.c:1:<br>
local_proto.h:56: error: expected specifier-qualifier-list<br>
before 'RASTER_MAP_TYPE'<br>
local_proto.h:66: error: expected specifier-qualifier-list<br>
before 'RASTER_MAP_TYPE'<br>
local_proto.h:74: error: expected specifier-qualifier-list<br>
before 'CELL'<br>
local_proto.h:139: error: expected declaration specifiers or<br>
'...' before 'RASTER_MAP_TYPE'<br>
local_proto.h:140: error: expected ')' before '*' token<br>
geom.c: In function 'exposition':<br>
geom.c:146: warning: incompatible implicit declaration of<br>
built-in function 'fabs'<br>
geom.c: In function 'extends':<br>
geom.c:206: warning: incompatible implicit declaration of<br>
built-in function 'fabs'<br>
geom.c: In function 'shape':<br>
geom.c:232: warning: incompatible implicit declaration of<br>
built-in function 'atan'<br>
geom.c:236: warning: incompatible implicit declaration of<br>
built-in function 'sin'<br>
geom.c:237: warning: incompatible implicit declaration of<br>
built-in function 'cos'<br>
In file included from geom.c:1:<br>
local_proto.h:1:20: error: stdlib.h: No such file or<br>
directory<br>
local_proto.h:2:20: error: string.h: No such file or<br>
directory<br>
local_proto.h:3:18: error: math.h: No such file or directory<br>
local_proto.h:4:27: error: grass/glocale.h: No such file or<br>
directory<br>
local_proto.h:5:23: error: grass/gis.h: No such file or<br>
directory<br>
local_proto.h:6:26: error: grass/raster.h: No such file or<br>
directory<br>
In file included from geom.c:1:<br>
local_proto.h:56: error: expected specifier-qualifier-list<br>
before 'RASTER_MAP_TYPE'<br>
local_proto.h:66: error: expected specifier-qualifier-list<br>
before 'RASTER_MAP_TYPE'<br>
local_proto.h:74: error: expected specifier-qualifier-list<br>
before 'CELL'<br>
local_proto.h:139: error: expected declaration specifiers or<br>
'...' before 'RASTER_MAP_TYPE'<br>
local_proto.h:140: error: expected ')' before '*' token<br>
geom.c: In function 'exposition':<br>
geom.c:146: warning: incompatible implicit declaration of<br>
built-in function 'fabs'<br>
geom.c: In function 'extends':<br>
geom.c:206: warning: incompatible implicit declaration of<br>
built-in function 'fabs'<br>
geom.c: In function 'shape':<br>
geom.c:232: warning: incompatible implicit declaration of<br>
built-in function 'atan'<br>
geom.c:236: warning: incompatible implicit declaration of<br>
built-in function 'sin'<br>
geom.c:237: warning: incompatible implicit declaration of<br>
built-in function 'cos'<br>
lipo: can't figure out the architecture type of: /var/folder<br>
s/wc/2dv9njw93k3bfyy5ppkw022h0000gn/T//ccESKY4a.out<br>
make: *** [OBJ.x86_64-apple-darwin12.2.0/geom.o] Error 1<br>
ERROR: Compilation failed, sorry. Please check above error messages.<br>
(Tue Feb 26 09:40:18 2013) Command finished (3 sec)<br>
#############################<br>
<br>
Your help is much appreciated!<br>
<br>
Sincerely,<br>
<br>
Robert Brown</p>
</blockquote>
</div>
</blockquote>
<p class="yiv1863614159MsoNormal"><br>
<br>
</p>
<div>
<p class="yiv1863614159MsoNormal">All messages comes from compiler informing you haven't installed standard librarires. This is however the issue of g.extension, which do not work well with Apple systems. Please contact grass dev team how to resolve this issue<br>
<br>
regards<br>
Jarek</p>
</div>
</div>
<p class="yiv1863614159MsoNormal"> </p>
</div>
</div>
</div>
</div><br>-----Inline Attachment Follows-----<br><br><div class="plainMail">_______________________________________________<br>grass-user mailing list<br><a ymailto="mailto:grass-user@lists.osgeo.org" href="/mc/compose?to=grass-user@lists.osgeo.org">grass-user@lists.osgeo.org</a><br><a href="http://lists.osgeo.org/mailman/listinfo/grass-user" target="_blank">http://lists.osgeo.org/mailman/listinfo/grass-user</a><br></div></blockquote></td></tr></table>