<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="NO-BOK" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Thanks Daniel, I might come back to your offer!<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Cheers<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Stefan<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Daniel Victoria [mailto:daniel.victoria@gmail.com]
<br>
<b>Sent:</b> tirsdag 23. januar 2018 15.04<br>
<b>To:</b> Markus Metz <markus.metz.giswork@gmail.com><br>
<b>Cc:</b> Stefan Blumentrath <Stefan.Blumentrath@nina.no>; GRASS user list <grass-user@lists.osgeo.org><br>
<b>Subject:</b> Re: [GRASS-user] i.atcorr with Sentinel2<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">It's been a while since I wrote that script. Glad to see it's still of use :)<o:p></o:p></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt">Anyway, I'm a bit overwhelmed so I won't be able to look at the changes asked. But I'm glad Stefan can take a look. And I can help out in any questions that might come up.<o:p></o:p></p>
</div>
<p class="MsoNormal">Cheers<o:p></o:p></p>
</div>
<p class="MsoNormal">Daniel <o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Tue, Jan 23, 2018 at 11:50 AM Markus Metz <<a href="mailto:markus.metz.giswork@gmail.com">markus.metz.giswork@gmail.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p class="MsoNormal"><br>
<br>
On Tue, Jan 23, 2018 at 2:19 PM, Stefan Blumentrath <<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@nina.no</a>> wrote:<br>
><br>
> OK, will give it a try.<br>
><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal">The first part is more important because it 1) fixes the interpolation to 2.5 nm steps, and 2) helps iwave.cpp to load the response values.<o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">><br>
> For the second part I am not sure if I properly understood where min – max wavelength for each band should be printed to.<br>
><br>
> Do you mean to replace<br>
><br>
> # convert limits from nanometers to micrometers<br>
><br>
> lowerlimit = wavelengths[0]/1000<br>
><br>
> upperlimit = wavelengths[-1]/1000<br>
><br>
> <br>
><br>
> Or just as a screen output?<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal">Just a screen output to help update the manual<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">><br>
> You did not mean band value limits, right?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal">No, e.g. in the manual is<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Sentinel2A Coastal blue band B1 (430nm - 457nm)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">and this range could be printed out to screen based on the actual response. This range can then be copied to the manual, making life a bit easier for the person updating the manual.<o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal">><br>
> Not sure I am of help/useful for fixing create_iwave.py, but I`ll do my best…<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal">Your help is welcome!<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Markus M<o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">><br>
> Cheers<br>
><br>
> Stefan<br>
><br>
> <br>
><br>
> <br>
><br>
> From: Markus Metz [mailto:<a href="mailto:markus.metz.giswork@gmail.com" target="_blank">markus.metz.giswork@gmail.com</a>]<br>
> Sent: tirsdag 23. januar 2018 13.02<br>
> To: Stefan Blumentrath <<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@nina.no</a>><br>
> Cc: Markus Neteler <<a href="mailto:neteler@osgeo.org" target="_blank">neteler@osgeo.org</a>>; GRASS user list <<a href="mailto:grass-user@lists.osgeo.org" target="_blank">grass-user@lists.osgeo.org</a>><br>
><br>
><br>
> Subject: Re: [GRASS-user] i.atcorr with Sentinel2<br>
><br>
> <br>
><br>
><br>
><br>
> On Tue, Jan 23, 2018 at 12:25 PM, Stefan Blumentrath <<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@nina.no</a>> wrote:<br>
> ><br>
> > No problem. Any chance I can contribute to maintenance of create_iwave.py?<br>
> ><br>
> > What needs to be done? Take your latest changes into account?<br>
><br>
> nodata handling should be changed. In read_input(), missing values should be set to zero. Then for each band, leading and trailing zeros would be set to -1. This helps interpolate_band() to get the correct subrange.<br>
><br>
> For each band, create_iwave.py should print out the band name and the wavelength as min - max. Care must be taken when finding reasonable min and max wavelengths: find the max response, then go back while response > threshold to find the min wavelength. Go
forward while response > threshold to find the max wavelength. As threshold I suggest 0.1 to eliminate noise in the response values.<br>
><br>
> Markus M<br>
><br>
> ><br>
> > <br>
> ><br>
> > If you think it makes sense I will try to create a patch for adding S2B to i.atcorr (would be a nice exercise and does not seem too complex)? Will open a ticket and start working on it unless you tell me different.<br>
> ><br>
> > <br>
> ><br>
> > Cheers<br>
> ><br>
> > Stefan<br>
> ><br>
> > <br>
> ><br>
> > <br>
> ><br>
> > <br>
> ><br>
> > From: grass-user [mailto:<a href="mailto:grass-user-bounces@lists.osgeo.org" target="_blank">grass-user-bounces@lists.osgeo.org</a>] On Behalf Of Markus Metz<br>
> > Sent: tirsdag 23. januar 2018 12.03<br>
> > To: Markus Neteler <<a href="mailto:neteler@osgeo.org" target="_blank">neteler@osgeo.org</a>><br>
> > Cc: GRASS user list <<a href="mailto:grass-user@lists.osgeo.org" target="_blank">grass-user@lists.osgeo.org</a>><br>
> > Subject: Re: [GRASS-user] i.atcorr with Sentinel2<br>
> ><br>
> > <br>
> ><br>
> ><br>
> ><br>
> > On Tue, Jan 23, 2018 at 11:51 AM, Markus Neteler <<br>
> > <a href="mailto:neteler@osgeo.org" target="_blank">neteler@osgeo.org</a>> wrote:<br>
> ><br>
> > ><br>
> > > On Tue, Jan 23, 2018 at 11:09 AM, Žofie Cimburová<br>
> > > <<br>
> > <a href="mailto:zoficimburova@gmail.com" target="_blank">zoficimburova@gmail.com</a>> wrote:<br>
> ><br>
> > > > Forgot to cc the list.<br>
> > > ><br>
> > > > The CSV and the cpp template:<br>
> > > ><br>
> > <a href="https://www.dropbox.com/sh/9cnhsl59kvmx4o1/AABwnEVHdxfW_PqrB5Xcpczda?dl=0" target="_blank">
https://www.dropbox.com/sh/9cnhsl59kvmx4o1/AABwnEVHdxfW_PqrB5Xcpczda?dl=0</a><br>
> ><br>
> > ><br>
> > > Great! Would you mind to also convert the S2A table? AFAIK it got<br>
> > > updated due to recalibration compared to what we currently have.<br>
> ><br>
> > please wait a bit with creating the cpp template, create_iwave.py needs some maintenance<br>
> ><br>
> > Markus M<br>
> ><br>
> > <br>
> ><br>
> > ><br>
> > > markusN<br>
> > > _______________________________________________<br>
> > > grass-user mailing list<br>
> > > <a href="mailto:grass-user@lists.osgeo.org" target="_blank">grass-user@lists.osgeo.org</a><br>
> > > <a href="https://lists.osgeo.org/mailman/listinfo/grass-user" target="_blank">
https://lists.osgeo.org/mailman/listinfo/grass-user</a><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal">_______________________________________________<br>
grass-user mailing list<br>
<a href="mailto:grass-user@lists.osgeo.org" target="_blank">grass-user@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/grass-user" target="_blank">https://lists.osgeo.org/mailman/listinfo/grass-user</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</body>
</html>