<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jan 24, 2018 at 12:35 AM, Stefan Blumentrath <span dir="ltr"><<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@nina.no</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="NO-BOK" link="blue" vlink="purple">
<div class="m_-6106072797492198515WordSection1">
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Hi again,<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">So, I did not prioritize tests for the time being and added a first attempt for a diff to
<a href="https://trac.osgeo.org/grass/ticket/3482" target="_blank">https://trac.osgeo.org/grass/<wbr>ticket/3482</a><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">I would be happy if someone could review…<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">i.atcorr compiles fine with the changes, works for S2B and gives non-NULL results.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Zofie can you test with proper S2B data?</span></p></div></div></blockquote><div><br></div><div>Hi, I tested with one scene of S2B data and all bands, and the results look good. (Not sure how to test if they're 100 % correct, but they at least seem to make sense.)</div><div>Best,</div><div>Zofie</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="NO-BOK" link="blue" vlink="purple"><div class="m_-6106072797492198515WordSection1">
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Cheers<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Stefan<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Markus Metz [mailto:<a href="mailto:markus.metz.giswork@gmail.com" target="_blank">markus.metz.giswork@<wbr>gmail.com</a>]
<br>
<b>Sent:</b> tirsdag 23. januar 2018 15.31<br>
<b>To:</b> Stefan Blumentrath <<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@nina.no</a>><br>
<b>Cc:</b> Markus Neteler <<a href="mailto:neteler@osgeo.org" target="_blank">neteler@osgeo.org</a>>; GRASS user list <<a href="mailto:grass-user@lists.osgeo.org" target="_blank">grass-user@lists.osgeo.org</a>></span></p><div><div class="h5"><br>
<b>Subject:</b> Re: [GRASS-user] i.atcorr with Sentinel2<u></u><u></u></div></div><p></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
<br>
On Tue, Jan 23, 2018 at 3:24 PM, Stefan Blumentrath <<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@nina.no</a>> wrote:<br>
><br>
> OK, sounds doable for me ;-).<br>
> Will look at it tonight. Most of the other changes for Sentinel-2B are already in place (I hope).<br>
<br>
Great!<br>
<br>
> Not sure if I manage to add python tests as well, looks like current tests are more manual?<u></u><u></u></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt">Apparently results differ between operating systems, therefore tests won't work well, unless you test if the output is all NULL, in which case a fatal error should be produced anyway.<u></u><u></u></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt">Markus M<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">><br>
> Cheers<br>
> Stefan<br>
> ______________________________<wbr>__________<br>
> Von: Markus Metz [<a href="mailto:markus.metz.giswork@gmail.com" target="_blank">markus.metz.giswork@gmail.com</a><wbr>]<br>
> Gesendet: Dienstag, 23. Januar 2018 14:50<br>
> An: Stefan Blumentrath<br>
> Cc: Markus Neteler; GRASS user list<br>
> Betreff: Re: [GRASS-user] i.atcorr with Sentinel2<br>
><br>
> On Tue, Jan 23, 2018 at 2:19 PM, Stefan Blumentrath <<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@nina.no</a><<wbr>mailto:<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@<wbr>nina.no</a>>> wrote:<br>
> ><br>
> > OK, will give it a try.<br>
> ><br>
> The first part is more important because it 1) fixes the interpolation to 2.5 nm steps, and 2) helps iwave.cpp to load the response values.<br>
> ><br>
> > For the second part I am not sure if I properly understood where min - max wavelength for each band should be printed to.<br>
> ><br>
> > Do you mean to replace<br>
> ><br>
> > # convert limits from nanometers to micrometers<br>
> ><br>
> > lowerlimit = wavelengths[0]/1000<br>
> ><br>
> > upperlimit = wavelengths[-1]/1000<br>
> ><br>
> ><br>
> ><br>
> > Or just as a screen output?<br>
><br>
> Just a screen output to help update the manual<br>
> ><br>
> > You did not mean band value limits, right?<br>
><br>
> No, e.g. in the manual is<br>
><br>
> Sentinel2A Coastal blue band B1 (430nm - 457nm)<br>
><br>
> and this range could be printed out to screen based on the actual response. This range can then be copied to the manual, making life a bit easier for the person updating the manual.<br>
> ><br>
> > Not sure I am of help/useful for fixing create_iwave.py, but I`ll do my best.<br>
><br>
> Your help is welcome!<br>
><br>
> Markus M<br>
><br>
> ><br>
> > Cheers<br>
> ><br>
> > Stefan<br>
> ><br>
> ><br>
> ><br>
> ><br>
> ><br>
> > From: Markus Metz [mailto:<a href="mailto:markus.metz.giswork@gmail.com" target="_blank">markus.metz.giswork@<wbr>gmail.com</a><mailto:<a href="mailto:markus.metz.giswork@gmail.com" target="_blank">markus.metz.<wbr>giswork@gmail.com</a>>]<br>
> > Sent: tirsdag 23. januar 2018 13.02<br>
> > To: Stefan Blumentrath <<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@nina.no</a><<wbr>mailto:<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@<wbr>nina.no</a>>><br>
> > Cc: Markus Neteler <<a href="mailto:neteler@osgeo.org" target="_blank">neteler@osgeo.org</a><mailto:<a href="mailto:neteler@osgeo.org" target="_blank">nete<wbr>ler@osgeo.org</a>>>; GRASS user list <<a href="mailto:grass-user@lists.osgeo.org" target="_blank">grass-user@lists.osgeo.org</a><<wbr>mailto:<a href="mailto:grass-user@lists.osgeo.org" target="_blank">grass-user@lists.osgeo.<wbr>org</a>>><br>
> ><br>
> ><br>
> > Subject: Re: [GRASS-user] i.atcorr with Sentinel2<br>
> ><br>
> ><br>
> ><br>
> ><br>
> ><br>
> > On Tue, Jan 23, 2018 at 12:25 PM, Stefan Blumentrath <<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@nina.no</a><<wbr>mailto:<a href="mailto:Stefan.Blumentrath@nina.no" target="_blank">Stefan.Blumentrath@<wbr>nina.no</a>>> wrote:<br>
> > ><br>
> > > No problem. Any chance I can contribute to maintenance of create_iwave.py?<br>
> > ><br>
> > > What needs to be done? Take your latest changes into account?<br>
> ><br>
> > nodata handling should be changed. In read_input(), missing values should be set to zero. Then for each band, leading and trailing zeros would be set to -1. This helps interpolate_band() to get the correct subrange.<br>
> ><br>
> > For each band, create_iwave.py should print out the band name and the wavelength as min - max. Care must be taken when finding reasonable min and max wavelengths: find the max response, then go back while response > threshold to find the min wavelength.
Go forward while response > threshold to find the max wavelength. As threshold I suggest 0.1 to eliminate noise in the response values.<br>
> ><br>
> > Markus M<br>
> ><br>
> > ><br>
> > ><br>
> > ><br>
> > > If you think it makes sense I will try to create a patch for adding S2B to i.atcorr (would be a nice exercise and does not seem too complex)? Will open a ticket and start working on it unless you tell me different.<br>
> > ><br>
> > ><br>
> > ><br>
> > > Cheers<br>
> > ><br>
> > > Stefan<br>
> > ><br>
> > ><br>
> > ><br>
> > ><br>
> > ><br>
> > ><br>
> > ><br>
> > > From: grass-user [mailto:<a href="mailto:grass-user-bounces@lists.osgeo.org" target="_blank">grass-user-bounces@<wbr>lists.osgeo.org</a><mailto:<a href="mailto:grass-user-bounces@lists.osgeo.org" target="_blank">grass-<wbr>user-bounces@lists.osgeo.org</a>>] On Behalf Of Markus Metz<br>
> > > Sent: tirsdag 23. januar 2018 12.03<br>
> > > To: Markus Neteler <<a href="mailto:neteler@osgeo.org" target="_blank">neteler@osgeo.org</a><mailto:<a href="mailto:neteler@osgeo.org" target="_blank">nete<wbr>ler@osgeo.org</a>>><br>
> > > Cc: GRASS user list <<a href="mailto:grass-user@lists.osgeo.org" target="_blank">grass-user@lists.osgeo.org</a><<wbr>mailto:<a href="mailto:grass-user@lists.osgeo.org" target="_blank">grass-user@lists.osgeo.<wbr>org</a>>><br>
> > > Subject: Re: [GRASS-user] i.atcorr with Sentinel2<br>
> > ><br>
> > ><br>
> > ><br>
> > ><br>
> > ><br>
> > > On Tue, Jan 23, 2018 at 11:51 AM, Markus Neteler <<br>
> > > <a href="mailto:neteler@osgeo.org" target="_blank">neteler@osgeo.org</a><mailto:<a href="mailto:neteler@osgeo.org" target="_blank">netel<wbr>er@osgeo.org</a>>> wrote:<br>
> > ><br>
> > > ><br>
> > > > On Tue, Jan 23, 2018 at 11:09 AM, Žofie Cimburová<br>
> > > > <<br>
> > > <a href="mailto:zoficimburova@gmail.com" target="_blank">zoficimburova@gmail.com</a><<wbr>mailto:<a href="mailto:zoficimburova@gmail.com" target="_blank">zoficimburova@gmail.com</a><wbr>>> wrote:<br>
> > ><br>
> > > > > Forgot to cc the list.<br>
> > > > ><br>
> > > > > The CSV and the cpp template:<br>
> > > > ><br>
> > > <a href="https://www.dropbox.com/sh/9cnhsl59kvmx4o1/AABwnEVHdxfW_PqrB5Xcpczda?dl=0" target="_blank">
https://www.dropbox.com/sh/<wbr>9cnhsl59kvmx4o1/AABwnEVHdxfW_<wbr>PqrB5Xcpczda?dl=0</a><br>
> > ><br>
> > > ><br>
> > > > Great! Would you mind to also convert the S2A table? AFAIK it got<br>
> > > > updated due to recalibration compared to what we currently have.<br>
> > ><br>
> > > please wait a bit with creating the cpp template, create_iwave.py needs some maintenance<br>
> > ><br>
> > > Markus M<br>
> > ><br>
> > ><br>
> > ><br>
> > > ><br>
> > > > markusN<br>
> > > > ______________________________<wbr>_________________<br>
> > > > grass-user mailing list<br>
> > > > <a href="mailto:grass-user@lists.osgeo.org" target="_blank">grass-user@lists.osgeo.org</a><<wbr>mailto:<a href="mailto:grass-user@lists.osgeo.org" target="_blank">grass-user@lists.osgeo.<wbr>org</a>><br>
> > > > <a href="https://lists.osgeo.org/mailman/listinfo/grass-user" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/grass-user</a><br>
><u></u><u></u></p>
</div>
</div>
</div>
</div></div></div>
</div>
<br>______________________________<wbr>_________________<br>
grass-user mailing list<br>
<a href="mailto:grass-user@lists.osgeo.org">grass-user@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/grass-user" rel="noreferrer" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/grass-user</a><br></blockquote></div><br></div></div>