<div dir="ltr">I understand, I am not sure we want to soften our stance on reviewing code (we have already softened things by asking for only a review rather than a fix). Do you think a regex search (or an automated tool) could help you cut down the files that need attention? Only other thing I could say is to open a bug ticket for each of the four projects - indicating that the status is unknown.<div><br></div><div>Deepening on how your team functions it may be easier to get a volunteer to fix an "out standing issue" then to volunteer for incubation :) Actually with your great gvSig partner program you may be able to ask a community member or organisation who does not normally program to help out.</div><div>--</div><div>Jody</div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div dir="ltr"><div>Jody Garnett</div></div></div>
<br><div class="gmail_quote">On Thu, Oct 2, 2014 at 6:08 AM, Manuel Madrid <span dir="ltr"><<a href="mailto:mmadrid@gvsig.com" target="_blank">mmadrid@gvsig.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi Jody,<br>
<br>
Thank you very much for taking a look at our provenance review and
for this detailed description.<br>
<br>
Within the 3% of the code that still has not been reviewed we could
find basically two cases:<br>
1) Files copied from other projects (like your third point).<br>
2) Portions of code copied from other projects.<br>
<br>
In general we can assume that, in the first case, we kept the
original headers and, in the second case, we included in our header
a mention saying that it includes portions of code from the original
project. We are pretty sure that this is Ok in at least three of the
four not reviewed projects. The problem is that we cannot guarantee
that without reviewing all the files.<br>
<br>
Best,<br>
Manuel.<div><div class="h5"><br>
<br>
<div>On 01/10/14 19:08, Jody Garnett wrote:<br>
</div>
<blockquote type="cite">
<div>We all understand the release cycle :) And really hope you
are close. Reading your email I am not sure I understand the
difference between core source code that has been reviewed and
the 3% remaining external code?
<div><br>
</div>
<div>I have experience of three similar things - perhaps you
could tell me which one you mean?</div>
<div><br>
</div>
<div>1) pending code: GeoServer maintains a "community" folder
in our source code for experiments and new developers. We do
not build this source code into our binary and it has not had
its license and headers reviewed. When a module is "ready" a
member of the GeoServer team will review and add it into the
main codebase - but really it is a play area for developer out
reach. The source code is available for download - but has not
been checked by the GeoServer team (and is not being compiled
and distributed by the GeoServer team).</div>
<div><br>
</div>
<div>So if your 3% is like this - no worries. Explain in your
provenance review that this 3% is a work in progress and will
be checked before being distributed.</div>
<div><br>
</div>
<div>2) External dependency: GeoTools uses the Apache Commons
library - we checked that the apache license worked with LGPL
for incubation, but we did not download the apache commons
library source code and check each file. The GeoTools team
trusts the apache foundation to sort that out, if they make a
mistake we may need to do something about it but we will deal
with it when the time comes.</div>
<div><br>
</div>
<div>So if your 3% is like this you are doing too much work -
only check what your team manages. If you build it check it,
if you get it from maven central check the license works out
(as you do not want to annoy another team).</div>
<div><br>
</div>
<div>3) Copying a file from another project. GeoTools has
several files that have been copied from Apache - and needed
to ensure they had the original Apache License header on top
of them. This is why when you look at our <a href="http://docs.geotools.org/latest/userguide/welcome/license.html" target="_blank">license
page</a> you can see a note about the library being LGPL ...
along with a few other files that have been provided to us.</div>
<div><br>
</div>
<div>Reading your <a href="http://www.gvsig.org/plone/projects/gvsig-desktop/docs/devel/gvsig-devel-guide/2-1-0/provenance-review" target="_blank">provenance-review</a> -
I think this is what you mean. There was no need to seperate
out into an external project (as long as the license is
compatible). Just leave the origional headers as is. Depending
on the license terms you may need to make a note in your user
docs - as was done in the GeoTools license page.</div>
<div><br>
</div>
<div>If you need to modify the files a bit after making a copy
(say to patch an issue) you can get an interesting header
example - as shown in "Example from Tutorial or Magazine Code"
from <a href="https://github.com/geoserver/geoserver/wiki/Expectations-and-Examples" target="_blank">GeoServer</a>.</div>
<div><br>
</div>
<div>
<div> /*</div>
<div> * Copyright (c) 2007 - 2013 OpenPlans - <a href="http://www.openplans.org" target="_blank">www.openplans.org</a>.
All rights reserved.</div>
<div> * Copyright 2003 Jayson Falkner (<a href="mailto:jayson@jspinsider.com" target="_blank">jayson@jspinsider.com</a>)</div>
<div><br>
</div>
<div> * This code is from "Servlets and JavaServer pages;
the J2EE Web Tier",</div>
<div> * <a href="http://www.jspbook.com" target="_blank">http://www.jspbook.com</a>.
You may freely use the code both commercially</div>
<div> * and non-commercially. If you like the code, please
pick up a copy of</div>
<div> * the book and help support the authors, development
of more free code,</div>
<div> * and the JSP/Servlet/J2EE community.</div>
<div> *</div>
<div> * Modified by David Winslow <<a href="mailto:dwinslow@openplans.org" target="_blank">dwinslow@openplans.org</a>>
on 2007-12-13.</div>
<div> */</div>
</div>
<div><br>
</div>
<div>So if your 3% is like this don't worry, leave the original
headers alone and you are good to go.</div>
</div>
<div class="gmail_extra"><br>
<div>
<div>
<div>Jody Garnett</div>
</div>
</div>
<br>
<div class="gmail_quote">On Wed, Oct 1, 2014 at 3:25 AM, Manuel
Madrid <span><<a href="mailto:mmadrid@gvsig.com" target="_blank">mmadrid@gvsig.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi
Dimitris,<br>
<br>
Good to hear from you again and thank you very much for
being willing to help us again. We are really almost done.
Let me give you a general view of the status of the
incubation process:<br>
<br>
We made a big effort some months ago in order to finish the
main pending task: the code provenance review. At this
moment it has been completely reviewed three core projects
which together represent more than 97% of the core source
code. Also, within the rest of the core projects (less that
3% of the total code) we reviewed the license compatibility
with external libraries so there is only missing the review
of external code and file headers of this small part of the
code. We identified and fixed all the issues that we
detected within the reviewed source code.<br>
<br>
Regarding the rest of requirements, in principle there are
only two missing documents: the release guide and the
release testing checklist. We could provide those documents
in a short term but, to be honest, unfortunately we are not
going to be able to review the provenance of the missing 3%
of the code at this moment, as all our resources are
completely focused in the final release of gvSIG 2.1. We
really hope that this is not a critical issue.<br>
<br>
You will find all the information related with the gvSIG
incubation process in the following links:<br>
<br>
- Incubation Status:<br>
<a href="http://wiki.osgeo.org/wiki/GvSIG_Incubation_Status" target="_blank">http://wiki.osgeo.org/wiki/GvSIG_Incubation_Status</a><br>
- Incubation Checklist:<br>
<a href="http://wiki.osgeo.org/wiki/GvSIG_Incubation_Checklist" target="_blank">http://wiki.osgeo.org/wiki/GvSIG_Incubation_Checklist</a><br>
- Provenance review:<br>
<a href="http://www.gvsig.org/plone/projects/gvsig-desktop/docs/devel/gvsig-devel-guide/2-1-0/provenance-review" target="_blank">http://www.gvsig.org/plone/projects/gvsig-desktop/docs/devel/gvsig-devel-guide/2-1-0/provenance-review</a><br>
<br>
We would very much appreciate if you can review this and let
us know if providing the documents I mentioned would be
enough to get ready for the graduation.<br>
<br>
Of course I will be available for talking about this
off-list if you want.<br>
<br>
Best,<br>
Manuel.
<div>
<div><br>
<br>
On 01/10/14 09:39, Dimitris Kotzinos wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Manuel and Jeff,<br>
<br>
I was thinking the exact same thing!<br>
It would be great to announce the graduation for the
conference.<br>
Manuel, could we try to revive the process? We can
talk off-list if you like!<br>
<br>
Sorry for not pushing too hard and thanks to Jeff for
putting this forward.<br>
<br>
Best regards,<br>
<br>
Dimitris<br>
_______________________________________________<br>
Incubator mailing list<br>
<a href="mailto:Incubator@lists.osgeo.org" target="_blank">Incubator@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/incubator" target="_blank">http://lists.osgeo.org/mailman/listinfo/incubator</a><br>
</blockquote>
<br>
_______________________________________________<br>
Incubator mailing list<br>
<a href="mailto:Incubator@lists.osgeo.org" target="_blank">Incubator@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/incubator" target="_blank">http://lists.osgeo.org/mailman/listinfo/incubator</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>