<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Jody,</p>
<p>Thanks for your email. Sorry if I jumped the gun a bit with
R-Spatial - from my understanding of what I read and what we
walked about, I though it was ok to post the page live. I think
the previous review got lost with the handover to me, so apologies
for having to make you type it out again!<br>
</p>
<div class="moz-cite-prefix">On 8/30/22 21:45, Jody Garnett wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">Okay so let me try the review again:</div>
<div dir="ltr"><br>
</div>
<div>Website page feedback (and some edits since it is already
live):</div>
<div><br>
</div>
<div>1. The logo - do you have one? I guess I see the same thing
on your website ...</div>
</div>
</blockquote>
<p>The logo is the image here -
<a class="moz-txt-link-freetext" href="https://www.osgeo.org/wp-content/uploads/logo-14-370x206.png">https://www.osgeo.org/wp-content/uploads/logo-14-370x206.png</a> -
with variations on a theme here -
<a class="moz-txt-link-freetext" href="https://github.com/r-spatial/r-spatial.org/blob/gh-pages/images/logo.png">https://github.com/r-spatial/r-spatial.org/blob/gh-pages/images/logo.png</a>.
<br>
</p>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<div dir="ltr">
<div>2. The description includes a lot of raw URLs, I edited to
make these text and easier to read</div>
</div>
</blockquote>
Thanks. I'd already tidied these up a bit, so thanks for catching
the other ones. <br>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<div dir="ltr">
<div>3. Is it possible to make a screen snaps showing a code
example or or a visual result (it is important for folks to
have an idea of what the program looks like even if it is only
analysis)<br>
</div>
</div>
</blockquote>
Yes - we can add this<br>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<div dir="ltr">
<div>4. The license part is understandably hard to follow, can I
just ask if all of the libraries are open source or free
software (the example you cite is GPL-2 or MIT). I added a
footer with your explanation and left the license part simple
showing a list of licenses I saw (you perhaps know more)</div>
</div>
</blockquote>
I will check and confirm<br>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<div dir="ltr">
<div>5. You have some links to user blog and twitter, but no
developer links to source code or build instructions. I added
some but perhaps you have more?</div>
</div>
</blockquote>
These are all by project, so I think what you have is fine. I will
check. <br>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<div dir="ltr">
<div>6. The projects (<a href="https://r-spatial.org/projects/"
moz-do-not-send="true" class="moz-txt-link-freetext">https://r-spatial.org/projects/</a>)
are a challenge, with the ESRI one not being open source.
Would it be smart to list licenses on that page?</div>
</div>
</blockquote>
I will check about this. We might rearrange to a more logical layout
(OSGeo R-Spatial Project libraries, and links to other libraries). <br>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<div dir="ltr">
<div>7. Core contributors ... are there any R-Spatial service
providers available?</div>
</div>
</blockquote>
We have a range of individuals - can we add these similar to the
'Who's involved' list? Or do they have to be added to OSGeo as an
explicit Service Provider? I will also be adding myself as a service
provider. <br>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<div dir="ltr">
<div>8. Changed the description to say "open source project"
while we wait for incubation committee and board motion <br>
</div>
</div>
</blockquote>
Ok, thanks. I wasn't clear on the process. <br>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<div dir="ltr">
<div><br>
</div>
<div>Project review: This is a challenge since there are several
projects in one family; we can limit the check to the ones
listed on the website page or the <a
href="https://r-spatial.org/projects/"
moz-do-not-send="true">projects</a> page of your website.
(The <a href="https://r-spatial.github.io/sf/"
moz-do-not-send="true" class="moz-txt-link-freetext">https://r-spatial.github.io/sf/</a>
page is so cute with little mascots).</div>
</div>
</blockquote>
<p>Thanks :-)</p>
<p>Yes, makes sense to limit this to the ones listed on the website.
We might rearrange this page as per #6. <br>
</p>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<div dir="ltr">
<div><br>
</div>
<div>1. geospatial</div>
<div>- geospatial: <a
href="https://github.com/r-spatial/sf/blob/main/README.md"
moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/r-spatial/sf/blob/main/README.md</a>
- geospatial</div>
<div>- user docs or quickstart: <a
href="https://r-spatial.github.io/sf/"
moz-do-not-send="true" class="moz-txt-link-freetext">https://r-spatial.github.io/sf/</a>
and <a href="https://r-spatial.github.io/sf/"
moz-do-not-send="true" class="moz-txt-link-freetext">https://r-spatial.github.io/sf/</a>
<-- the cheatsheet is great</div>
<div>2. free or open source</div>
<div>- <a
href="https://github.com/r-spatial/sf/blob/main/LICENSE"
moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/r-spatial/sf/blob/main/LICENSE</a>
<-- this is not complete</div>
</div>
</blockquote>
We can work on this<br>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<div dir="ltr">
<div>- checking headers:</div>
<div>- <a
href="https://github.com/r-spatial/sf/blob/main/R/RcppExports.R"
moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/r-spatial/sf/blob/main/R/RcppExports.R</a>
- generated</div>
<div>- <a
href="https://github.com/r-spatial/sf/blob/main/R/bind.R"
moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/r-spatial/sf/blob/main/R/bind.R</a>
- no header applied</div>
<div>- <a
href="https://github.com/r-spatial/sf/blob/main/src/bbox.h"
moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/r-spatial/sf/blob/main/src/bbox.h</a>
- no header</div>
<div>- <a
href="https://github.com/r-spatial/sf/blob/main/src/gdal_read.cpp"
moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/r-spatial/sf/blob/main/src/gdal_read.cpp</a>
- no header</div>
<div>3. Participatory</div>
<div>- </div>
<div>CONTRIBUTING.md - do not see this (file shown when making a
pull request)</div>
</div>
</blockquote>
Yes, this is something we can add<br>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<div dir="ltr">
<div>- <a href="https://github.com/r-spatial/sf/pulls"
moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/r-spatial/sf/pulls</a>
can see a lot of successful pull requests so that is great</div>
<div>4. code of conduct</div>
<div>- <a
href="https://github.com/r-spatial/sf/blob/main/CONDUCT.md"
moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/r-spatial/sf/blob/main/CONDUCT.md</a>
- great</div>
<div><br>
</div>
<div>So it looks like for the <b>sf</b> module there is some
work to do on headers; I am going to hold off checking any
more.</div>
</div>
</blockquote>
<p>Thanks. I'll get back to you with the more detailed stuff in due
course. <br>
</p>
<blockquote type="cite"
cite="mid:CAOhbgAkjQYpEdNUa48M33DdyQtbhe3cpDkWaaUCzar58G2A6SA@mail.gmail.com">
<div dir="ltr">
<div><br>
</div>
<div>Jody</div>
</div>
</blockquote>
<p><br>
</p>
<p>Many thanks,</p>
Nick.<br>
<pre class="moz-signature" cols="72">--
Nick Bearman
+44 (0) 7717745715
<a class="moz-txt-link-abbreviated" href="mailto:nick@geospatialtrainingsolutions.co.uk">nick@geospatialtrainingsolutions.co.uk</a>
Due to my own life/work balance, you may get emails from me outside of normal working hours. Please do not feel any pressure to respond outside of your own working pattern.</pre>
</body>
</html>