[Liblas-commits] hg: apps/lasindex: removed unused variable rc; added FIXME comme...

[liblas-commits at liblas.org]

changeset af24c7e8c91c in /home/www/liblas.org/hg
details: http://hg.liblas.org/main/hg?cmd=changeset;node=af24c7e8c91c
summary: apps/lasindex: removed unused variable rc; added FIXME comment about lack of exception handling nor safety.

diffstat:

 apps/lasindex.cpp |  31 +++++++++++++------------------
 1 files changed, 13 insertions(+), 18 deletions(-)

diffs (84 lines):

diff -r aef552b70b4b -r af24c7e8c91c apps/lasindex.cpp
--- a/apps/lasindex.cpp	Fri Oct 09 09:42:38 2009 -0500
+++ b/apps/lasindex.cpp	Sat Oct 10 02:30:57 2009 +0100
@@ -10,7 +10,8 @@
 #include <liblas/index/index.hpp>
 
 
-#include <iostream>
+#include <cstring>
+#include <iterator>
 #include <iterator>
 #include <fstream>
 #include <vector>
@@ -50,33 +51,31 @@
 
 int main(int argc, char* argv[])
 {
-    int rc = 0;
-
     std::string input;
     std::string output;
     
     for (int i = 1; i < argc; i++)
     {
-        if (    strcmp(argv[i],"-h") == 0 ||
-                strcmp(argv[i],"--help") == 0
+        if (    std::strcmp(argv[i],"-h") == 0 ||
+                std::strcmp(argv[i],"--help") == 0
             )
         {
             usage();
             exit(0);
         }
-        else if (   strcmp(argv[i],"--input") == 0  ||
-                    strcmp(argv[i],"-input") == 0   ||
-                    strcmp(argv[i],"-i") == 0       ||
-                    strcmp(argv[i],"-in") == 0
+        else if (   std::strcmp(argv[i],"--input") == 0  ||
+                    std::strcmp(argv[i],"-input") == 0   ||
+                    std::strcmp(argv[i],"-i") == 0       ||
+                    std::strcmp(argv[i],"-in") == 0
                 )
         {
             i++;
             input = std::string(argv[i]);
         }
-        else if (   strcmp(argv[i],"--output") == 0  ||
-                    strcmp(argv[i],"--out") == 0     ||
-                    strcmp(argv[i],"-out") == 0     ||
-                    strcmp(argv[i],"-o") == 0       
+        else if (   std::strcmp(argv[i],"--output") == 0  ||
+                    std::strcmp(argv[i],"--out") == 0     ||
+                    std::strcmp(argv[i],"-out") == 0     ||
+                    std::strcmp(argv[i],"-o") == 0       
                 )
         {
             i++;
@@ -106,13 +105,12 @@
         exit(-1);
     }
 
+    // FIXME: Missing RAII and try-catch, no LAS throws exceptions.
     std::istream* istrm = OpenInput(input);
     LASReader* reader = new LASReader(*istrm);
     std::cout << "Indexing " << input<< " "<<std::endl;
 
-
     LASIndexDataStream* idxstrm = new LASIndexDataStream(reader);
-
     
     LASIndex* idx = new LASIndex(input);
     idx->SetType(LASIndex::eExternalIndex);
@@ -120,11 +118,8 @@
     idx->SetFillFactor(0.8);
     idx->Initialize(*idxstrm);
 
-
-    
     delete idx;
     delete idxstrm;
     delete reader;
     delete istrm;
-    
 }