[Liblas-devel] Design/architecture questions

[Howard Butler]

Mateusz,

I have now completed refactoring of the liblas::Reader and liblas::Writer classes as well as implementing factories for each, but I have a question.  What should the factories be producing?   ReaderIPtr's or liblas::Reader instances?

They currently produce liblas::Reader instances who's pimpl is a ReaderIPtr.  If you want to create your own liblas::Reader with a ReaderI, you must put it in a shared_ptr and issue the factory method.  See <http://hg.liblas.org/main/file/tip/include/liblas/factory.hpp>.

Look good?

Howard