[mapguide-commits] r4947 - sandbox/maestro-2.5/Maestro.Base

svn_mapguide at osgeo.org svn_mapguide at osgeo.org
Wed Jun 16 06:58:52 EDT 2010


Author: jng
Date: 2010-06-16 10:58:52 +0000 (Wed, 16 Jun 2010)
New Revision: 4947

Modified:
   sandbox/maestro-2.5/Maestro.Base/TabFactory.cs
Log:
Add a big fat warning about the perils of using TabControl in Mono

Modified: sandbox/maestro-2.5/Maestro.Base/TabFactory.cs
===================================================================
--- sandbox/maestro-2.5/Maestro.Base/TabFactory.cs	2010-06-16 10:45:57 UTC (rev 4946)
+++ sandbox/maestro-2.5/Maestro.Base/TabFactory.cs	2010-06-16 10:58:52 UTC (rev 4947)
@@ -31,6 +31,15 @@
         public TabPage Tab { get; set; }
     }
 
+    // A BIG NOTE TO ANYONE THINKING ABOUT HACKING THIS CODE:
+    //
+    // There are 2 ways to handle tab selections (setting/getting):
+    // - Using the SelectedTab property of TabControl
+    // - Using the SelectedIndex property of TabControl and fetching the relevant tab from its TabPages collection
+    //
+    // Mono (2.4) has a buggy implementation of TabControl and will do crazy things if you use the SelectedTab property. 
+    // So if you're ever hacking code that involves setting or getting a selected tab, NEVER USE THE SelectedTab PROPERTY!
+
     internal static class TabFactory
     {
         private static List<HiddenTab> _hiddenTabs = new List<HiddenTab>();



More information about the mapguide-commits mailing list