[mapguide-trac] #1866: Refine FDO join shortcut implementation

[MapGuide Open Source]

#1866: Refine FDO join shortcut implementation
------------------------+---------------------------------------------------
   Reporter:  jng       |       Owner:     
       Type:  task      |      Status:  new
   Priority:  high      |   Milestone:  2.4
  Component:  Server    |     Version:     
   Severity:  critical  |    Keywords:     
External_id:            |  
------------------------+---------------------------------------------------
 It seems I have been barking up the wrong tree somewhat. For some reasons,
 I was led to believe the new FDO join APIs were somehow baked into the
 FdoIExtendedSelect command, thus the wrong assumption that FDO join
 support was limited to the SupportsJoins() capability and support for the
 FdoIExtendedSelect command

 This is false, the required join bits (SetAlias(), GetJoinCriteria())
 actually exist in the basic FdoISelect command, so we only need to check
 the SupportsJoins() capability before apply the additional shortcut
 checks.

 As a result, the ExtendedSelectCommand that's been implemented is totally
 not required and can be removed as part of this cleanup.

 These changes will make the FDO join shortcut also work with the SQL
 Server provider.

-- 
Ticket URL: <http://trac.osgeo.org/mapguide/ticket/1866>
MapGuide Open Source <http://mapguide.osgeo.org/>
MapGuide Open Source Internals