[Mapguide-trac] [mapguide-trac] #2312: WMS request fails for Drawing Source Layer

[MapGuide Open Source]

#2312: WMS request fails for Drawing Source Layer
-----------------------------+----------------------------------------------
   Reporter:  fare           |       Owner:                 
       Type:  defect         |      Status:  new            
   Priority:  medium         |   Milestone:                 
  Component:  WMS Interface  |     Version:  2.5.0          
   Severity:  major          |    Keywords:  wms, fail, bbox
External_id:                 |  
-----------------------------+----------------------------------------------

Comment(by fare):

 The problem is in WMSMapUtil.cpp file of HTTPHandler. From line 181 there
 is comment regarding optimization code. The optimization start with
 checking that bbox of layer is inside request bbox.

 {{{
 if(wmsLayerExtent->Contains(extents)){
 }}}

 but problem occur if request bbox is shifted or larger that bbox of layer.
 Code goes to create sptial query filter on data.

 But there is no check if it's dealing with Drawing Source layer!!!.
 Request fails on following line

 {{{
 Ptr<MgClassDefinition> classDef =
 featureService->GetClassDefinition(fsId,schemaName,className);
 }}}

 since there is no schema or class name for drawing layer.

 This section of code needs revisit.

 For work around I'm checking mgLayer->GetFeatureClassName() and if it's
 empty and just continue rendering.(as I understood Drawing Layer doesn't
 have this set)

 {{{
 if(wmsLayerExtent->Contains(extents) ||
 mgLayer->GetFeatureClassName().empty())
 }}}


 I'm not sure what is proper way to patch this up?

-- 
Ticket URL: <http://trac.osgeo.org/mapguide/ticket/2312#comment:1>
MapGuide Open Source <http://mapguide.osgeo.org/>
MapGuide Open Source Internals