<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Ok, I fixed it for all providers, using the GDal / GEOS intersects
operation.<br>
Update OGRFeatureReader::ReadNext(...) to:<br>
<small><tt><br>
bool OgrFeatureReader::ReadNext()<br>
{ <br>
m_sprops.clear();<br>
<br>
if (m_poFeature)<br>
OGRFeature::DestroyFeature(m_poFeature);<br>
<br>
m_poFeature = m_poLayer->GetNextFeature();<br>
<br>
//Ugly hack to fix broken providers, with BBOX only testing<br>
OGRGeometry* spfilter = m_poLayer->GetSpatialFilter();<br>
if (spfilter != NULL)<br>
while (m_poFeature != NULL &&
m_poFeature->GetGeometryRef() != NULL &&
!spfilter->Intersects(m_poFeature->GetGeometryRef()))<br>
{<br>
OGRFeature::DestroyFeature(m_poFeature);<br>
m_poFeature = m_poLayer->GetNextFeature();<br>
}<br>
<br>
return (m_poFeature != NULL);<br>
}</tt></small><br>
<br>
That will work for all the providers, but has a slight overhead as the
features are transfered from the datasource (eg. database) before
testing.<br>
Fixing the OGR provider would be better, but out of the MapGuide scope.<br>
<br>
Also, the skewing fix can now be disabled, but does no harm.<br>
<br>
While I was testing the PostGIS provider, I got annoyed with the lack
of error messages.<br>
You can update the code to this:<br>
<br>
<small><tt>FdoConnectionState OgrConnection::Open()<br>
{<br>
const wchar_t* dsw = GetProperty(PROP_NAME_DATASOURCE);<br>
bool readonly = _wcsnicmp(GetProperty(PROP_NAME_READONLY), L"TRUE",
4) == 0;<br>
<br>
W2A(dsw);<br>
<br>
printf ("Attempt OGR connect to %s \n", mbdsw);<br>
printf ("ReadOnly %d\n", (int)readonly);<br>
<br>
m_poDS = OGRSFDriverRegistrar::Open(mbdsw, !readonly);<br>
if( m_poDS == NULL )<br>
{<br>
std::string str = "Connect failed: "; <br>
str.append(CPLGetLastErrorMsg());<br>
const char* x = str.c_str();<br>
A2W(x);<br>
throw FdoConnectionException::Create(wx);<br>
}<br>
<br>
m_connState = FdoConnectionState_Open;<br>
<br>
return m_connState;<br>
}<br>
</tt></small><br>
This will give the user a slight hint about the problem (eg, bad
connectionstring, username etc.)<br>
<br>
<pre class="moz-signature" cols="72">Regards, Kenneth, GEOGRAF A/S
</pre>
<br>
<br>
Traian Stanev skrev:
<blockquote
cite="mid:0345418B84C1684C8467DC5A2D7EFF6A04C1377D@msgusaebk01.autodesk.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; ">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<!--[if !mso]>
<style>
v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style>
<![endif]-->
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
tt
{mso-style-priority:99;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="Section1">
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);">Sure,
but the actual geometric operation is what matters. If it
ends up doing a BBOX, it would not be right. It needs to do Intersects.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"><o:p> </o:p></span></p>
<div>
<div
style="border-style: solid none none; border-color: rgb(181, 196, 223) -moz-use-text-color -moz-use-text-color; border-width: 1pt medium medium; padding: 3pt 0in 0in;">
<p class="MsoNormal"><b><span
style="font-size: 10pt; font-family: "Tahoma","sans-serif"; color: windowtext;">From:</span></b><span
style="font-size: 10pt; font-family: "Tahoma","sans-serif"; color: windowtext;">
<a class="moz-txt-link-abbreviated" href="mailto:mapguide-users-bounces@lists.osgeo.org">mapguide-users-bounces@lists.osgeo.org</a>
[<a class="moz-txt-link-freetext" href="mailto:mapguide-users-bounces@lists.osgeo.org">mailto:mapguide-users-bounces@lists.osgeo.org</a>] <b>On Behalf Of </b>Kenneth,
GEOGRAF A/S<br>
<b>Sent:</b> Thursday, June 14, 2007 4:15 AM<br>
<b>To:</b> MapGuide Users Mail List<br>
<b>Subject:</b> Re: [mapguide-users] OGR / GEOS selection problem<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">It should not work if you make a polygon
selection.<br>
Tooltip and Click sends a square, so the envelope of the filter should
be the
same as the filter<br>
<br>
<o:p></o:p></p>
<pre>Regards, Kenneth, GEOGRAF A/S<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<p class="MsoNormal"><br>
<br>
Traian Stanev skrev: <o:p></o:p></p>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Wait, from this it looks like it takes the BBOX
(envelope)
of the filter and sends that to PostGIS...? That may explain things.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote
style="margin-top: 5pt; margin-right: 0in; margin-bottom: 5pt;">
<div>
<p class="MsoNormal" style="margin-bottom: 12pt;"><span
style="font-size: 10pt;">-----Original
Message----- <br>
<b>From:</b> <a moz-do-not-send="true"
href="mailto:mapguide-users-bounces@lists.osgeo.org">mapguide-users-bounces@lists.osgeo.org</a> on
behalf of Kenneth, GEOGRAF A/S <br>
<b>Sent:</b> Wed 6/13/2007 5:42 PM <br>
<b>To:</b> MapGuide Users Mail List <br>
<b>Cc:</b> <br>
<b>Subject:</b> Re: [mapguide-users] OGR / GEOS selection problem</span><o:p></o:p></p>
</div>
<p class="MsoNormal">It is actually forwarded to PostGIS:<br>
<br>
<tt><span style="font-size: 10pt;">
OGREnvelope sEnvelope;</span></tt><span
style="font-size: 10pt; font-family: "Courier New";"><br>
<br>
<tt> m_poFilterGeom->getEnvelope(
&sEnvelope );</tt><br>
<tt> osWHERE.Printf("WHERE %s
&& SetSRID('BOX3D(%.12f %.12f, %.12f %.12f)'::box3d,%d) ",</tt><br>
<tt>
pszGeomColumn,</tt><br>
<tt>
sEnvelope.MinX, sEnvelope.MinY,</tt><br>
<tt>
sEnvelope.MaxX, sEnvelope.MaxY,</tt><br>
<tt>
nSRSId );</tt><br>
</span><br>
<br>
Not too good with PostGIS syntax, but since the m_poFilterGeom is the
filter
used (a small square in this case) it reads:<br>
"Select from geometry_column where features are within the bbox of the
filer"<br>
<br>
Which should be quite ok, unless they have a similar idea of optimizing
this to
a BBOX test, as OGR does.<br>
<br>
Anyway, I can confirm that Traians fix works with MapInfo TAB files,
but NOT
with PostGIS :(<br>
<br>
<br>
<o:p></o:p></p>
<pre>Regards, Kenneth, GEOGRAF A/S<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<p class="MsoNormal"><br>
<br>
Traian Stanev skrev: <o:p></o:p></p>
<pre>To put test data into PostGres I use the tool that comes with it that<o:p></o:p></pre>
<pre>can import SHP files into the database.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>I think it's called shp2pgsql.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Traian<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>-----Original Message-----<o:p></o:p></pre>
<pre>From: <a moz-do-not-send="true"
href="mailto:mapguide-users-bounces@lists.osgeo.org">mapguide-users-bounces@lists.osgeo.org</a><o:p></o:p></pre>
<pre>[<a moz-do-not-send="true"
href="mailto:mapguide-users-bounces@lists.osgeo.org">mailto:mapguide-users-bounces@lists.osgeo.org</a>] On Behalf Of Kenneth,<o:p></o:p></pre>
<pre>GEOGRAF A/S<o:p></o:p></pre>
<pre>Sent: Wednesday, June 13, 2007 3:21 PM<o:p></o:p></pre>
<pre>To: MapGuide Users Mail List<o:p></o:p></pre>
<pre>Subject: Re: [mapguide-users] OGR / GEOS selection problem<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>I tried it with MapInfo TAB files, and it works fine.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Maciej, can you post an SQL dump of one of the PostGIS tables?<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>I have installed PostGIS on my machine for testing, but I have no data, <o:p></o:p></pre>
<pre>and no luck getting Fdo2Fdo working with FDO OGR.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Regards, Kenneth, GEOGRAF A/S<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Traian Stanev skrev:<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<blockquote style="margin-top: 5pt; margin-bottom: 5pt;">
<pre>Well, I only tried it with SHP files and am pretty sure it fixed the<o:p></o:p></pre>
<pre>problem for SHP files (I did a before and after test, on a polygon<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
</blockquote>
<pre>that<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<blockquote style="margin-top: 5pt; margin-bottom: 5pt;">
<pre>had the same problem as your screenshot). May be the PostGIS OGR<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
</blockquote>
<pre>driver<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<blockquote style="margin-top: 5pt; margin-bottom: 5pt;">
<pre>does something else, like forward the spatial filter to PostGIS? In<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
</blockquote>
<pre>that<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<blockquote style="margin-top: 5pt; margin-bottom: 5pt;">
<pre>case, may be I need to upgrade my PostGIS SDK...? Anybody know the<o:p></o:p></pre>
<pre>answer to that one?<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Traian<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>-----Original Message-----<o:p></o:p></pre>
<pre>From: <a moz-do-not-send="true"
href="mailto:mapguide-users-bounces@lists.osgeo.org">mapguide-users-bounces@lists.osgeo.org</a><o:p></o:p></pre>
<pre>[<a moz-do-not-send="true"
href="mailto:mapguide-users-bounces@lists.osgeo.org">mailto:mapguide-users-bounces@lists.osgeo.org</a>] On Behalf Of Maciej<o:p></o:p></pre>
<pre>Skorczewski<o:p></o:p></pre>
<pre>Sent: Wednesday, June 13, 2007 12:29 PM<o:p></o:p></pre>
<pre>To: MapGuide Users Mail List<o:p></o:p></pre>
<pre>Subject: Re: [mapguide-users] OGR / GEOS selection problem<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Traian<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>i have still this same error...<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>take a look on screen.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><a moz-do-not-send="true"
href="http://imagepolis.com/images/20070613819095046.JPG">http://imagepolis.com/images/20070613819095046.JPG</a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><a moz-do-not-send="true"
href="http://imagepolis.com/images/20070613818181055.JPG">http://imagepolis.com/images/20070613818181055.JPG</a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><a moz-do-not-send="true"
href="http://imagepolis.com/images/20070613434408347.JPG">http://imagepolis.com/images/20070613434408347.JPG</a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Maciek<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>ps. and i still can't use SetSelectionXML...<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre> <o:p></o:p></pre>
</blockquote>
<pre><a moz-do-not-send="true"
href="http://www.nabble.com/SetSelectionXML-on-layer-from-database-%28PostgreS">http://www.nabble.com/SetSelectionXML-on-layer-from-database-%28PostgreS</a><o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<blockquote style="margin-top: 5pt; margin-bottom: 5pt;">
<pre>QL-%3EPostgGIS%29-tf3900386s16610.html<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>(tiny of this url to forum)<o:p></o:p></pre>
<pre><a moz-do-not-send="true" href="http://tiny.pl/fdtn">http://tiny.pl/fdtn</a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>maciek skorczewski<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>_______________________________________________<o:p></o:p></pre>
<pre>mapguide-users mailing list<o:p></o:p></pre>
<pre><a moz-do-not-send="true"
href="mailto:mapguide-users@lists.osgeo.org">mapguide-users@lists.osgeo.org</a><o:p></o:p></pre>
<pre><a moz-do-not-send="true"
href="http://lists.osgeo.org/mailman/listinfo/mapguide-users">http://lists.osgeo.org/mailman/listinfo/mapguide-users</a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>_______________________________________________<o:p></o:p></pre>
<pre>mapguide-users mailing list<o:p></o:p></pre>
<pre><a moz-do-not-send="true"
href="mailto:mapguide-users@lists.osgeo.org">mapguide-users@lists.osgeo.org</a><o:p></o:p></pre>
<pre><a moz-do-not-send="true"
href="http://lists.osgeo.org/mailman/listinfo/mapguide-users">http://lists.osgeo.org/mailman/listinfo/mapguide-users</a><o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre> <o:p></o:p></pre>
</blockquote>
<pre>_______________________________________________<o:p></o:p></pre>
<pre>mapguide-users mailing list<o:p></o:p></pre>
<pre><a moz-do-not-send="true"
href="mailto:mapguide-users@lists.osgeo.org">mapguide-users@lists.osgeo.org</a><o:p></o:p></pre>
<pre><a moz-do-not-send="true"
href="http://lists.osgeo.org/mailman/listinfo/mapguide-users">http://lists.osgeo.org/mailman/listinfo/mapguide-users</a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>_______________________________________________<o:p></o:p></pre>
<pre>mapguide-users mailing list<o:p></o:p></pre>
<pre><a moz-do-not-send="true"
href="mailto:mapguide-users@lists.osgeo.org">mapguide-users@lists.osgeo.org</a><o:p></o:p></pre>
<pre><a moz-do-not-send="true"
href="http://lists.osgeo.org/mailman/listinfo/mapguide-users">http://lists.osgeo.org/mailman/listinfo/mapguide-users</a><o:p></o:p></pre>
<pre> <o:p></o:p></pre>
</blockquote>
<pre><o:p> </o:p></pre>
<pre style="text-align: center;">
<hr align="center" size="4" width="90%">
</pre>
<pre><o:p> </o:p></pre>
<pre>_______________________________________________<o:p></o:p></pre>
<pre>mapguide-users mailing list<o:p></o:p></pre>
<pre><a moz-do-not-send="true"
href="mailto:mapguide-users@lists.osgeo.org">mapguide-users@lists.osgeo.org</a><o:p></o:p></pre>
<pre><a moz-do-not-send="true"
href="http://lists.osgeo.org/mailman/listinfo/mapguide-users">http://lists.osgeo.org/mailman/listinfo/mapguide-users</a><o:p></o:p></pre>
<pre> <o:p></o:p></pre>
</div>
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
mapguide-users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:mapguide-users@lists.osgeo.org">mapguide-users@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="http://lists.osgeo.org/mailman/listinfo/mapguide-users">http://lists.osgeo.org/mailman/listinfo/mapguide-users</a>
</pre>
</blockquote>
</body>
</html>