<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD><TITLE>MapGuide Open Source 1.1.0 RC2</TITLE>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<META content="MSHTML 6.00.2900.3020" name=GENERATOR></HEAD>
<BODY>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2>Hi Tom,</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2>The check went into trunk as part of a much larger
submission. After some testing, I have noticed that this code does not
correctly detect the difference between a garbled stream and a stream of
the wrong version. They are all detected as wrong version so I will need
to add some additional logic to discriminate between the two cases. Here
are the relevant lines of code from the original
submission:</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2>From StreamParser::ParseStreamHeader</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2>Index:
StreamParser.cpp<BR>===================================================================<BR>---
StreamParser.cpp (revision 737)<BR>+++
StreamParser.cpp (revision 1028)<BR>@@ -77,6 +77,12
@@<BR>
ret =
true;<BR>
}<BR>
}<BR>+<BR>+ if (ret == false ||
MgStreamParser::StreamVersion !=
pStreamData->GetVersion())<BR>+
{<BR>+ throw
new MgStreamIoException(L"MgStreamParser.ParseStreamHeader", __LINE__,
__WFILE__, NULL, L"MgInvalidTC<BR>PProtocol",
NULL);<BR>+
}<BR>+<BR> }</FONT></SPAN></DIV>
<DIV><FONT face=Arial color=#0000ff size=2></FONT> </DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2> return ret;</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2>From MgCommand::GetResponse</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2>Index:
Command.cpp<BR>===================================================================<BR>---
Command.cpp (revision 770)<BR>+++ Command.cpp (revision 1028)<BR>@@ -141,6
+141,12 @@</FONT></SPAN></DIV>
<DIV><FONT face=Arial color=#0000ff size=2></FONT> </DIV>
<DIV dir=ltr align=left><SPAN class=767270617-08012007><FONT face=Arial
color=#0000ff size=2> // Get the stream header i.e.
stream_start, stream_data etc.<BR>
ptrStream->GetStreamHeader(msh);<BR>+<BR>+ if
(MgStreamParser::mshStreamStart != msh.m_streamStart ||
MgStreamParser::StreamVersion != msh.m_streamVersion)<BR>+
{<BR>+ throw new
MgStreamIoException(L"MgCommand.GetResponse", __LINE__, __WFILE__, NULL,
L"MgInvalidTCPProtocol", NUL<BR>L);<BR>+
}<BR>+<BR> // Get the operation response
header<BR>
ptrStream->GetOperationResponseHeader(morp);<BR> //
Process the result based on eCode. In case of exception, it would throw the
exception<BR></FONT></SPAN></DIV><BR>
<DIV class=OutlookMessageHeader lang=en-us dir=ltr align=left>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> Tom Fukushima <BR><B>Sent:</B> Monday,
January 08, 2007 10:00 AM<BR><B>To:</B> Trevor Wekel;
'mapguide_dev@lists.osgeo.org'<BR><B>Subject:</B> RE: [Mapguide_dev] MapGuide
Open Source 1.1.0 RC2<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV dir=ltr align=left><SPAN class=424315816-08012007><FONT face=Arial
color=#0000ff size=2>Hi Trevor,</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=424315816-08012007><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=424315816-08012007><FONT face=Arial
color=#0000ff size=2>I would like to get an idea of the risk and size of the
change. Can you give me the revision numbers for the submissions for this
to the trunk?</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=424315816-08012007><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=424315816-08012007><FONT face=Arial
color=#0000ff size=2>Thanks</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=424315816-08012007><FONT face=Arial
color=#0000ff size=2>Tom</FONT></SPAN></DIV><BR>
<DIV class=OutlookMessageHeader lang=en-us dir=ltr align=left>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> Trevor Wekel <BR><B>Sent:</B> Monday,
January 08, 2007 9:42 AM<BR><B>To:</B> Tom Fukushima;
mapguide_dev@lists.osgeo.org<BR><B>Subject:</B> RE: [Mapguide_dev] MapGuide Open
Source 1.1.0 RC2<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV dir=ltr align=left><SPAN class=544263616-08012007><FONT face=Arial
color=#0000ff size=2>Hi Tom,</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=544263616-08012007><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=544263616-08012007><FONT face=Arial
color=#0000ff size=2>I would like to put a TCP/IP stream version check
in the 1.1.0 release to help catch versioning issues between the Web
Extensions and Server code bases. Over time, improvements in the TCP/IP
protocol will be made. Some of these improvements could break
compatibility with older releases.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=544263616-08012007><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=544263616-08012007><FONT face=Arial
color=#0000ff size=2>Thanks,</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=544263616-08012007><FONT face=Arial
color=#0000ff size=2>Trevor</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=544263616-08012007><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV><BR>
<DIV class=OutlookMessageHeader lang=en-us dir=ltr align=left>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> mapguide_dev-bounces@lists.osgeo.org
[mailto:mapguide_dev-bounces@lists.osgeo.org] <B>On Behalf Of </B>Tom
Fukushima<BR><B>Sent:</B> Sunday, January 07, 2007 9:26 PM<BR><B>To:</B>
mapguide_dev@lists.osgeo.org<BR><B>Subject:</B> [Mapguide_dev] MapGuide Open
Source 1.1.0 RC2<BR></FONT><BR></DIV>
<DIV></DIV><!-- Converted from text/rtf format -->
<P><FONT face=Arial size=2>Hi,</FONT> </P>
<P><FONT face=Arial size=2>I would like to release MapGuide Open Source 1.1.0
RC2 in a couple of weeks. This means that approved defect submissions to the
1.1.0 stream need to be made by next weekend. If you have a defect fix
that you would like to submit, please send it to this list for review. If
it is a security related defect fix, please send it to me directly for
review.</FONT></P>
<P><FONT face=Arial size=2>Thanks</FONT> <BR><FONT face=Arial size=2>Tom</FONT>
</P><BR></BODY></HTML>