<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>+1</p>
<p><br>
</p>
<p>Greetings,</p>
<p>Johannes<br>
</p>
<div class="moz-cite-prefix">Am 13.01.21 um 08:36 schrieb Julien R:<br>
</div>
<blockquote type="cite"
cite="mid:CAH5xAhATAqDQkfFoMDMO4PWhta2T5hdkXgb-=JMXZpEfwLhE-g@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div>Hello,</div>
<div><br>
</div>
<div>I would like to propose adding linting to the mapproxy
codebase and enforce it on the CI. The benefits of linting are
mostly that they make reviews easier because reviewers don't
have to point stylistic issues.</div>
<div><br>
</div>
<div>Johannes Weskamm originally proposed to introduce linting
in this github issue:</div>
<div><a href="https://github.com/mapproxy/mapproxy/issues/478"
moz-do-not-send="true">https://github.com/mapproxy/mapproxy/issues/478</a></div>
<div><br>
</div>
<div>I personally have experience with using flake8
professionally for multiple years and it works great. I
started experimenting with setting up flake8 on the CI here:</div>
<div><a href="https://github.com/mapproxy/mapproxy/pull/486"
moz-do-not-send="true">https://github.com/mapproxy/mapproxy/pull/486</a></div>
<div><br>
</div>
<div>If this is accepted, the plan would be to:</div>
<div>- Introduce flake8 on CI, but disable all errors at first</div>
<div>- Enable errors one by one in separate commits</div>
<div><br>
</div>
<div>This is to avoid submitting a massive PR touching
everything. See the attached 'mapproxy_flake8_stats.txt' file
for statistics about the "errors" found by flake8.</div>
<div><br>
</div>
<div>Best regards,</div>
<div>Julien<br>
</div>
<div><br>
</div>
<div>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>--</div>
<div>Julien Rebetez</div>
<div>Lead Software & Machine
Learning Engineer</div>
<div>Picterra SA</div>
Rue de la Mouline 8, 1022 Chavannes,
Switzerland</div>
<div><a
href="https://picterra.ch/?utm_source=signature&utm_medium=email&utm_campaign=43989-en-pt-email%20signature&utm_content=link"
target="_blank"
moz-do-not-send="true">www.picterra.ch</a></div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
MapProxy-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:MapProxy-dev@lists.osgeo.org">MapProxy-dev@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/mapproxy-dev">https://lists.osgeo.org/mailman/listinfo/mapproxy-dev</a>
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Dipl.-Geogr. Johannes Weskamm
— Anwendungsentwickler —
terrestris GmbH & Co. KG
Kölnstraße 99
53111 Bonn
Tel: +49 (0)228 / 96 28 99 -555
Fax: +49 (0)228 / 96 28 99 -57
Email: <a class="moz-txt-link-abbreviated" href="mailto:weskamm@terrestris.de">weskamm@terrestris.de</a>
Web: <a class="moz-txt-link-freetext" href="https://www.terrestris.de">https://www.terrestris.de</a>
Amtsgericht Bonn, HRA 6835
Komplementärin: terrestris Verwaltungsgesellschaft mbH
vertreten durch: Torsten Brassat, Marc Jansen
Informationen über Ihre gespeicherten Daten finden Sie auf
unserer Homepage unter folgendem Link:
<a class="moz-txt-link-freetext" href="https://www.terrestris.de/datenschutzerklaerung/">https://www.terrestris.de/datenschutzerklaerung/</a> </pre>
</body>
</html>