<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">I'm 0 on this.<div class=""><br class=""><div class="">The benefits are there, but the IMO huge downside is that it "destroys" the history of the code (git blame, etc.).<br class=""></div></div><div class="">It would see this different if there is ongoing active development, but most parts are quite stable, were not changed in recent years and will likely not be edited in the near future. </div><div class=""><br class=""></div><div class="">All the best,</div><div class="">Oliver</div><div><br class=""><blockquote type="cite" class=""><div class="">On 13. Jan 2021, at 08:36, Julien R <<a href="mailto:julien.rebetez@picterra.ch" class="">julien.rebetez@picterra.ch</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">Hello,</div><div class=""><br class=""></div><div class="">I would like to propose adding linting to the mapproxy codebase and enforce it on the CI. The benefits of linting are mostly that they make reviews easier because reviewers don't have to point stylistic issues.</div><div class=""><br class=""></div><div class="">Johannes Weskamm originally proposed to introduce linting in this github issue:</div><div class=""><a href="https://github.com/mapproxy/mapproxy/issues/478" class="">https://github.com/mapproxy/mapproxy/issues/478</a></div><div class=""><br class=""></div><div class="">I personally have experience with using flake8 professionally for multiple years and it works great. I started experimenting with setting up flake8 on the CI here:</div><div class=""><a href="https://github.com/mapproxy/mapproxy/pull/486" class="">https://github.com/mapproxy/mapproxy/pull/486</a></div><div class=""><br class=""></div><div class="">If this is accepted, the plan would be to:</div><div class="">- Introduce flake8 on CI, but disable all errors at first</div><div class="">- Enable errors one by one in separate commits</div><div class=""><br class=""></div><div class="">This is to avoid submitting a massive PR touching everything. See the attached 'mapproxy_flake8_stats.txt' file for statistics about the "errors" found by flake8.</div><div class=""><br class=""></div><div class="">Best regards,</div><div class="">Julien<br class=""></div><div class=""><br class=""></div><div class=""><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class="">--</div><div class="">Julien Rebetez</div><div class="">Lead Software & Machine Learning Engineer</div><div class="">Picterra SA</div>Rue de la Mouline 8, 1022 Chavannes, Switzerland</div><div class=""><a href="https://picterra.ch/?utm_source=signature&utm_medium=email&utm_campaign=43989-en-pt-email%20signature&utm_content=link" target="_blank" class="">www.picterra.ch</a></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
<span id="cid:f_kjv3x7bl0"><mapproxy_flake8_stats.txt></span>_______________________________________________<br class="">MapProxy-dev mailing list<br class=""><a href="mailto:MapProxy-dev@lists.osgeo.org" class="">MapProxy-dev@lists.osgeo.org</a><br class="">https://lists.osgeo.org/mailman/listinfo/mapproxy-dev<br class=""></div></blockquote></div><br class=""></body></html>