[mapserver-commits] r9928 - trunk/mapserver

svn at osgeo.org svn at osgeo.org
Tue Mar 9 16:35:00 EST 2010


Author: assefa
Date: 2010-03-09 16:34:59 -0500 (Tue, 09 Mar 2010)
New Revision: 9928

Modified:
   trunk/mapserver/mapwfs.c
Log:
Empty strings in the request url should generate a missing parameter exception (#3300)

Modified: trunk/mapserver/mapwfs.c
===================================================================
--- trunk/mapserver/mapwfs.c	2010-03-07 22:29:44 UTC (rev 9927)
+++ trunk/mapserver/mapwfs.c	2010-03-09 21:34:59 UTC (rev 9928)
@@ -2082,7 +2082,7 @@
   /* VERSION *and* REQUEST *and* SERVICE required by all WFS requests including 
    * GetCapabilities.
    */
-  if (paramsObj->pszVersion==NULL)
+  if (paramsObj->pszVersion==NULL || strlen(paramsObj->pszVersion)<=0)
   {
       msSetError(MS_WFSERR, 
                  "Incomplete WFS request: VERSION parameter missing", 
@@ -2094,8 +2094,8 @@
       paramsObj = NULL;
       return returnvalue;
   }
-
-  if (paramsObj->pszRequest==NULL)
+  
+  if (paramsObj->pszRequest==NULL || strlen(paramsObj->pszRequest)<=0)
   {
       msSetError(MS_WFSERR, 
                  "Incomplete WFS request: REQUEST parameter missing", 
@@ -2106,8 +2106,8 @@
       paramsObj = NULL;
       return returnvalue;
   }
-
-  if (paramsObj->pszService==NULL)
+  
+  if (paramsObj->pszService==NULL || strlen(paramsObj->pszService)<=0)
   {
       msSetError(MS_WFSERR, 
                  "Incomplete WFS request: SERVICE parameter missing", 



More information about the mapserver-commits mailing list