[PATCH] Typo in mapwms.c (and lots of warnings)

[Daniel Morissette]

Petter Reinholdtsen wrote:
> [Yewondwossen Assefa]
>
>>Thnaks. I applied the patch in main brach as well as the 4.4.x
>>branch.
>
>
> Thank you.  Did you only apply the code fix, or did you increase the
> default warning level as well?
>

Assefa is not setup to test on Linux, so I presume that he only applied
the source code fix and didn't touch the configure script.


> [Frank Warmerdam]
>
>>I would suggest submitting these as bugzilla reports with the
>>patches attached.  Likewise for the sortshp.c change, and the UNUSED
>>changes.  I tried applying the sortshp.c patch with the patch
>>program and it didn't work.
>
>
> I'm confused.  Should I submit to bugzilla, or should I send to this
> mailing list?  I've been told to to both, and am not sure what is
> prefered.
>

For large changes, bugs are definitely the way to go. For one-line
changes, I personally think that it's still worth creating a bug so that
we have a trace of why the patch was applied, which problem it is
supposed to fix, etc... but not everybody agrees. Bugs also have the
benefit that they are not likely to end up being lost and forgotten
under a pile of 200 emails: they stay in the database until they are
addressed.

My opinion is that you should file bugs, and perhaps notify the list
after if you want to trigger immediate replies.

Thanks!

Daniel
--
------------------------------------------------------------
  Daniel Morissette               dmorissette at dmsolutions.ca
  DM Solutions Group              http://www.dmsolutions.ca/
------------------------------------------------------------