mapagg.cpp fixes, and outstanding issues

[Zak James]

Steve,

When configuring trunk with php mapscript on OS X 10.4.9 (gcc 4.0.1),
it's neccessary to add agg to MS_STATIC to avoid a php crash when
rendering with the agg outputformat. I'm not sure if this is a quirk
of Apple's modified linker. I also need to build agg with -fPIC.

zak

On 7/17/07, Steve Lime <Steve.Lime at dnr.state.mn.us> wrote:
> Yes this is expected, configure.in doesn't make any assumption about where AGG might
> be installed. I see that the GD section does a check in /usr and /usr/local. I can try and
> implement that (but after the 23rd).
>
> Steve
>
> >>> On 7/17/2007 at 2:08 AM, in message
> <75b4b93e0707170008t14cdcd6bv30f0b186a3015e81 at mail.gmail.com>, Umberto
>
> Nicoletti <umberto.nicoletti at GMAIL.COM> wrote:
> > I thought I had enabled agg support and I find out only now that
> > mapserver configure script fails to detect my agg installation unless
> > I use this option:
> >
> > --with-agg=/usr
> >
> > Is this the expected behaviour?
> > I am on ubuntu feisty (32 bit).
> >
> > Umberto
> >
> > On 7/17/07, Frank Warmerdam <warmerdam at pobox.com> wrote:
> >> Folks,
> >>
> >> I updated mapagg.cpp to build. I think Umberto changed the symbolset but
> >> this wasn't accounted for in mapagg.cpp.
> >>
> >> I also removed some unused variables, and fixed C++ initializer order
> >> related warnings.
> >>
> >> But there are still several warnings left:
> >>
> >> mapagg.cpp: In function `void msDrawMarkerSymbolAGGEllipse(symbolObj*,
> > double,
> >> double, double, char, styleObj*, int, int, int, int, gdImage*, pointObj*)':
> >> mapagg.cpp:535: warning: passing `double' for converting 7 of `void
> >> gdImageFilledArc(gdImage*, int, int, int, int, int, int, int, int)'
> >> mapagg.cpp:536: warning: passing `double' for converting 7 of `void
> >> gdImageFilledArc(gdImage*, int, int, int, int, int, int, int, int)'
> >> mapagg.cpp:540: warning: passing `double' for converting 7 of `void
> >> gdImageFilledArc(gdImage*, int, int, int, int, int, int, int, int)'
> >> mapagg.cpp: In function `void msDrawMarkerSymbolAGGVector(symbolObj*,
> > double,
> >> double, double, char, styleObj*, int, int, int, int, gdImage*, pointObj*,
> >> imageObj*)':
> >> mapagg.cpp:557: warning: 'width' might be used uninitialized in this
> > function
> >> mapagg.cpp: In function `void msDrawMarkerSymbolAGG(symbolSetObj*,
> > imageObj*,
> >> pointObj*, styleObj*, double)':
> >> mapagg.cpp:687: warning: 'offset_x' might be used uninitialized in this
> > function
> >> mapagg.cpp:687: warning: 'offset_y' might be used uninitialized in this
> > function
> >> mapagg.cpp:689: warning: 'd' might be used uninitialized in this function
> >> mapagg.cpp: At global scope:
> >> mapagg.cpp:331: warning: 'void imageFilledPolygon2(imageObj*, shapeObj*,
> >> colorObj*, int, int)' defined but not used
> >> mapagg.cpp:904: warning: 'nmsTransformShapeAGG' defined but not used
> >>
> >> Several of these seem fairly serious.  For instance width, offset_x and
> >> offset_y seem to be used variables but never set anywhere!
> >>
> >> I'd appreciate the module authors reviewing them carefully and
> >> addressing them so we have a fairly clean build.
> >>
> >> Best regards,
> >> --
> >> ---------------------------------------+--------------------------------------
> >> I set the clouds in motion - turn up   | Frank Warmerdam, warmerdam at pobox.com
> >> light and sound - activate the windows | http://pobox.com/~warmerdam
> >> and watch the world go round - Rush    | President OSGeo, http://osgeo.org
> >>
>


-- 
Zak James
Applications and Software Development
DM Solutions Group Inc.
http://www.dmsolutions.ca