[mapserver-dev] [motion] code formatting and astyle

[thomas bonfort]

Considering this one passed. Unless someone speaks up, I will commit
these changes this evening:
- re-formatted source code
- astyle.sh formatting script (containing our chosen formatting
options and which files to apply them to)

regards,
thomas

On Tue, Jun 26, 2012 at 6:38 PM, Olivier Courtin
<olivier.courtin at oslandia.com> wrote:
>
> On Jun 26, 2012, at 4:27 PM, Daniel Morissette wrote:
>
>> On 12-06-26 9:42 AM, thomas bonfort wrote:
>>>
>>> I have an "astyle" branch, for mapogr.cpp, you can have a look at
>>> https://github.com/tbonfort/mapserver/blob/658a5cd39e6680dd5a752b9b741da52b276c5c57/mapogr.cpp
>>>
>>
>> I reviewed the result with Thomas on IRC, and we found an oddity with the switch/case statements where the "case ..:" header was not indented. So in the end we ended up using the following options which seem to give acceptable result relatively close to SteveL's original style:
>>
>> astyle -—style=kr -—indent-switches -—indent=spaces=2 --lineend=linux --convert-tabs
>>
>> Based on a quick review of mapogr.cpp with that style I am ready to +1 the motion using the options above.
>
> +1
>
> --
> Olivier
>
> _______________________________________________
> mapserver-dev mailing list
> mapserver-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/mapserver-dev