<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2658.24">
<TITLE>RE: [UMN_MAPSERVER-DEV] Crash bug - with fix</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Hey Frank,</FONT>
</P>
<P><FONT SIZE=2>Thanks for posting that.</FONT>
</P>
<P><FONT SIZE=2> I would vote that it goes in 4.6.X because the fix is so low impact and the crash is so bad... Blowing out the stack is impossible to recover from.</FONT></P>
<P><FONT SIZE=2>Thanks,</FONT>
</P>
<P><FONT SIZE=2>Ned.</FONT>
</P>
<P><FONT SIZE=2>-----Original Message-----</FONT>
<BR><FONT SIZE=2>From: fwarmerdam@gmail.com [<A HREF="mailto:fwarmerdam@gmail.com">mailto:fwarmerdam@gmail.com</A>] On Behalf Of Frank Warmerdam</FONT>
<BR><FONT SIZE=2>Sent: Thursday, September 15, 2005 1:17 PM</FONT>
<BR><FONT SIZE=2>To: Ned Harding</FONT>
<BR><FONT SIZE=2>Cc: MAPSERVER-DEV@lists.umn.edu</FONT>
<BR><FONT SIZE=2>Subject: Re: [UMN_MAPSERVER-DEV] Crash bug - with fix</FONT>
</P>
<P><FONT SIZE=2>On 9/15/05, Ned Harding <nharding@extendthereach.com> wrote:</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> freeFeatureList (mapfile.c) frees a list recursively, so if you have a </FONT>
<BR><FONT SIZE=2>> lot of things on the list it causes a stack fault. This happens (on </FONT>
<BR><FONT SIZE=2>> my machine) with a line layer with overlays with about 4000 objects. </FONT>
<BR><FONT SIZE=2>> It should be changed to free in a loop so that it doesn't blow out the </FONT>
<BR><FONT SIZE=2>> stack. The old code and new fixed code is below. Can someone review </FONT>
<BR><FONT SIZE=2>> it and check it in to CVS for me? Note my loop does change the order </FONT>
<BR><FONT SIZE=2>> of freeing from last->first to first->last. It doesn't appear to matter in this situation.</FONT>
</P>
<P><FONT SIZE=2>Ned, </FONT>
</P>
<P><FONT SIZE=2>I have applied the patch in 4.7. If you think it is critical enough to go into 4.6.2 (should such a thing be released) then let me know.</FONT></P>
<P><FONT SIZE=2>Best regards,</FONT>
<BR><FONT SIZE=2>-- </FONT>
<BR><FONT SIZE=2>---------------------------------------+--------------------------------</FONT>
<BR><FONT SIZE=2>---------------------------------------+------</FONT>
<BR><FONT SIZE=2>I set the clouds in motion - turn up | Frank Warmerdam, warmerdam@pobox.com</FONT>
<BR><FONT SIZE=2>light and sound - activate the windows | <A HREF="http://pobox.com/~warmerdam" TARGET="_blank">http://pobox.com/~warmerdam</A></FONT>
<BR><FONT SIZE=2>and watch the world go round - Rush | Geospatial Programmer for Rent</FONT>
</P>
</BODY>
</HTML>