Hi Thomas,<br><br>I'd be curious to know what level of detail will be chosen when selecting the functions to be exposed in the vtable. I thought we'll probably select those functions/operatons which are currently provide the branching between the renderers.<br>
In this particular case we would probably add a DrawMarkerSymbol to represent the renderer specific msDrawMarkerSymbolGD / msDrawMarkerSymbolAGG etc, variations.<br>In this regard it remains up to the renderer how the default symbol is drawn in effect.<br>
<br>Would you describe in more details what you have in your mind about the desired vtable architecture, I'm really interested in.<br><br>Best regards,<br><br>Tamas<br><br><br><br><br><div class="gmail_quote">2009/2/5 thomas bonfort <span dir="ltr"><<a href="mailto:thomas.bonfort@gmail.com">thomas.bonfort@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Tamas,<br>
those kind of inconsistencies (as there are quite a few others) will<br>
hopefully be a thing of the past once we switch to the vtable<br>
rendering architecture. I'd favor leaving things as they are for 5.4<br>
and wait for 6.0 for introducing and documenting these changes.<br>
<br>
best regards,<br>
thomas<br>
<div><div></div><div class="Wj3C7c"><br>
On Thu, Feb 5, 2009 at 01:19, Tamas Szekeres <<a href="mailto:szekerest@gmail.com">szekerest@gmail.com</a>> wrote:<br>
> Folks,<br>
><br>
> Currently the GD and AGG renderer behaves differently when drawing a point<br>
> with no symbol specified. In the code I can see something like for AGG<br>
><br>
> if(style->symbol == 0) { // simply draw a circle of the specified color<br>
><br>
> ren->renderEllipse(p->x+ox,p->y+oy,size,size,0,agg_color,agg_ocolor,width);<br>
> return;<br>
> }<br>
><br>
> The corresponding code for GD looks like:<br>
><br>
> if(style->symbol == 0 && fc >= 0) { /* simply draw a single pixel of the<br>
> specified color */<br>
> gdImageSetPixel(img, (int)(p->x + ox), (int)(p->y + oy), fc);<br>
> return;<br>
> }<br>
><br>
><br>
> Wouldn't it be reasonable to use the same approach for the different<br>
> renderers? I would prefer the AGG version to be followed.<br>
><br>
><br>
> Best regards,<br>
><br>
> Tamas<br>
><br>
><br>
><br>
</div></div>> _______________________________________________<br>
> mapserver-dev mailing list<br>
> <a href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a><br>
> <a href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><br>
><br>
><br>
</blockquote></div><br>