Steve,<br><br>I've set the default size to 1. I prefer this option since there are many places in the code where this division is not related to the scale calculation like for example in msCircleDrawShadeSymbolAGG when rendering an ellipse symbol.<br>
If anyone find issues with this setting please update <a href="http://trac.osgeo.org/mapserver/ticket/2896">http://trac.osgeo.org/mapserver/ticket/2896</a> accordingly.<br><br>Best regards,<br><br>Tamas<br><br><br><br><br>
<br><div class="gmail_quote">2009/2/18 Steve Lime <span dir="ltr"><<a href="mailto:Steve.Lime@dnr.state.mn.us">Steve.Lime@dnr.state.mn.us</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I'm pretty sure this is ok. Could either set size to 1 or set the scale to 1 if the sizey is<br>
0. Some code in mapgd.c does just that. The latter would be less risky but more work.<br>
<br>
Steve<br>
<br>
>>> Tamas Szekeres <<a href="mailto:szekerest@gmail.com">szekerest@gmail.com</a>> 02/17/09 4:20 PM >>><br>
<div class="Ih2E3d">Steve,<br>
<br>
I'd be in favour of fixing the division by zero problem I've reported<br>
previously (see below) before the beta.<br>
However I'm waiting for someone who confirms that there would be no negative<br>
impact on setting the symbol sizex/sizey to 1 instead of 0 by default.<br>
<br>
Best regards,<br>
Tamas<br>
<br>
<br>
<br>
---------- Forwarded message ----------<br>
From: Tamas Szekeres <<a href="mailto:szekerest@gmail.com">szekerest@gmail.com</a>><br>
Date: 2009/2/15<br>
Subject: Division by zero problem in mapserver<br>
To: MapServer Dev Mailing List <<a href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a>><br>
<br>
<br>
Hi Devs,<br>
<br>
I find in many places in the code the following fragment:<br>
<br>
scale = size/symbol->sizey;<br>
<br>
without actually checking the value of symbol->sizey which may be zero<br>
eventually. This causes me unexpected problems, like for example a premature<br>
termination of the application during the pdf output.<br>
How about setting the symbol size to 1 instead of 0 in initSymbol to prevent<br>
from this problem?<br>
<br>
Best regards,<br>
<br>
Tamas<br>
<br>
<br>
<br>
2009/2/17 Steve Lime <<a href="mailto:Steve.Lime@dnr.state.mn.us">Steve.Lime@dnr.state.mn.us</a>><br>
<br>
</div><div><div></div><div class="Wj3C7c">> Show of hands please... ;-)<br>
><br>
> Steve<br>
><br>
> _______________________________________________<br>
> mapserver-dev mailing list<br>
> <a href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a><br>
> <a href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><br>
><br>
<br>
</div></div></blockquote></div><br>