Steve,<br><br>I've just applied the patch for both 5-6 and the trunk.<br><br>Best regards,<br><br>Tamas<br><br><br><div class="gmail_quote">2010/1/4 Lime, Steve D (DNR) <span dir="ltr"><<a href="mailto:Steve.Lime@state.mn.us">Steve.Lime@state.mn.us</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Tamas: Thanks for the patch, makes sense at first glance. Do you want to apply it or should I?<br>
<br>
Steve<br>
<br>
________________________________________<br>
From: <a href="mailto:mapserver-dev-bounces@lists.osgeo.org">mapserver-dev-bounces@lists.osgeo.org</a> [<a href="mailto:mapserver-dev-bounces@lists.osgeo.org">mapserver-dev-bounces@lists.osgeo.org</a>] On Behalf Of Tamas Szekeres [<a href="mailto:szekerest@gmail.com">szekerest@gmail.com</a>]<br>
Sent: Sunday, January 03, 2010 6:35 AM<br>
<div class="im">To: Lime, Steve D (DNR)<br>
Cc: <a href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a><br>
Subject: Re: [mapserver-dev] Call for a 5.6.1 release...<br>
<br>
</div><div class="im">Steve,<br>
<br>
I've also added some fixes for 5.6, and I would also require further fixes with regards to the querymap drawing which would indeed validate a new release.<br>
<br>
IMHO adding implicit layers to the map this way would bring in a couple of problems for the existing applications. It seems we make an assumption that the mapObj is destroyed after each drawQuery, however that's not the case with many of the mapscript applications. This approach would bring in extra unexpected layers for the users which are difficult to interpret.<br>
There are some further issues with msCopyLayer which doesn't seem to work correctly when the destination have already been initialized (see the implementation of msCopyProjection, insertFeatureList, copying the classes etc). This would at least result in memory leaks and assertion failures.<br>
<br>
As a quick solution I've created a patch (<a href="http://trac.osgeo.org/mapserver/attachment/ticket/3069/mapdraw.c.patch" target="_blank">http://trac.osgeo.org/mapserver/attachment/ticket/3069/mapdraw.c.patch</a>) to implement this kind of drawing without requiring to add the layer to the map.<br>
<br>
Not strictly related to this problem, but in a further release we should also consider how we could add futher styles (like transparency or hatch patterns) to the highlighted features. The current approach provides only a couple of colors to be replaced temporarily with the highligted items and most of my current use cases require to copy the selected features to inline layers for a more advanced styling. For this reason it would be appropriate to define the query styles by using some 'template' layers (with no data connections) which could be referred from each queryable layers. I suspect this approach would work as far as msDrawShape(map, layer, &shape,...) would work if we specify such template layers as the second parameter.<br>
<br>
<br>
Best regards,<br>
<br>
Tamas<br>
<br>
<br>
<br>
</div>2010/1/2 Lime, Steve D (DNR) <<a href="mailto:Steve.Lime@state.mn.us">Steve.Lime@state.mn.us</a><mailto:<a href="mailto:Steve.Lime@state.mn.us">Steve.Lime@state.mn.us</a>>><br>
<div class="im">Hi all: I just fixed a couple of inconvenient bugs in 5.6 that broke some point-based queries via the CGI. Without the fixes some<br>
folks won't be able to upgrade. I've got a whole bunch of query test cases I need to get into the automated testing to avoid this<br>
in the future. Are others sitting on changes in the 5.6 trunk that could go into 5.6.1?<br>
<br>
Steve<br>
<br>
BTW Ticket is <a href="http://trac.osgeo.org/mapserver/ticket/3246." target="_blank">http://trac.osgeo.org/mapserver/ticket/3246.</a>..<br>
_______________________________________________<br>
mapserver-dev mailing list<br>
</div><a href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a><mailto:<a href="mailto:mapserver-dev@lists.osgeo.org">mapserver-dev@lists.osgeo.org</a>><br>
<div><div></div><div class="h5"><a href="http://lists.osgeo.org/mailman/listinfo/mapserver-dev" target="_blank">http://lists.osgeo.org/mailman/listinfo/mapserver-dev</a><br>
<br>
</div></div></blockquote></div><br>